unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Michael Heerdegen <michael_heerdegen@web.de>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Lars Ingebrigtsen <larsi@gnus.org>, 38195@debbugs.gnu.org
Subject: bug#38195: 27.0.50; `edebug-remove-instrumentation' doesn't work for adviced functions
Date: Fri, 15 Nov 2019 14:54:04 +0100	[thread overview]
Message-ID: <87eey9z1mr.fsf@web.de> (raw)
In-Reply-To: <87imnm4315.fsf@web.de> (Michael Heerdegen's message of "Thu, 14 Nov 2019 21:27:18 +0100")

Hello again,

I'm preparing a new patch with less quirks.  I have a question about
advising macros now.  We don't say much about that, only this paragraph
in (info "(elisp) Advising Named Functions"):

   Special forms (*note Special Forms::) cannot be advised, however
macros can be advised, in much the same way as functions.  Of course,
this will not affect code that has already been macro-expanded, so you
need to make sure the advice is installed before the macro is expanded.

All good - but it seems that when you advice a macro, you actually
operate on the expander _function_.  Maybe we should speak that out more
clearly?  Because that implies that everything you deal with is a
function - e.g. in an :override advice you must specify a function - if
you specify a macro the thing breaks.

Michael.





  parent reply	other threads:[~2019-11-15 13:54 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-13 13:55 bug#38195: 27.0.50; `edebug-remove-instrumentation' doesn't work for adviced functions Michael Heerdegen
2019-11-14  5:20 ` Lars Ingebrigtsen
2019-11-14 16:51   ` Michael Heerdegen
2019-11-14 22:39     ` Michael Heerdegen
2019-11-15  7:57       ` Lars Ingebrigtsen
2019-11-15 12:39         ` Michael Heerdegen
2019-11-16  4:28           ` Lars Ingebrigtsen
2019-11-16 12:25             ` Michael Heerdegen
2019-11-14 16:55   ` Michael Heerdegen
2019-11-14 19:08     ` Stefan Monnier
2019-11-14 20:27       ` Michael Heerdegen
2019-11-14 21:33         ` Stefan Monnier
2019-11-15 13:54         ` Michael Heerdegen [this message]
2019-11-15 17:30           ` Stefan Monnier
2019-11-17 12:35             ` Michael Heerdegen
2019-11-17 12:55           ` Michael Heerdegen
2019-11-17 16:04             ` Stefan Monnier
2019-11-21 11:49               ` Michael Heerdegen
2019-11-23 13:32                 ` Michael Heerdegen
2019-11-26 21:01                 ` Michael Heerdegen
2019-11-27 12:17                   ` Lars Ingebrigtsen
2020-09-20 10:54                     ` Lars Ingebrigtsen
2019-11-14 21:15   ` Michael Heerdegen
2019-11-15  8:03     ` Lars Ingebrigtsen
2019-11-15 12:11       ` Michael Heerdegen
2019-11-15 12:15         ` Lars Ingebrigtsen
2019-11-15 12:34           ` Michael Heerdegen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87eey9z1mr.fsf@web.de \
    --to=michael_heerdegen@web.de \
    --cc=38195@debbugs.gnu.org \
    --cc=larsi@gnus.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).