bug#58292: [Patch] [GNU ELPA] rcirc-color: Fix bad minor mode definition

bug#58292: [Patch] [GNU ELPA] rcirc-color: Fix bad minor mode definition

[Thuna]

[-- Attachment #1: Type: text/plain, Size: 369 bytes --]

Currently, `define-minor-mode' signals an error upon evaluation.
Looking into it, it seems that is because there are not keyword
arguments given to it, which causes a problem according the docstring of
`define-minor-mode':
> If you provide BODY, then you must provide at least one keyword
> argument (e.g. ‘:lighter nil‘).

This patch should fix the issue.

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: The patch --]
[-- Type: text/x-patch, Size: 743 bytes --]

From 2c9ed7ccdf13396bec67bc4d411495dde64f1e98 Mon Sep 17 00:00:00 2001
From: Thuna <thuna.cing@gmail.com>
Date: Tue, 4 Oct 2022 19:31:48 +0200
Subject: [PATCH] Fix bad minor mode definition

* rcirc-color.el (rcirc-color-mode): Add a keyword argument to prevent
BODY from being interpreted as the variable value.
---
 rcirc-color.el | 1 +
 1 file changed, 1 insertion(+)

diff --git a/rcirc-color.el b/rcirc-color.el
index a197fb82a2..b7baa5c0c5 100644
--- a/rcirc-color.el
+++ b/rcirc-color.el
@@ -176,6 +176,7 @@ commands."
 ;;;###autoload
 (define-minor-mode rcirc-color-mode
   "Enable the highlighting of nicknames."
+  :lighter nil
   (cond
    (rcirc-color-mode
     (advice-add 'rcirc-facify :around #'rcirc-color--facify)
-- 
2.35.1

bug#58292: [Patch] [GNU ELPA] rcirc-color: Fix bad minor mode definition

[Lars Ingebrigtsen]

Thuna <thuna.cing@gmail.com> writes:

> Currently, `define-minor-mode' signals an error upon evaluation.
> Looking into it, it seems that is because there are not keyword
> arguments given to it, which causes a problem according the docstring of
> `define-minor-mode':
>> If you provide BODY, then you must provide at least one keyword
>> argument (e.g. ‘:lighter nil‘).
>
> This patch should fix the issue.

Looks like this was fixed earlier today by:

commit c206181d57c235b0a5f788b974d98e9cf1f7c4ec
Author:     Philip Kaludercic <philipk@posteo.net>
AuthorDate: Mon Oct 3 15:15:18 2022 +0200
Commit:     Philip Kaludercic <philipk@posteo.net>
CommitDate: Tue Oct 4 20:01:44 2022 +0200

    * rcirc-color.el (rcirc-color-mode): Add :global t
    
    Without at least one keyword argument, the body in interpreted as the
    an expression setting the initial value of the `rcirc-color-mode' via
    the legacy syntax from Emacs 21.