From: Thuna <thuna.cing@gmail.com>
To: 58292@debbugs.gnu.org
Subject: bug#58292: [Patch] [GNU ELPA] rcirc-color: Fix bad minor mode definition
Date: Tue, 04 Oct 2022 19:38:39 +0200 [thread overview]
Message-ID: <87edvnpjz4.fsf@gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 369 bytes --]
Currently, `define-minor-mode' signals an error upon evaluation.
Looking into it, it seems that is because there are not keyword
arguments given to it, which causes a problem according the docstring of
`define-minor-mode':
> If you provide BODY, then you must provide at least one keyword
> argument (e.g. ‘:lighter nil‘).
This patch should fix the issue.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: The patch --]
[-- Type: text/x-patch, Size: 743 bytes --]
From 2c9ed7ccdf13396bec67bc4d411495dde64f1e98 Mon Sep 17 00:00:00 2001
From: Thuna <thuna.cing@gmail.com>
Date: Tue, 4 Oct 2022 19:31:48 +0200
Subject: [PATCH] Fix bad minor mode definition
* rcirc-color.el (rcirc-color-mode): Add a keyword argument to prevent
BODY from being interpreted as the variable value.
---
rcirc-color.el | 1 +
1 file changed, 1 insertion(+)
diff --git a/rcirc-color.el b/rcirc-color.el
index a197fb82a2..b7baa5c0c5 100644
--- a/rcirc-color.el
+++ b/rcirc-color.el
@@ -176,6 +176,7 @@ commands."
;;;###autoload
(define-minor-mode rcirc-color-mode
"Enable the highlighting of nicknames."
+ :lighter nil
(cond
(rcirc-color-mode
(advice-add 'rcirc-facify :around #'rcirc-color--facify)
--
2.35.1
next reply other threads:[~2022-10-04 17:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-04 17:38 Thuna [this message]
2022-10-04 19:04 ` bug#58292: [Patch] [GNU ELPA] rcirc-color: Fix bad minor mode definition Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87edvnpjz4.fsf@gmail.com \
--to=thuna.cing@gmail.com \
--cc=58292@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).