From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Thuna Newsgroups: gmane.emacs.bugs Subject: bug#58292: [Patch] [GNU ELPA] rcirc-color: Fix bad minor mode definition Date: Tue, 04 Oct 2022 19:38:39 +0200 Message-ID: <87edvnpjz4.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11656"; mail-complaints-to="usenet@ciao.gmane.io" To: 58292@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Oct 04 19:39:19 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oflt1-0002td-TI for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 04 Oct 2022 19:39:19 +0200 Original-Received: from localhost ([::1]:60946 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oflt0-0008G0-Qo for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 04 Oct 2022 13:39:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57036) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oflsk-0008DN-QW for bug-gnu-emacs@gnu.org; Tue, 04 Oct 2022 13:39:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56038) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oflsk-0001TO-J8 for bug-gnu-emacs@gnu.org; Tue, 04 Oct 2022 13:39:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oflsk-0004vE-EB for bug-gnu-emacs@gnu.org; Tue, 04 Oct 2022 13:39:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Thuna Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 04 Oct 2022 17:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 58292 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.166490513218901 (code B ref -1); Tue, 04 Oct 2022 17:39:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 4 Oct 2022 17:38:52 +0000 Original-Received: from localhost ([127.0.0.1]:55116 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oflsa-0004un-3N for submit@debbugs.gnu.org; Tue, 04 Oct 2022 13:38:52 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:47656) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oflsX-0004ue-E1 for submit@debbugs.gnu.org; Tue, 04 Oct 2022 13:38:51 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34854) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oflsX-00089v-97 for bug-gnu-emacs@gnu.org; Tue, 04 Oct 2022 13:38:49 -0400 Original-Received: from mail-ed1-x536.google.com ([2a00:1450:4864:20::536]:44959) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oflsV-0001Q5-0Z for bug-gnu-emacs@gnu.org; Tue, 04 Oct 2022 13:38:48 -0400 Original-Received: by mail-ed1-x536.google.com with SMTP id g27so2955080edf.11 for ; Tue, 04 Oct 2022 10:38:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:message-id:date:subject:to:from:from:to:cc:subject :date:message-id:reply-to; bh=WZrH8YYdr1AUKMgyyDTV5n8sul05llRsYYkU46Bc3AA=; b=odKpuYXPFHrEhTqwsypeUjtImexGyxKmiwUj7m0xLCxqdp6fTRMdem0YeAxR+0V+6f E8cIj11EED+jE4H6Mgpqz+YkycETjek5fzfpBKWuxlWiv67VT1/bBR1mEEarYeDhTlH7 5IekBZhkyHwvlQZeHj+UfuWSUv42yLpfW8d7rrv+D306UFcstaxqwyHdA6+qpJtHPf6B lFW1UTFmwZgYHoa3GBEiIvKTFYnPT3Q36ALkQPosOKOUXRWazqv1onOUGwudm0YbTMZL 2/On0GZ5qNgs4NJCsy8D7K587KA5SxUgk1Medf6KaLPYQ4hXiOJcH0fcsGHSGvmpo03H ozlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:subject:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=WZrH8YYdr1AUKMgyyDTV5n8sul05llRsYYkU46Bc3AA=; b=EnUzJAF69APxXU08HjxqZq6MOIq5qW4iv43ff72Kwq7oTZICf1kSfsVVuPxNAHgNuh O/+9aw0sEf75Iqc7C/LxMfz/7pEFibgbwYyKbm2WhNVnzdIpK8lSbVphRrgd1mOyPT8/ rTKdeOqCLLr13aKFjDJsxvFsZ3nqQ8X7LmUm7hFw3PE7Q4eIsfIpiX97rGdypsrliKeb so22O14+AQKtzymEi/yTXZPl3b9RyFJ+N+L8/DBnuSvu1HJ0Lhat49XueJ+EzN93gRJ4 IAfGWB9sx50trEJI87WvBTPsv8K6RGWGkm+I/PwdseXLSUfA2MIru50dgtSXP52YV3Xe 14kA== X-Gm-Message-State: ACrzQf2u/XttILij7HVzyoVg85ZbeFQmGX9YzPuiF0Vv7CRdlzwZBBoM a2/TzfBeBD1z9qVWtJHymKqrTIiEOZ0= X-Google-Smtp-Source: AMsMyM6+q2ppSDiX+US8KN3LXw4nuSG+R4EHtdqAImYJP9WYLsNWDbZ5f1gqRpJZ+QpYMTBNJ18+8A== X-Received: by 2002:a05:6402:540d:b0:450:bda7:f76e with SMTP id ev13-20020a056402540d00b00450bda7f76emr24668952edb.249.1664905124473; Tue, 04 Oct 2022 10:38:44 -0700 (PDT) Original-Received: from thuna ([90.147.71.176]) by smtp.gmail.com with ESMTPSA id r9-20020aa7cb89000000b0045920b019a9sm2062067edt.95.2022.10.04.10.38.43 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Oct 2022 10:38:43 -0700 (PDT) Received-SPF: pass client-ip=2a00:1450:4864:20::536; envelope-from=thuna.cing@gmail.com; helo=mail-ed1-x536.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:244458 Archived-At: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Currently, `define-minor-mode' signals an error upon evaluation. Looking into it, it seems that is because there are not keyword arguments given to it, which causes a problem according the docstring of `define-minor-mode': > If you provide BODY, then you must provide at least one keyword > argument (e.g. =E2=80=98:lighter nil=E2=80=98). This patch should fix the issue. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Fix-bad-minor-mode-definition.patch Content-Description: The patch >From 2c9ed7ccdf13396bec67bc4d411495dde64f1e98 Mon Sep 17 00:00:00 2001 From: Thuna Date: Tue, 4 Oct 2022 19:31:48 +0200 Subject: [PATCH] Fix bad minor mode definition * rcirc-color.el (rcirc-color-mode): Add a keyword argument to prevent BODY from being interpreted as the variable value. --- rcirc-color.el | 1 + 1 file changed, 1 insertion(+) diff --git a/rcirc-color.el b/rcirc-color.el index a197fb82a2..b7baa5c0c5 100644 --- a/rcirc-color.el +++ b/rcirc-color.el @@ -176,6 +176,7 @@ commands." ;;;###autoload (define-minor-mode rcirc-color-mode "Enable the highlighting of nicknames." + :lighter nil (cond (rcirc-color-mode (advice-add 'rcirc-facify :around #'rcirc-color--facify) -- 2.35.1 --=-=-=--