From: Michael Heerdegen <michael_heerdegen@web.de>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 38317@debbugs.gnu.org, Federico Tedin <federicotedin@gmail.com>
Subject: bug#38317: Buffer-local variables don't work as history for read-from-minibuffer
Date: Fri, 22 Nov 2019 16:23:49 +0100 [thread overview]
Message-ID: <87pnhkory2.fsf@web.de> (raw)
In-Reply-To: <87v9rcqbls.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 22 Nov 2019 14:33:51 +0100")
Lars Ingebrigtsen <larsi@gnus.org> writes:
> Looking at the code in read_minibuf, it does seem to access the
> buffer-local value of the HIST variable, but my guess is that the buffer
> it's looking at is the minibuffer? And the variable isn't buffer-local
> there.
The problem is M-p: this command is called with the minibuffer current.
The helper `goto-history-element' calls (symbol-value
minibuffer-history-variable) and that returns the binding of the
variable in the minibuffer. Adding to the buffer local history already
works as expected OTOH, so the behavior is inconsistent.
Dunno if there are more inconsistencies to expect when trying to fix
M-p. My personal point of view is that when we can make it work without
risking breakage of anything else it would be nice to fix this.
Michael.
next prev parent reply other threads:[~2019-11-22 15:23 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-21 21:30 bug#38317: Buffer-local variables don't work as history for read-from-minibuffer Federico Tedin
2019-11-22 13:33 ` Lars Ingebrigtsen
2019-11-22 15:23 ` Michael Heerdegen [this message]
2019-11-22 16:24 ` martin rudalics
2019-11-23 11:54 ` Lars Ingebrigtsen
2019-11-23 20:36 ` Federico Tedin
2019-11-23 23:12 ` Federico Tedin
2019-11-26 21:54 ` Federico Tedin
2019-11-27 8:14 ` Robert Pluim
2019-11-27 15:24 ` Drew Adams
2019-11-27 15:28 ` Robert Pluim
2019-11-27 11:53 ` Lars Ingebrigtsen
2019-11-27 18:50 ` Federico Tedin
2019-11-27 19:25 ` Eli Zaretskii
2019-11-27 21:04 ` Federico Tedin
2019-11-28 12:05 ` Federico Tedin
2019-12-05 9:31 ` Lars Ingebrigtsen
2019-11-29 5:22 ` Richard Stallman
2019-11-29 10:21 ` Eli Zaretskii
2019-11-29 17:02 ` Federico Tedin
2019-12-01 5:59 ` Richard Stallman
2019-11-27 21:19 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pnhkory2.fsf@web.de \
--to=michael_heerdegen@web.de \
--cc=38317@debbugs.gnu.org \
--cc=federicotedin@gmail.com \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).