From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Michael Heerdegen Newsgroups: gmane.emacs.bugs Subject: bug#38317: Buffer-local variables don't work as history for read-from-minibuffer Date: Fri, 22 Nov 2019 16:23:49 +0100 Message-ID: <87pnhkory2.fsf@web.de> References: <87eey0lxxm.fsf@gmail.com> <87v9rcqbls.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="170151"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 38317@debbugs.gnu.org, Federico Tedin To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Nov 22 16:25:34 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iYAoQ-000i7Y-Dm for geb-bug-gnu-emacs@m.gmane.org; Fri, 22 Nov 2019 16:25:34 +0100 Original-Received: from localhost ([::1]:52080 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iYAoO-0003qQ-Pl for geb-bug-gnu-emacs@m.gmane.org; Fri, 22 Nov 2019 10:25:33 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42215) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iYAnw-0003qK-MK for bug-gnu-emacs@gnu.org; Fri, 22 Nov 2019 10:25:05 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iYAnv-0004br-Ip for bug-gnu-emacs@gnu.org; Fri, 22 Nov 2019 10:25:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46553) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iYAnv-0004bY-BC for bug-gnu-emacs@gnu.org; Fri, 22 Nov 2019 10:25:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iYAnv-00049Z-6Y for bug-gnu-emacs@gnu.org; Fri, 22 Nov 2019 10:25:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Michael Heerdegen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 22 Nov 2019 15:25:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38317 X-GNU-PR-Package: emacs Original-Received: via spool by 38317-submit@debbugs.gnu.org id=B38317.157443624415890 (code B ref 38317); Fri, 22 Nov 2019 15:25:03 +0000 Original-Received: (at 38317) by debbugs.gnu.org; 22 Nov 2019 15:24:04 +0000 Original-Received: from localhost ([127.0.0.1]:55374 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iYAmy-00048E-AG for submit@debbugs.gnu.org; Fri, 22 Nov 2019 10:24:04 -0500 Original-Received: from mout.web.de ([212.227.15.3]:46965) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iYAmv-00047i-7L for 38317@debbugs.gnu.org; Fri, 22 Nov 2019 10:24:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1574436233; bh=Own0u7hhSEOlW7CbgaN/SBecfMG0khD1KY6I/zne1QY=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=qXLkeZjjRsB18kzmx+g5acNahQ4RBSfL/SPA/MTGlTL1XtPCrHuzVJEtlUp4jwKqi ZpO3D/iVDf7Z01Vv5Xp0a9Dl6K8fMKixVZbMCCjtTcD653mU7SbarndTSAaJlgPe/6 y+8lcWsTLcan1Nb16kRT5L/ZN2XnNKfWk1t/7cb8= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Original-Received: from drachen.dragon ([94.218.222.9]) by smtp.web.de (mrweb003 [213.165.67.108]) with ESMTPSA (Nemesis) id 0MIeTI-1iaMdt0ZIW-002E8z; Fri, 22 Nov 2019 16:23:53 +0100 In-Reply-To: <87v9rcqbls.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 22 Nov 2019 14:33:51 +0100") X-Provags-ID: V03:K1:wt2Fgph5udkKuTfa8DwtWuerR1C4MnIdWMgHD53KPhicSw8xYh4 kX6wKamcqpUicki9luc7HvV74FrxESrnQD5q8divhh3sQ0PB9HPvsdxSCYNzwNYqfQRxsEE rR7o22TeJDZO8w0mhhLGmTZiqBOqknfVnvMehtxaNkRCs7oiKBoraC0ajQW56vNSFEsC7cG 0EMyA2T2RkDRjBxkGy4dg== X-UI-Out-Filterresults: notjunk:1;V03:K0:EV6/mMBoDp0=:ZraM1/EblEjP3FbcKP8jpz ywp3iTsNp8Gg2tZfYCDDccYV6Me9e/2LYM0qTrFhNnditq8K9QFq2iLWzndi8qI8JCtIMqQfS qR7VF2iW06JTq/qRyfblOlD7HX+BRhO16hTv9qOcCAanPQ+N5H9kFgkxUtukmB4uYDU7RfVN5 t6nh0LMj3iJikB7M5wKCEkZT4LUVtU48pCcIxBQlwdCNiSjl6Fw0M6BoDA2lXvcGj/6PV9UxL 5lN5EyG5CTdbYHKaqxCTWqiaYrLJJvpCeabAD6N8AgxO+gg22Dgkoo2YQLXgFfsAbYwO4w44a wblzGkT3NI6V0d3Pbf8uc7fOXRZzNphwjuCYXspLiiHmpI+X+8S0I8B2BVJSGFaWbHjxuXH6a LJV4JTaYlg7iKT19/M1CqszelGtH96dmb+ouGN9EeySlhHd0NdSJp2vPqb+q3qMoobFnyW6J/ Yhrt1Hlc2fcVWQMtZ9wlhgY/YttLKXTRvcg89BD+N9EnQi7AG1FUt2WOScP3kOvViHQ/hH/rB g3Of/jWkPbdndMIREINvXYamtBz9rZxI5KNF/eScBDqs04M02baPyEptQG0EaU0B53D6OK13A Vf7as51iQX8JZj/vgSrh8BktrWAJWFhFTZQaya3hrzkX6cCUOfkT1s/B1nJUtbBdwTIwEFy92 qjApcBE8xSsQvbl7SytTRSNrJP58BesYix3gOQK0U3b3WrRZ4G2kRMLecZUnvb12OFJt9EpSN +KppKkaVNMoS+JAPFrMECwM9R+Ex+FOajYMJi9rDg3H2h65kfmRCOFF2DtGiv9KKajWmsvtE X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:172242 Archived-At: Lars Ingebrigtsen writes: > Looking at the code in read_minibuf, it does seem to access the > buffer-local value of the HIST variable, but my guess is that the buffer > it's looking at is the minibuffer? And the variable isn't buffer-local > there. The problem is M-p: this command is called with the minibuffer current. The helper `goto-history-element' calls (symbol-value minibuffer-history-variable) and that returns the binding of the variable in the minibuffer. Adding to the buffer local history already works as expected OTOH, so the behavior is inconsistent. Dunno if there are more inconsistencies to expect when trying to fix M-p. My personal point of view is that when we can make it work without risking breakage of anything else it would be nice to fix this. Michael.