From: Federico Tedin <federicotedin@gmail.com>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 38317@debbugs.gnu.org
Subject: bug#38317: Buffer-local variables don't work as history for read-from-minibuffer
Date: Sat, 23 Nov 2019 21:36:10 +0100 [thread overview]
Message-ID: <874kyu72kl.fsf@gmail.com> (raw)
In-Reply-To: <875zjareo1.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sat, 23 Nov 2019 12:54:38 +0100")
I've been looking into the problem, what I found so far is:
`read-from-minibuffer' works normally if HIST is not buffer-local.
If HIST is buffer-local, then the history variable doesn't seem to be
updated correctly after returning (so using M-p and M-n doesn't do
anything).
My test was:
(setq test-history nil)
(make-variable-buffer-local 'test-history)
(read-from-minibuffer "" nil nil nil 'test-history)
After running that and inputting "hello", I checked:
(buffer-local-value 'test-history (current-buffer)) ;; -> nil
(buffer-local-value 'test-history (get-buffer " *Minibuf-0*")) ;; -> nil
(buffer-local-value 'test-history (get-buffer " *Minibuf-1*")) ;; -> nil
So although `read_minibuf' does call `add-to-history' before returning
(and after setting the current buffer to be the minibuffer's), my input
wasn't added to any list (that I know of). This is strange, since
`add-to-history' seemed to work correctly with buffer-local variables
when I tested it separately. I would've expected the new history item to
be added to one of the minibuffer's `test-history' local variable.
So I think the first step would be to make `read_minibuf' add the new
history item into the right place when HIST is buffer-local.
next prev parent reply other threads:[~2019-11-23 20:36 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-21 21:30 bug#38317: Buffer-local variables don't work as history for read-from-minibuffer Federico Tedin
2019-11-22 13:33 ` Lars Ingebrigtsen
2019-11-22 15:23 ` Michael Heerdegen
2019-11-22 16:24 ` martin rudalics
2019-11-23 11:54 ` Lars Ingebrigtsen
2019-11-23 20:36 ` Federico Tedin [this message]
2019-11-23 23:12 ` Federico Tedin
2019-11-26 21:54 ` Federico Tedin
2019-11-27 8:14 ` Robert Pluim
2019-11-27 15:24 ` Drew Adams
2019-11-27 15:28 ` Robert Pluim
2019-11-27 11:53 ` Lars Ingebrigtsen
2019-11-27 18:50 ` Federico Tedin
2019-11-27 19:25 ` Eli Zaretskii
2019-11-27 21:04 ` Federico Tedin
2019-11-28 12:05 ` Federico Tedin
2019-12-05 9:31 ` Lars Ingebrigtsen
2019-11-29 5:22 ` Richard Stallman
2019-11-29 10:21 ` Eli Zaretskii
2019-11-29 17:02 ` Federico Tedin
2019-12-01 5:59 ` Richard Stallman
2019-11-27 21:19 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874kyu72kl.fsf@gmail.com \
--to=federicotedin@gmail.com \
--cc=38317@debbugs.gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).