From: "Basil L. Contovounesios" <contovob@tcd.ie>
To: Tino Calancha <tino.calancha@gmail.com>
Cc: rrt@sc3d.org, Noam Postavsky <npostavs@gmail.com>,
30280@debbugs.gnu.org, Juri Linkov <juri@linkov.net>
Subject: bug#30280: async-shell-command-display-buffer doesn't work anymore
Date: Wed, 09 May 2018 19:29:25 +0100 [thread overview]
Message-ID: <87lgcs1y4a.fsf@tcd.ie> (raw)
In-Reply-To: <87r2mlszhx.fsf@gmail.com> (Tino Calancha's message of "Wed, 09 May 2018 22:57:30 +0900")
Tino Calancha <tino.calancha@gmail.com> writes:
> I have two minor comments.
>
> I)
>> +(declare-function comint-output-filter "comint" (process string))
>> +
> What is the purpose of this? AFICT no warning is shown when compiling
> the file.
On my end, removing the function declaration and invoking 'make' results
in the following output:
...
make[2]: Entering directory '/home/blc/.local/src/emacs/lisp'
ELC ../lisp/simple.elc
Reloading stale loaddefs.el
Loading /home/blc/.local/src/emacs/lisp/loaddefs.el (source)...
In end of data:
simple.el:9030:1:Warning: the function ‘comint-output-filter’ is not known to
be defined.
...
Note that this warning is only emitted when comint-output-filter is
#'-quoted. This is in line with the usual behaviour of the
byte-compiler that I am accustomed to, i.e. I don't see anything out of
the ordinary here.
> * We require `shell.el' inside `shell-coomand'.
> * `shell.el' requires `comint.el'.
Yes, I understand that using comint-output-filter at this point in the
program is kosher, but the byte-compiler evidently does not.
> Is the purpose to serve as documentation? In that case I don't think we
> need it (the prefix 'comint-' already makes obvious where this function
> belongs to).
No, the only intention is to pacify the byte-compiler.
> II)
> It's better to keep consistent with the indentation of the function you
> are modifying: here, `shell-command' is indenting with TAB.
>
> Tip:
> You can see the tabs searching them with:
> C-s C-q C-I
> or you can persistenly highlight them with:
> M-s h r C-I RET RET
Thanks for the tip. I personally prefer to use [global-]whitespace-mode
with a whitespace-style setting which includes (face tab-mark).
I additionally avoid accidentally committing tabs by configuring the git
option core.whitespace to include tab-in-indent.
> For instance, here you are changing:
> 1) ' ---> #'
> ;; and
> 2) \t\t\s\s 000> \s\s\s\s...\s (18 white spaces)
>
> Please, do not change 2).
I have no strong feeling on this; I was merely going along with the
(emacs-lisp-mode . ((indent-tabs-mode . nil))) setting in the project's
toplevel dir-locals-file, as well what I had inferred to be accepted
policy (as Noam mentions in a separate email) from following Emacs
development for the last couple of years.
If it weren't for the above and the fact that most everything I have
come across in the Emacs tree has Frankindentation (including the target
function shell-command), I would be more inclined to remain consistent
with the surrounding source.
Let me know if it's still a problem and I'll gladly resend the patches
with indent-tabs-mode enabled.
Thanks again for your help and feedback,
--
Basil
next prev parent reply other threads:[~2018-05-09 18:29 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-28 22:20 bug#30280: async-shell-command-display-buffer doesn't work anymore Juri Linkov
2018-01-29 17:24 ` Eli Zaretskii
2018-01-29 21:40 ` Juri Linkov
2018-01-30 3:24 ` Eli Zaretskii
2018-01-30 18:53 ` Basil L. Contovounesios
2018-01-30 19:06 ` Reuben Thomas
2018-01-31 21:44 ` Juri Linkov
2018-02-02 10:42 ` Eli Zaretskii
2018-02-03 14:13 ` Basil L. Contovounesios
2018-02-03 21:27 ` Juri Linkov
2018-05-06 16:18 ` Basil L. Contovounesios
2018-05-07 7:35 ` Tino Calancha
2018-05-09 11:54 ` Basil L. Contovounesios
2018-05-09 13:57 ` Tino Calancha
2018-05-09 14:10 ` Noam Postavsky
2018-05-09 14:24 ` Tino Calancha
2018-05-09 18:29 ` Basil L. Contovounesios [this message]
2018-05-10 2:13 ` Tino Calancha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lgcs1y4a.fsf@tcd.ie \
--to=contovob@tcd.ie \
--cc=30280@debbugs.gnu.org \
--cc=juri@linkov.net \
--cc=npostavs@gmail.com \
--cc=rrt@sc3d.org \
--cc=tino.calancha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).