From: Tino Calancha <tino.calancha@gmail.com>
To: <contovob@tcd.ie>
Cc: rrt@sc3d.org, 30280@debbugs.gnu.org, Juri Linkov <juri@linkov.net>
Subject: bug#30280: async-shell-command-display-buffer doesn't work anymore
Date: Wed, 09 May 2018 22:57:30 +0900 [thread overview]
Message-ID: <87r2mlszhx.fsf@gmail.com> (raw)
In-Reply-To: <87zi1911tg.fsf@tcd.ie> (Basil L. Contovounesios's message of "Wed, 09 May 2018 12:54:51 +0100")
"Basil L. Contovounesios" <contovob@tcd.ie> writes:
> I reattach the patches with the buffer name changes removed.
Thank you Basil!
IMHO this patch looks OK.
I have two minor comments.
I)
> +(declare-function comint-output-filter "comint" (process string))
> +
What is the purpose of this? AFICT no warning is shown when compiling
the file.
* We require `shell.el' inside `shell-coomand'.
* `shell.el' requires `comint.el'.
Is the purpose to serve as documentation? In that case I don't think we
need it (the prefix 'comint-' already makes obvious where this function
belongs to).
II)
It's better to keep consistent with the indentation of the function you
are modifying: here, `shell-command' is indenting with TAB.
Tip:
You can see the tabs searching them with:
C-s C-q C-I
or you can persistenly highlight them with:
M-s h r C-I RET RET
For instance, here you are changing:
1) ' ---> #'
;; and
2) \t\t\s\s 000> \s\s\s\s...\s (18 white spaces)
Please, do not change 2).
> ;; Use the comint filter for proper handling of
> ;; carriage motion (see comint-inhibit-carriage-motion).
> - (set-process-filter proc 'comint-output-filter)
> + (set-process-filter proc #'comint-output-filter)
> (if async-shell-command-display-buffer
> ;; Display buffer immediately.
> (display-buffer buffer '(nil (allow-no-window . t)))
next prev parent reply other threads:[~2018-05-09 13:57 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-28 22:20 bug#30280: async-shell-command-display-buffer doesn't work anymore Juri Linkov
2018-01-29 17:24 ` Eli Zaretskii
2018-01-29 21:40 ` Juri Linkov
2018-01-30 3:24 ` Eli Zaretskii
2018-01-30 18:53 ` Basil L. Contovounesios
2018-01-30 19:06 ` Reuben Thomas
2018-01-31 21:44 ` Juri Linkov
2018-02-02 10:42 ` Eli Zaretskii
2018-02-03 14:13 ` Basil L. Contovounesios
2018-02-03 21:27 ` Juri Linkov
2018-05-06 16:18 ` Basil L. Contovounesios
2018-05-07 7:35 ` Tino Calancha
2018-05-09 11:54 ` Basil L. Contovounesios
2018-05-09 13:57 ` Tino Calancha [this message]
2018-05-09 14:10 ` Noam Postavsky
2018-05-09 14:24 ` Tino Calancha
2018-05-09 18:29 ` Basil L. Contovounesios
2018-05-10 2:13 ` Tino Calancha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r2mlszhx.fsf@gmail.com \
--to=tino.calancha@gmail.com \
--cc=30280@debbugs.gnu.org \
--cc=contovob@tcd.ie \
--cc=juri@linkov.net \
--cc=rrt@sc3d.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).