From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.bugs Subject: bug#30280: async-shell-command-display-buffer doesn't work anymore Date: Wed, 09 May 2018 19:29:25 +0100 Message-ID: <87lgcs1y4a.fsf@tcd.ie> References: <87a7wxd1g9.fsf@mail.linkov.net> <83607kinmx.fsf@gnu.org> <877erz41re.fsf@tcd.ie> <87zi4tu2ic.fsf@mail.linkov.net> <83lggbd661.fsf@gnu.org> <87tvuyqhz8.fsf@tcd.ie> <87tvuxojag.fsf@mail.linkov.net> <874ljkn4fb.fsf@tcd.ie> <87zi1budeg.fsf@gmail.com> <87zi1911tg.fsf@tcd.ie> <87r2mlszhx.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1525891070 29435 195.159.176.226 (9 May 2018 18:37:50 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 9 May 2018 18:37:50 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: rrt@sc3d.org, Noam Postavsky , 30280@debbugs.gnu.org, Juri Linkov To: Tino Calancha Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed May 09 20:37:45 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fGTyD-0007aF-0g for geb-bug-gnu-emacs@m.gmane.org; Wed, 09 May 2018 20:37:45 +0200 Original-Received: from localhost ([::1]:58471 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fGU0K-0001XB-A8 for geb-bug-gnu-emacs@m.gmane.org; Wed, 09 May 2018 14:39:56 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34138) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fGTqo-0000eM-SE for bug-gnu-emacs@gnu.org; Wed, 09 May 2018 14:30:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fGTqk-0003Zw-RI for bug-gnu-emacs@gnu.org; Wed, 09 May 2018 14:30:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:47654) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fGTqk-0003Zd-OC for bug-gnu-emacs@gnu.org; Wed, 09 May 2018 14:30:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fGTqk-0004O3-A6 for bug-gnu-emacs@gnu.org; Wed, 09 May 2018 14:30:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 09 May 2018 18:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30280 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 30280-submit@debbugs.gnu.org id=B30280.152589057516797 (code B ref 30280); Wed, 09 May 2018 18:30:02 +0000 Original-Received: (at 30280) by debbugs.gnu.org; 9 May 2018 18:29:35 +0000 Original-Received: from localhost ([127.0.0.1]:55548 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fGTqJ-0004Mr-7s for submit@debbugs.gnu.org; Wed, 09 May 2018 14:29:35 -0400 Original-Received: from mail-wr0-f179.google.com ([209.85.128.179]:36416) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fGTqH-0004Mc-EH for 30280@debbugs.gnu.org; Wed, 09 May 2018 14:29:33 -0400 Original-Received: by mail-wr0-f179.google.com with SMTP id p4-v6so6195559wrh.3 for <30280@debbugs.gnu.org>; Wed, 09 May 2018 11:29:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:mail-followup-to:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=V1gpGxsWq9mdqcBFloVprPzly2v3tmSND6Y7oSvoY/g=; b=I9N2NZ01qP29OtyenWGIczZoL3ZiV3D23mb7U1PJ6/X+TrAXTMLMPqJv8XCk2NSOP0 LZV7lkp3Fq0+0amWJmDYPVTIvlhgX6C12X4BWX/aXVlViyesVY9XqJqskyN81U0fPZn8 ncodFlzGkac9ukO+n1nNI1bafFQUEI/8ig2JXekixV1Vpd02oqLWv2NOuOabotEEop3g UDEI1zj84HhXGlYWcPw62Kftl31aKyT0By9+uv0GzgR65IqzNW61ZxL02FE2UGEVPl5P kQ9PGlXKrz/7IIfhYdNC8V2OpigYqcHs7TmvgeGpHRC3PkGeovdD0Hr1Mank0htZIERK LuuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:mail-followup-to :date:in-reply-to:message-id:user-agent:mime-version :content-transfer-encoding; bh=V1gpGxsWq9mdqcBFloVprPzly2v3tmSND6Y7oSvoY/g=; b=CwBVQ+OJOUEMaAFAd/MW/1eXOoR45se1zPwRzNpuBKr2tjhN9e7vzZw5Vk7a+Xi9j4 gQKnkkDW9VJnegr88lSSALnhZKAAIBKM0Jb1rDVKZpDMiAIV1ZlPy8J+w6c3yGDevWNh rE2IND5ksBFJir/C7ag2Y1lGXydUQjkpAmBdF550fGrX2qax6WfwTeAi2LLMQvNlaZ/f 8q1aSoQJCwebfOPyCijew6j471FVJ/BaxxU40gMS9YWT87tPitC18V0mzQrxjxsmGtSW EMDHMOjeAgYB30CL47I43kJwJ2oRRbUFbfEyUYA+ObR2r6EighJJET1SQGrQ1g1KuZxq POaQ== X-Gm-Message-State: ALQs6tDSxCoUAFJYwCYPY8OSqQyzyahtDzjffCu9z/MTe16IY/F3juG+ bOJv3Wq+92xn8Ag0xv/efTS/sA== X-Google-Smtp-Source: AB8JxZq5b1zy16/cGR7ImqgEROrzavCIjW0H3VU5fa7OQMDomoKULxW2A+XYjoJ5JJvr4p8oEDRU/w== X-Received: by 2002:adf:9a54:: with SMTP id z78-v6mr35850054wrb.235.1525890567701; Wed, 09 May 2018 11:29:27 -0700 (PDT) Original-Received: from localhost ([178.62.40.52]) by smtp.gmail.com with ESMTPSA id y6-v6sm11620534wmy.39.2018.05.09.11.29.26 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 09 May 2018 11:29:26 -0700 (PDT) Mail-Followup-To: Tino Calancha , , <30280@debbugs.gnu.org>, Juri Linkov , Eli Zaretskii , Noam Postavsky In-Reply-To: <87r2mlszhx.fsf@gmail.com> (Tino Calancha's message of "Wed, 09 May 2018 22:57:30 +0900") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:146096 Archived-At: Tino Calancha writes: > I have two minor comments. > > I) >> +(declare-function comint-output-filter "comint" (process string)) >> + > What is the purpose of this? AFICT no warning is shown when compiling > the file. On my end, removing the function declaration and invoking 'make' results in the following output: ... make[2]: Entering directory '/home/blc/.local/src/emacs/lisp' ELC ../lisp/simple.elc Reloading stale loaddefs.el Loading /home/blc/.local/src/emacs/lisp/loaddefs.el (source)... In end of data: simple.el:9030:1:Warning: the function =E2=80=98comint-output-filter=E2=80= =99 is not known to be defined. ... Note that this warning is only emitted when comint-output-filter is #'-quoted. This is in line with the usual behaviour of the byte-compiler that I am accustomed to, i.e. I don't see anything out of the ordinary here. > * We require `shell.el' inside `shell-coomand'. > * `shell.el' requires `comint.el'. Yes, I understand that using comint-output-filter at this point in the program is kosher, but the byte-compiler evidently does not. > Is the purpose to serve as documentation? In that case I don't think we > need it (the prefix 'comint-' already makes obvious where this function > belongs to). No, the only intention is to pacify the byte-compiler. > II) > It's better to keep consistent with the indentation of the function you > are modifying: here, `shell-command' is indenting with TAB. > > Tip: > You can see the tabs searching them with: > C-s C-q C-I > or you can persistenly highlight them with: > M-s h r C-I RET RET Thanks for the tip. I personally prefer to use [global-]whitespace-mode with a whitespace-style setting which includes (face tab-mark). I additionally avoid accidentally committing tabs by configuring the git option core.whitespace to include tab-in-indent. > For instance, here you are changing: > 1) ' ---> #' > ;; and > 2) \t\t\s\s 000> \s\s\s\s...\s (18 white spaces) > > Please, do not change 2). I have no strong feeling on this; I was merely going along with the (emacs-lisp-mode . ((indent-tabs-mode . nil))) setting in the project's toplevel dir-locals-file, as well what I had inferred to be accepted policy (as Noam mentions in a separate email) from following Emacs development for the last couple of years. If it weren't for the above and the fact that most everything I have come across in the Emacs tree has Frankindentation (including the target function shell-command), I would be more inclined to remain consistent with the surrounding source. Let me know if it's still a problem and I'll gladly resend the patches with indent-tabs-mode enabled. Thanks again for your help and feedback, --=20 Basil