From: Noam Postavsky <npostavs@gmail.com>
To: David Biesack <David.Biesack@Apiture.com>
Cc: "36877@debbugs.gnu.org" <36877@debbugs.gnu.org>
Subject: bug#36877: 25.3; uniquify renaway uniquify-managed list
Date: Tue, 20 Aug 2019 22:47:42 -0400 [thread overview]
Message-ID: <87lfvnnsj5.fsf@gmail.com> (raw)
In-Reply-To: <9755920B-2303-4819-BD8A-CB238F29E1BA@apiture.com> (David Biesack's message of "Tue, 20 Aug 2019 15:07:49 +0000")
[-- Attachment #1: Type: text/plain, Size: 395 bytes --]
David Biesack <David.Biesack@Apiture.com> writes:
> Attached is a backtrace.
> Let me know if there is other advice I can add to help track this down.
The attachment seems to be missing. But anyway, I have a simple
reproducer now, so we don't need any more backtraces. I found setting
uniquify-after-kill-buffer-p to nil was needed to reproduce this, do you
have that setting in your init?
[-- Attachment #2: bug reproducer --]
[-- Type: text/plain, Size: 1077 bytes --]
(defconst bug-36877-dup-table (make-hash-table :test 'eq))
(defun bug-36877-debug-fix-list-dups (fix-list)
(clrhash bug-36877-dup-table)
(dolist (item fix-list)
(let ((buf (uniquify-item-buffer item)))
(if (gethash buf bug-36877-dup-table)
(progn (debug nil "Adding duplicate to uniquify list!" item)
;; Just once.
(advice-remove 'uniquify-rationalize
#'bug-36877-debug-fix-list-dups))
(puthash buf item bug-36877-dup-table)))))
(advice-add 'uniquify-rationalize :before #'bug-36877-debug-fix-list-dups)
(setq uniquify-after-kill-buffer-p nil)
(defconst bug-36877-topdir (file-name-directory
(or load-file-name
buffer-file-name)))
(dolist (dir '("a" "b" "c"))
(setq dir (expand-file-name dir bug-36877-topdir))
(make-directory dir t)
(find-file (expand-file-name "foo" dir)))
(kill-buffer (get-file-buffer (expand-file-name "c/foo" bug-36877-topdir)))
(find-file (expand-file-name "c/foo" bug-36877-topdir))
next prev parent reply other threads:[~2019-08-21 2:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-31 16:04 bug#36877: 25.3; uniquify renaway uniquify-managed list David Biesack
2019-08-09 0:47 ` Noam Postavsky
2019-08-09 15:58 ` David Biesack
2019-08-15 17:20 ` Noam Postavsky
2019-08-16 14:36 ` David Biesack
2019-08-18 17:51 ` Noam Postavsky
2019-08-20 15:07 ` David Biesack
2019-08-21 2:47 ` Noam Postavsky [this message]
2019-08-21 12:47 ` David Biesack
2020-11-25 17:19 ` David Biesack
2021-05-12 15:37 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lfvnnsj5.fsf@gmail.com \
--to=npostavs@gmail.com \
--cc=36877@debbugs.gnu.org \
--cc=David.Biesack@Apiture.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).