From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#36877: 25.3; uniquify renaway uniquify-managed list Date: Tue, 20 Aug 2019 22:47:42 -0400 Message-ID: <87lfvnnsj5.fsf@gmail.com> References: <183FDF33-F082-4E2F-BC62-6156A83FFADD@apiture.com> <87imr7qi58.fsf@gmail.com> <80998773-A88F-4750-84EC-1E73171A399A@apiture.com> <85d0h6l50y.fsf@gmail.com> <87a7c6pdkj.fsf@gmail.com> <9755920B-2303-4819-BD8A-CB238F29E1BA@apiture.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="206036"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2.90 (gnu/linux) Cc: "36877@debbugs.gnu.org" <36877@debbugs.gnu.org> To: David Biesack Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Aug 21 04:48:10 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i0GfS-000rVB-0l for geb-bug-gnu-emacs@m.gmane.org; Wed, 21 Aug 2019 04:48:10 +0200 Original-Received: from localhost ([::1]:43552 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i0GfQ-0007s2-8u for geb-bug-gnu-emacs@m.gmane.org; Tue, 20 Aug 2019 22:48:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40661) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i0GfL-0007ru-32 for bug-gnu-emacs@gnu.org; Tue, 20 Aug 2019 22:48:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i0GfK-0004qV-2J for bug-gnu-emacs@gnu.org; Tue, 20 Aug 2019 22:48:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53787) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i0GfJ-0004qL-Ru for bug-gnu-emacs@gnu.org; Tue, 20 Aug 2019 22:48:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1i0GfJ-0005oj-OP for bug-gnu-emacs@gnu.org; Tue, 20 Aug 2019 22:48:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 21 Aug 2019 02:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36877 X-GNU-PR-Package: emacs Original-Received: via spool by 36877-submit@debbugs.gnu.org id=B36877.156635567322349 (code B ref 36877); Wed, 21 Aug 2019 02:48:01 +0000 Original-Received: (at 36877) by debbugs.gnu.org; 21 Aug 2019 02:47:53 +0000 Original-Received: from localhost ([127.0.0.1]:34375 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i0GfA-0005oM-CA for submit@debbugs.gnu.org; Tue, 20 Aug 2019 22:47:53 -0400 Original-Received: from mail-io1-f47.google.com ([209.85.166.47]:45909) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i0Gf8-0005o8-8B for 36877@debbugs.gnu.org; Tue, 20 Aug 2019 22:47:50 -0400 Original-Received: by mail-io1-f47.google.com with SMTP id t3so1518586ioj.12 for <36877@debbugs.gnu.org>; Tue, 20 Aug 2019 19:47:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=b4UDC2Ay405GxmBEnT1wyybuUu0XVgCZoKw4OWGvIOU=; b=NC9DNmuki4mD9E0N8TQ/9gLoPh99H0+JTgJaeul1ECNaApsf6fYp8dsx6lEt4/9Fok 8hkQa+xN5MHHlmYtnsTKHPEeXQK6gocYB/l1im7MwYcnCHD4Hyvq6vaOrRBeveuUrEtd 5Uf7C47kfU9X0TUiyMFUjs5HWGYlwcE9DypmG/OKbOt7oVPhe1JK0marfQhktDo4EZoq Z6BEZA+6iw+BX4fL8lz1/iB0dm/omAk+A1+oIZwnz7Y3wKKh15bUad9sNAFyuR6r0pvp nlvFsu+MExK2eSNx5MEcbzE7PVf8HbVqCwEIW9kITEnOtzuU8v/U7xcCByLoI/s2WTh4 W2uw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=b4UDC2Ay405GxmBEnT1wyybuUu0XVgCZoKw4OWGvIOU=; b=KHO90t4Biymb9cU6/y0cBlZhuZJem/TuCovrnT26/ECeOc7MFJyYsUuMdxkmvA67FY aXEUfgEUrp+GGjhN+p9NkjmySxHU0BPtiKDCfaFHmfkMUodMltzKzmPZGNvQ/8ZowVS0 HEXllox5BExDoc+kvfvUpU3prr28Lx/cWjLFy10vZ6APaQCIGtarBSwWv+UbTFsHgcU5 9DBIWmCTR2IfHYHCPnSg/k9TDCmVlqcsFKfpOLnOj2cMRawi1I2JhW4b1nJEreLd4IQq GcFrPyb6wyBwypc3Mb2UDCSW/re7bz/0NW/hx9XXdrX/g98cIzEFkz2DkIe9Aiy2SucG KDGQ== X-Gm-Message-State: APjAAAUyLiRcWKwheNNuviiB2yUAZYcui//Kd1xX+LQT1KAsU2UgKPib DEbucIBqbQKNrFYC5OOd0dsKeBwc X-Google-Smtp-Source: APXvYqz2iICQklo2b4GmWZGVjPoSxPAy6cvQcaWGBDqjatbxhLQr0sVskqQZaqaYTsbDFcG6kgh+3w== X-Received: by 2002:a02:c00c:: with SMTP id y12mr7646179jai.65.1566355664396; Tue, 20 Aug 2019 19:47:44 -0700 (PDT) Original-Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.gmail.com with ESMTPSA id v3sm16156981iom.53.2019.08.20.19.47.43 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 20 Aug 2019 19:47:43 -0700 (PDT) In-Reply-To: <9755920B-2303-4819-BD8A-CB238F29E1BA@apiture.com> (David Biesack's message of "Tue, 20 Aug 2019 15:07:49 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:165467 Archived-At: --=-=-= Content-Type: text/plain David Biesack writes: > Attached is a backtrace. > Let me know if there is other advice I can add to help track this down. The attachment seems to be missing. But anyway, I have a simple reproducer now, so we don't need any more backtraces. I found setting uniquify-after-kill-buffer-p to nil was needed to reproduce this, do you have that setting in your init? --=-=-= Content-Type: text/plain Content-Disposition: attachment; filename=repro.el Content-Description: bug reproducer (defconst bug-36877-dup-table (make-hash-table :test 'eq)) (defun bug-36877-debug-fix-list-dups (fix-list) (clrhash bug-36877-dup-table) (dolist (item fix-list) (let ((buf (uniquify-item-buffer item))) (if (gethash buf bug-36877-dup-table) (progn (debug nil "Adding duplicate to uniquify list!" item) ;; Just once. (advice-remove 'uniquify-rationalize #'bug-36877-debug-fix-list-dups)) (puthash buf item bug-36877-dup-table))))) (advice-add 'uniquify-rationalize :before #'bug-36877-debug-fix-list-dups) (setq uniquify-after-kill-buffer-p nil) (defconst bug-36877-topdir (file-name-directory (or load-file-name buffer-file-name))) (dolist (dir '("a" "b" "c")) (setq dir (expand-file-name dir bug-36877-topdir)) (make-directory dir t) (find-file (expand-file-name "foo" dir))) (kill-buffer (get-file-buffer (expand-file-name "c/foo" bug-36877-topdir))) (find-file (expand-file-name "c/foo" bug-36877-topdir)) --=-=-=--