From: Noam Postavsky <npostavs@gmail.com>
To: David Biesack <David.Biesack@Apiture.com>
Cc: "36877@debbugs.gnu.org" <36877@debbugs.gnu.org>
Subject: bug#36877: 25.3; uniquify renaway uniquify-managed list
Date: Sun, 18 Aug 2019 13:51:08 -0400 [thread overview]
Message-ID: <87a7c6pdkj.fsf@gmail.com> (raw)
In-Reply-To: <85d0h6l50y.fsf@gmail.com> (Noam Postavsky's message of "Thu, 15 Aug 2019 13:20:13 -0400")
[-- Attachment #1: Type: text/plain, Size: 1864 bytes --]
Noam Postavsky <npostavs@gmail.com> writes:
> Looking at the fix-list in the backtrace, we have:
>
> [cl-struct-uniquify-item "index.html" "/Users/david.biesack/dev/developer.apiture.com/_site/docs/apis/workflow/v0.13.0" #<buffer index.html> nil]
> { ;; repeated 5 times...
> [cl-struct-uniquify-item "index.html" "/Users/david.biesack/dev/developer.apiture.com/_site/docs/apis/sample" #<buffer index.html<docs/apis/sample>> "index.html<docs/apis/sample>"]
> [cl-struct-uniquify-item "index.html" "/Users/david.biesack/dev/developer.apiture.com/_site/doc/apis/sample" #<buffer index.html<doc/apis/sample>> "index.html<doc/apis/sample>"]
> [cl-struct-uniquify-item "index.html" "/Users/david.biesack/dev/developer.apiture.com/_site/docs/apis/sample/sample" #<buffer index.html<sample/sample>> "index.html<sample/sample>"]
> [cl-struct-uniquify-item "index.html" "/Users/david.biesack/dev/developer.apiture.com" #<buffer index.html<developer.apiture.com>> "index.html<developer.apiture.com>"]
> [cl-struct-uniquify-item "index.html" "/Users/david.biesack/dev/developer.apiture.com/_site/docs/concepts" #<buffer index.html<concepts>> "index.html<concepts>"]
> }
I managed to hit this myself. I'm not exactly sure what triggered it.
My problematic fix-list looks like this:
(#s(uniquify-item :base "term-tests.el" :dirname "/home/npostavs/src/emacs/master/test/lisp" :buffer #<buffer term-tests.el> :proposed nil)
#3=#s(uniquify-item :base #1="term-tests.el" :dirname "/home/npostavs/src/emacs/emacs-master/test/lisp" :buffer #<buffer emacs-master/term-tests.el> :proposed #1#)
#4=#s(uniquify-item :base #2="term-tests.el" :dirname "/home/npostavs/src/emacs/emacs-26/test/lisp" :buffer #<buffer emacs-26/term-tests.el> :proposed #2#)
#3# #4#)
I suspect the problem is happening earlier, so we'll need some other
test to catch it.
[-- Attachment #2: backtrace --]
[-- Type: text/plain, Size: 4472 bytes --]
Debugger entered: ("Adding duplicate to uniquify list!" #s(uniquify-item :base #1="term-tests.el" :dirname "/home/npostavs/src/emacs/emacs-master/test/lisp" :buffer #<buffer emacs-master/term-tests.el> :proposed #1#))
(progn (debug nil "Adding duplicate to uniquify list!" item) (advice-remove (quote uniquify-rationalize) (function bug-36877-debug-fix-list-dups)))
(if (gethash buf bug-36877-dup-table) (progn (debug nil "Adding duplicate to uniquify list!" item) (advice-remove (quote uniquify-rationalize) (function bug-36877-debug-fix-list-dups))) (puthash buf item bug-36877-dup-table))
(let ((buf (progn (or (and (memq (type-of item) cl-struct-uniquify-item-tags) t) (signal (quote wrong-type-argument) (list (quote uniquify-item) item))) (aref item 3)))) (if (gethash buf bug-36877-dup-table) (progn (debug nil "Adding duplicate to uniquify list!" item) (advice-remove (quote uniquify-rationalize) (function bug-36877-debug-fix-list-dups))) (puthash buf item bug-36877-dup-table)))
(while --dolist-tail-- (setq item (car --dolist-tail--)) (let ((buf (progn (or (and (memq ... cl-struct-uniquify-item-tags) t) (signal (quote wrong-type-argument) (list ... item))) (aref item 3)))) (if (gethash buf bug-36877-dup-table) (progn (debug nil "Adding duplicate to uniquify list!" item) (advice-remove (quote uniquify-rationalize) (function bug-36877-debug-fix-list-dups))) (puthash buf item bug-36877-dup-table))) (setq --dolist-tail-- (cdr --dolist-tail--)))
(let ((--dolist-tail-- fix-list) item) (while --dolist-tail-- (setq item (car --dolist-tail--)) (let ((buf (progn (or (and ... t) (signal ... ...)) (aref item 3)))) (if (gethash buf bug-36877-dup-table) (progn (debug nil "Adding duplicate to uniquify list!" item) (advice-remove (quote uniquify-rationalize) (function bug-36877-debug-fix-list-dups))) (puthash buf item bug-36877-dup-table))) (setq --dolist-tail-- (cdr --dolist-tail--))))
bug-36877-debug-fix-list-dups((#s(uniquify-item :base "term-tests.el" :dirname "/home/npostavs/src/emacs/master/test/lisp" :buffer #<buffer term-tests.el> :proposed nil) #3=#s(uniquify-item :base #1="term-tests.el" :dirname "/home/npostavs/src/emacs/emacs-master/test/lisp" :buffer #<buffer emacs-master/term-tests.el> :proposed #1#) #4=#s(uniquify-item :base #2="term-tests.el" :dirname "/home/npostavs/src/emacs/emacs-26/test/lisp" :buffer #<buffer emacs-26/term-tests.el> :proposed #2#) #3# #4#))
apply(bug-36877-debug-fix-list-dups (#s(uniquify-item :base "term-tests.el" :dirname "/home/npostavs/src/emacs/master/test/lisp" :buffer #<buffer term-tests.el> :proposed nil) #3=#s(uniquify-item :base #1="term-tests.el" :dirname "/home/npostavs/src/emacs/emacs-master/test/lisp" :buffer #<buffer emacs-master/term-tests.el> :proposed #1#) #4=#s(uniquify-item :base #2="term-tests.el" :dirname "/home/npostavs/src/emacs/emacs-26/test/lisp" :buffer #<buffer emacs-26/term-tests.el> :proposed #2#) #3# #4#))
uniquify-rationalize((#s(uniquify-item :base "term-tests.el" :dirname "/home/npostavs/src/emacs/master/test/lisp" :buffer #<buffer term-tests.el> :proposed nil) #3=#s(uniquify-item :base #1="term-tests.el" :dirname "/home/npostavs/src/emacs/emacs-master/test/lisp" :buffer #<buffer emacs-master/term-tests.el> :proposed #1#) #4=#s(uniquify-item :base #2="term-tests.el" :dirname "/home/npostavs/src/emacs/emacs-26/test/lisp" :buffer #<buffer emacs-26/term-tests.el> :proposed #2#) #3# #4#))
uniquify-rationalize-file-buffer-names("term-tests.el" "/home/npostavs/src/emacs/master/test/lisp/" #<buffer term-tests.el>)
uniquify--create-file-buffer-advice(#f(compiled-function (arg1) #<bytecode 0x22f393>) "~/src/emacs/master/test/lisp/term-tests.el")
apply(uniquify--create-file-buffer-advice #f(compiled-function (arg1) #<bytecode 0x22f393>) "~/src/emacs/master/test/lisp/term-tests.el")
create-file-buffer("~/src/emacs/master/test/lisp/term-tests.el")
find-file-noselect("/home/npostavs/src/emacs/master/test/lisp/term-tests.el" nil nil)
ido-file-internal(other-window find-file-other-window)
ido-find-file-other-window()
funcall-interactively(ido-find-file-other-window)
#<subr call-interactively>(ido-find-file-other-window nil nil)
ad-Advice-call-interactively(#<subr call-interactively> ido-find-file-other-window nil nil)
apply(ad-Advice-call-interactively #<subr call-interactively> (ido-find-file-other-window nil nil))
call-interactively(ido-find-file-other-window nil nil)
command-execute(ido-find-file-other-window)
next prev parent reply other threads:[~2019-08-18 17:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-31 16:04 bug#36877: 25.3; uniquify renaway uniquify-managed list David Biesack
2019-08-09 0:47 ` Noam Postavsky
2019-08-09 15:58 ` David Biesack
2019-08-15 17:20 ` Noam Postavsky
2019-08-16 14:36 ` David Biesack
2019-08-18 17:51 ` Noam Postavsky [this message]
2019-08-20 15:07 ` David Biesack
2019-08-21 2:47 ` Noam Postavsky
2019-08-21 12:47 ` David Biesack
2020-11-25 17:19 ` David Biesack
2021-05-12 15:37 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a7c6pdkj.fsf@gmail.com \
--to=npostavs@gmail.com \
--cc=36877@debbugs.gnu.org \
--cc=David.Biesack@Apiture.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).