From: Lars Ingebrigtsen <larsi@gnus.org>
To: Richard Stallman <rms@gnu.org>
Cc: 43961@debbugs.gnu.org, Boruch Baum <boruch_baum@gmx.com>
Subject: bug#43961: read carefully: dired-file-name-at-point vs dired-filename-at-point
Date: Wed, 14 Oct 2020 06:58:07 +0200 [thread overview]
Message-ID: <87k0vtz9nk.fsf@gnus.org> (raw)
In-Reply-To: <E1kSYdf-0001Ed-OE@fencepost.gnu.org> (Richard Stallman's message of "Wed, 14 Oct 2020 00:43:47 -0400")
Richard Stallman <rms@gnu.org> writes:
> > As I think I mentioned, once (if) the patch is approved, a next step is
> > to grep the emacs core code-base and replace the function names.
>
> I just did that. dired-filename-at-point is not used anywhere except
> dired-x.el.
>
> I expect that none of the published Lisp packages uses
> dired-filename-at-point.
And I looked at the code now, and it seems the bug reporter
misunderstood the point of the function: It's used to guess a file name
in non-dired buffers, while dired-file-name-at-point is a dired function
that just returns the file name in a dired buffer.
So they're totally unrelated functions, but dired-filename-at-point has
an unfortunate name. I've now renamed it (but kept
dired-filename-at-point as an obsolete alias).
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2020-10-14 4:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-12 14:26 bug#43961: read carefully: dired-file-name-at-point vs dired-filename-at-point Boruch Baum
2020-10-13 3:49 ` Richard Stallman
2020-10-13 4:08 ` Boruch Baum
2020-10-13 4:54 ` Lars Ingebrigtsen
2020-10-13 10:25 ` Boruch Baum
2020-10-13 10:58 ` Arthur Miller
2020-10-13 11:27 ` Boruch Baum
2020-10-14 3:45 ` Lars Ingebrigtsen
2020-10-14 4:19 ` Boruch Baum
2020-10-14 4:43 ` Richard Stallman
2020-10-14 4:58 ` Lars Ingebrigtsen [this message]
2020-10-15 3:57 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k0vtz9nk.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=43961@debbugs.gnu.org \
--cc=boruch_baum@gmx.com \
--cc=rms@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).