From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#43961: read carefully: dired-file-name-at-point vs dired-filename-at-point Date: Wed, 14 Oct 2020 06:58:07 +0200 Message-ID: <87k0vtz9nk.fsf@gnus.org> References: <20201012142522.m24zmrzzuiiao4ck@E15-2016.optimum.net> <20201013040807.xk2q54jnquthda7y@E15-2016.optimum.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17017"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 43961@debbugs.gnu.org, Boruch Baum To: Richard Stallman Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Oct 14 06:59:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kSYsY-0004Gf-Dd for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 14 Oct 2020 06:59:10 +0200 Original-Received: from localhost ([::1]:33292 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kSYsX-00084g-1j for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 14 Oct 2020 00:59:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55364) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kSYsQ-00084U-Fg for bug-gnu-emacs@gnu.org; Wed, 14 Oct 2020 00:59:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38179) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kSYsQ-0003pw-6Q for bug-gnu-emacs@gnu.org; Wed, 14 Oct 2020 00:59:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kSYsQ-0004dE-5q for bug-gnu-emacs@gnu.org; Wed, 14 Oct 2020 00:59:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 14 Oct 2020 04:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43961 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 43961-submit@debbugs.gnu.org id=B43961.160265149917755 (code B ref 43961); Wed, 14 Oct 2020 04:59:02 +0000 Original-Received: (at 43961) by debbugs.gnu.org; 14 Oct 2020 04:58:19 +0000 Original-Received: from localhost ([127.0.0.1]:49725 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kSYrj-0004cH-6R for submit@debbugs.gnu.org; Wed, 14 Oct 2020 00:58:19 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:54602) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kSYrh-0004c5-VP for 43961@debbugs.gnu.org; Wed, 14 Oct 2020 00:58:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=n5jiJ/UxA8LG4U/xD89WnwKoAVKKVC6+iqcC/5SFu4g=; b=aZGcyRl4aqJZqPiF/BhH2aYf76 9d8BsPHAdIeuhvQ7gaDu0PbihRaaGXcE7nvPbaMyqraGcAUeUt4EnTsXjjDTVBkRVJ7smehqD5kWz SA0nnrSZGZCQTxSi1vCv9DRkT6kf8miP5r0T0qYdnTcCJQ4PiVeI6681E69aRzEfv1dw=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kSYrY-0005qy-Mr; Wed, 14 Oct 2020 06:58:11 +0200 X-Now-Playing: The Remote Viewer's _You're Going to Love Our Defeatist Attitude_: "The Gambler and the Captain" In-Reply-To: (Richard Stallman's message of "Wed, 14 Oct 2020 00:43:47 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:190474 Archived-At: Richard Stallman writes: > > As I think I mentioned, once (if) the patch is approved, a next step is > > to grep the emacs core code-base and replace the function names. > > I just did that. dired-filename-at-point is not used anywhere except > dired-x.el. > > I expect that none of the published Lisp packages uses > dired-filename-at-point. And I looked at the code now, and it seems the bug reporter misunderstood the point of the function: It's used to guess a file name in non-dired buffers, while dired-file-name-at-point is a dired function that just returns the file name in a dired buffer. So they're totally unrelated functions, but dired-filename-at-point has an unfortunate name. I've now renamed it (but kept dired-filename-at-point as an obsolete alias). -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no