From: Lars Ingebrigtsen <larsi@gnus.org>
To: Boruch Baum <boruch_baum@gmx.com>
Cc: 43961@debbugs.gnu.org, Richard Stallman <rms@gnu.org>
Subject: bug#43961: read carefully: dired-file-name-at-point vs dired-filename-at-point
Date: Wed, 14 Oct 2020 05:45:51 +0200 [thread overview]
Message-ID: <87blh531xs.fsf@gnus.org> (raw)
In-Reply-To: <20201013102511.5nuu3p3dcyr6poft@E15-2016.optimum.net> (Boruch Baum's message of "Tue, 13 Oct 2020 06:25:12 -0400")
Boruch Baum <boruch_baum@gmx.com> writes:
>> Why not just have one call the other, and wrap the results in
>> abbreviate-file-name?
>
> You could, but you wouldn't be saving anything since the inner function
> would still need to perform the expansion, so for the abbreviated
> function you end up in effect with an inefficient (abbrev (expand file))
> instead of a choice between (abbrev file) or (expand file).
It's not about code efficiency -- whether this function is efficient or
not doesn't make any difference, since we'd deprecate it, and change the
callers.
> Also, much of the change ends up being defaliases, docstrings and
> deprecation notices, so its more clearly presented without nesting
> functions.
Sorry, I don't think this is a good change. Renaming these functions
just because we have two almost identical ones (when we should just
remove one of them) doesn't make much sense.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2020-10-14 3:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-12 14:26 bug#43961: read carefully: dired-file-name-at-point vs dired-filename-at-point Boruch Baum
2020-10-13 3:49 ` Richard Stallman
2020-10-13 4:08 ` Boruch Baum
2020-10-13 4:54 ` Lars Ingebrigtsen
2020-10-13 10:25 ` Boruch Baum
2020-10-13 10:58 ` Arthur Miller
2020-10-13 11:27 ` Boruch Baum
2020-10-14 3:45 ` Lars Ingebrigtsen [this message]
2020-10-14 4:19 ` Boruch Baum
2020-10-14 4:43 ` Richard Stallman
2020-10-14 4:58 ` Lars Ingebrigtsen
2020-10-15 3:57 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87blh531xs.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=43961@debbugs.gnu.org \
--cc=boruch_baum@gmx.com \
--cc=rms@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).