unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: "J.P." <jp@neverwas.me>
To: Eli Zaretskii <eliz@gnu.org>
Cc: stefankangas@gmail.com, 60730@debbugs.gnu.org
Subject: bug#60730: 29.0.60; Free variable with :buffer keyword in ert-with-temp-file
Date: Sat, 28 Jan 2023 07:56:22 -0800	[thread overview]
Message-ID: <87k016y7o9.fsf@neverwas.me> (raw)
In-Reply-To: <83edreaehg.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 28 Jan 2023 17:03:07 +0200")

Eli Zaretskii <eliz@gnu.org> writes:

>> Not sure if that's the right call, though. If this keyword is already
>> seeing action in the wild, perhaps it's worth ensuring that its argument
>> arrives unquoted? Or maybe another type check (to accompany the one for
>> `name') would do?
>
> Can you show the results of macro-expansion both when coding has a
> value and when it is nil (and then coding-system-for-write is nil or
> has a non-nil value)?

`coding-system-for-write' nil, keyword nil

  (ert-with-temp-file myfile :coding nil)
  (let* ((coding-system-for-write nil) ...)

  ;; keyword absent

  (ert-with-temp-file myfile)
  (let* ((coding-system-for-write nil) ...)

`coding-system-for-write' nil, keyword non-nil

  (ert-with-temp-file myfile :coding utf-8)
  (let* ((coding-system-for-write utf-8) ...)

  ;; keyword quoted

  (ert-with-temp-file myfile :coding 'utf-8)
  (let* ((coding-system-for-write 'utf-8) ...)

`coding-system-for-write' non-nil, keyword nil

  (setq coding-system-for-write 'utf-8)

  (ert-with-temp-file myfile :coding nil)
  (let* ((coding-system-for-write utf-8) ...)

  ;; keyword absent

  (ert-with-temp-file myfile myfile)
  (let* ((coding-system-for-write utf-8) ...)

`coding-system-for-write' non-nil, keyword non-nil

  (setq coding-system-for-write 'utf-8)

  (ert-with-temp-file myfile :coding raw-text)
  (let* ((coding-system-for-write raw-text) ...)

  ;; keyword quoted

  (ert-with-temp-file myfile :coding 'raw-text)
  (let* ((coding-system-for-write 'raw-text) ...)





  reply	other threads:[~2023-01-28 15:56 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-11 13:50 bug#60730: 29.0.60; Free variable with :buffer keyword in ert-with-temp-file J.P.
2023-01-13  1:56 ` Stefan Kangas
2023-01-28 14:13   ` J.P.
2023-01-28 15:03     ` Eli Zaretskii
2023-01-28 15:56       ` J.P. [this message]
2023-01-28 16:13         ` Eli Zaretskii
2023-01-29  2:00           ` J.P.
2023-01-29  4:35             ` J.P.
2023-01-29  6:38               ` Eli Zaretskii
2023-01-29 14:08                 ` J.P.
2023-01-29 15:10                   ` Eli Zaretskii
2023-01-29 16:18                     ` J.P.
2023-01-29  6:28             ` Eli Zaretskii
2023-01-29  9:56               ` Andreas Schwab
2023-01-29 10:29                 ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k016y7o9.fsf@neverwas.me \
    --to=jp@neverwas.me \
    --cc=60730@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=stefankangas@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).