From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "J.P." Newsgroups: gmane.emacs.bugs Subject: bug#60730: 29.0.60; Free variable with :buffer keyword in ert-with-temp-file Date: Sat, 28 Jan 2023 07:56:22 -0800 Message-ID: <87k016y7o9.fsf@neverwas.me> References: <87o7r5ji3q.fsf@neverwas.me> <874jsazqzz.fsf@neverwas.me> <83edreaehg.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9314"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: stefankangas@gmail.com, 60730@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jan 28 16:57:27 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pLna1-0002AL-6o for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 28 Jan 2023 16:57:25 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pLnZh-0006kE-N8; Sat, 28 Jan 2023 10:57:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pLnZe-0006jK-K2 for bug-gnu-emacs@gnu.org; Sat, 28 Jan 2023 10:57:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pLnZe-0001sE-62 for bug-gnu-emacs@gnu.org; Sat, 28 Jan 2023 10:57:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pLnZe-00038H-31 for bug-gnu-emacs@gnu.org; Sat, 28 Jan 2023 10:57:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: "J.P." Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 28 Jan 2023 15:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60730 X-GNU-PR-Package: emacs Original-Received: via spool by 60730-submit@debbugs.gnu.org id=B60730.167492139611980 (code B ref 60730); Sat, 28 Jan 2023 15:57:02 +0000 Original-Received: (at 60730) by debbugs.gnu.org; 28 Jan 2023 15:56:36 +0000 Original-Received: from localhost ([127.0.0.1]:41400 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pLnZD-00037A-R3 for submit@debbugs.gnu.org; Sat, 28 Jan 2023 10:56:36 -0500 Original-Received: from mail-108-mta120.mxroute.com ([136.175.108.120]:41715) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pLnZA-00036w-MF for 60730@debbugs.gnu.org; Sat, 28 Jan 2023 10:56:33 -0500 Original-Received: from mail-111-mta2.mxroute.com ([136.175.111.2] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta120.mxroute.com (ZoneMTA) with ESMTPSA id 185f9181e99000011e.001 for <60730@debbugs.gnu.org> (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256); Sat, 28 Jan 2023 15:56:25 +0000 X-Zone-Loop: e4f66105c828d9e2857790ebaf229e35a01f7dc36f83 X-Originating-IP: [136.175.111.2] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=neverwas.me ; s=x; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=4uH2Cth+DTNgEA8Lp/uwj+5k/QiV2upCCMsl1RLaSuY=; b=Epv3PaL3iQfX0tB0fq7n7xQ0T9 BsaCRG6nDTcOXOfoA0UxowHv6cOnzBTIypCKNPjCgcMucYAYn0iqU96qpOp7k5R1H4yrdO7ZCXw4K cyZK8jjFZUpflCI6ZeUFZN64Wc92AmbcyXID9Sp2v3dmAO7g+65loUN3D0ZOhK4nuJL+tnjDymbvV AQLPFGrDXFticOfdSKDFWl+ofle4eW4zI3Q+7yS1FscIzrRchPmti7MDActgfg23OU5v067Cob+FK 45QKuDIdE2hPZWCZi8wawh9Sz9efdU+xXPC8XS7WotYeHYe8f9z2KRZVsE+UK1oiZ4/tlkn0/Fze3 1LIxG8Ow==; In-Reply-To: <83edreaehg.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 28 Jan 2023 17:03:07 +0200") X-Authenticated-Id: masked@neverwas.me X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:254306 Archived-At: Eli Zaretskii writes: >> Not sure if that's the right call, though. If this keyword is already >> seeing action in the wild, perhaps it's worth ensuring that its argument >> arrives unquoted? Or maybe another type check (to accompany the one for >> `name') would do? > > Can you show the results of macro-expansion both when coding has a > value and when it is nil (and then coding-system-for-write is nil or > has a non-nil value)? `coding-system-for-write' nil, keyword nil (ert-with-temp-file myfile :coding nil) (let* ((coding-system-for-write nil) ...) ;; keyword absent (ert-with-temp-file myfile) (let* ((coding-system-for-write nil) ...) `coding-system-for-write' nil, keyword non-nil (ert-with-temp-file myfile :coding utf-8) (let* ((coding-system-for-write utf-8) ...) ;; keyword quoted (ert-with-temp-file myfile :coding 'utf-8) (let* ((coding-system-for-write 'utf-8) ...) `coding-system-for-write' non-nil, keyword nil (setq coding-system-for-write 'utf-8) (ert-with-temp-file myfile :coding nil) (let* ((coding-system-for-write utf-8) ...) ;; keyword absent (ert-with-temp-file myfile myfile) (let* ((coding-system-for-write utf-8) ...) `coding-system-for-write' non-nil, keyword non-nil (setq coding-system-for-write 'utf-8) (ert-with-temp-file myfile :coding raw-text) (let* ((coding-system-for-write raw-text) ...) ;; keyword quoted (ert-with-temp-file myfile :coding 'raw-text) (let* ((coding-system-for-write 'raw-text) ...)