unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: "J.P." <jp@neverwas.me>
Cc: stefankangas@gmail.com, 60730@debbugs.gnu.org
Subject: bug#60730: 29.0.60; Free variable with :buffer keyword in ert-with-temp-file
Date: Sun, 29 Jan 2023 08:38:22 +0200	[thread overview]
Message-ID: <83k015976p.fsf@gnu.org> (raw)
In-Reply-To: <875ycqt0t8.fsf@neverwas.me> (jp@neverwas.me)

> From: "J.P." <jp@neverwas.me>
> Cc: 60730@debbugs.gnu.org,  stefankangas@gmail.com
> Date: Sat, 28 Jan 2023 20:35:47 -0800
> 
> "J.P." <jp@neverwas.me> writes:
> 
> > Eli Zaretskii <eliz@gnu.org> writes:
> >
> >> Thanks, but I'm not sure I follow: coding-system's name should always
> >> be quoted, as it's a symbol.  So why things like the below:
> >>
> >>    (ert-with-temp-file myfile :coding raw-text)
> >>
> >> are relevant?  AFAIU, they are a mistake: raw-text should be quoted,
> >> as in 'raw-text.
> 
> If, as you say, an argument to `:coding' should only ever be quoted, e.g.,
> 
>   :coding 'raw-text
> 
> then `coding' will end up quoted as well, so something like this might
> be enough:

If you say so.  The `', stuff looks strange to me, but the backticks
in Emacs Lisp have always been black magic.

What we need to ensure that both

  :coding 'raw-text

and

  :coding some-coding-variable

do work as expected, including when coding-system-for-write's value is
a non-nil symbol of a coding-system.

Thanks.





  reply	other threads:[~2023-01-29  6:38 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-11 13:50 bug#60730: 29.0.60; Free variable with :buffer keyword in ert-with-temp-file J.P.
2023-01-13  1:56 ` Stefan Kangas
2023-01-28 14:13   ` J.P.
2023-01-28 15:03     ` Eli Zaretskii
2023-01-28 15:56       ` J.P.
2023-01-28 16:13         ` Eli Zaretskii
2023-01-29  2:00           ` J.P.
2023-01-29  4:35             ` J.P.
2023-01-29  6:38               ` Eli Zaretskii [this message]
2023-01-29 14:08                 ` J.P.
2023-01-29 15:10                   ` Eli Zaretskii
2023-01-29 16:18                     ` J.P.
2023-01-29  6:28             ` Eli Zaretskii
2023-01-29  9:56               ` Andreas Schwab
2023-01-29 10:29                 ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83k015976p.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=60730@debbugs.gnu.org \
    --cc=jp@neverwas.me \
    --cc=stefankangas@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).