From: "J.P." <jp@neverwas.me>
To: Eli Zaretskii <eliz@gnu.org>
Cc: stefankangas@gmail.com, 60730@debbugs.gnu.org
Subject: bug#60730: 29.0.60; Free variable with :buffer keyword in ert-with-temp-file
Date: Sat, 28 Jan 2023 18:00:40 -0800 [thread overview]
Message-ID: <874jsaumk7.fsf@neverwas.me> (raw)
In-Reply-To: <838rhmab8f.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 28 Jan 2023 18:13:20 +0200")
[-- Attachment #1: Type: text/plain, Size: 1047 bytes --]
Eli Zaretskii <eliz@gnu.org> writes:
> Thanks, but I'm not sure I follow: coding-system's name should always
> be quoted, as it's a symbol. So why things like the below:
>
> (ert-with-temp-file myfile :coding raw-text)
>
> are relevant? AFAIU, they are a mistake: raw-text should be quoted,
> as in 'raw-text.
I shouldn't have included the keyword argument; it only muddies the
waters here. The correctness of the output, what we expect to see in the
expanded form, is of primary concern.
> Is the problem that a coding-system symbol is not quoted?
When the value of `coding-system-for-write' is non-nil, only quoting it
twice survives expansion:
(setq coding-system-for-write ''raw-text)
(ert-with-temp-file myfile)
-> (let* ((coding-system-for-write 'raw-text) ...)
Otherwise, we get a free variable:
(setq coding-system-for-write 'raw-text)
(ert-with-temp-file myfile)
-> (let* ((coding-system-for-write raw-text) ...)
BTW, I'm not setting `coding-system-for-write' myself. That's being done
by the diagnostic tool.
[-- Attachment #2: Error --]
[-- Type: image/png, Size: 36375 bytes --]
next prev parent reply other threads:[~2023-01-29 2:00 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-11 13:50 bug#60730: 29.0.60; Free variable with :buffer keyword in ert-with-temp-file J.P.
2023-01-13 1:56 ` Stefan Kangas
2023-01-28 14:13 ` J.P.
2023-01-28 15:03 ` Eli Zaretskii
2023-01-28 15:56 ` J.P.
2023-01-28 16:13 ` Eli Zaretskii
2023-01-29 2:00 ` J.P. [this message]
2023-01-29 4:35 ` J.P.
2023-01-29 6:38 ` Eli Zaretskii
2023-01-29 14:08 ` J.P.
2023-01-29 15:10 ` Eli Zaretskii
2023-01-29 16:18 ` J.P.
2023-01-29 6:28 ` Eli Zaretskii
2023-01-29 9:56 ` Andreas Schwab
2023-01-29 10:29 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874jsaumk7.fsf@neverwas.me \
--to=jp@neverwas.me \
--cc=60730@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=stefankangas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).