From: Noam Postavsky <npostavs@gmail.com>
To: Christian Ohler <ohler@gnu.org>
Cc: 11218@debbugs.gnu.org, Stefan Monnier <monnier@iro.umontreal.ca>
Subject: bug#11218: with-demoted-errors use of condition-case-unless-debug; ert
Date: Tue, 14 Aug 2018 21:10:07 -0400 [thread overview]
Message-ID: <87in4cxwnk.fsf@gmail.com> (raw)
In-Reply-To: <4F8DE112.5010106@gnu.org> (Christian Ohler's message of "Tue, 17 Apr 2012 14:30:58 -0700")
Christian Ohler <ohler@gnu.org> writes:
> On 4/13/12 6:44 AM, Stefan Monnier wrote:
>>>>> If you replace with-demoted-errors with ignore-errors, the test passes.
>>>> Looks like a bug in ERT.
>>> I don't know if it's a "bug" per se...
>>> ert--run-test-internal binds debug-on-error to t, and redefines the
>>> debugger to ert--run-test-debugger. As the doc of that function says:
>>
>> I wonder why ERT doesn't just use condition-case to catch and record
>> the errors.
>
> Two reasons that I remember off the top of my head: Recording
> backtraces, and recording additional information provided with
> `ert-info'. Using condition-case would let ERT regain control only
> after the stack is unwound, at which point that information is gone.
I just posted a patch which changes ERT to use `signal-hook-function' to
record backtraces instead. It fixes the case in the OP.
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=30745#20
Note that condition-case also needs an enhancement to be able to catch
any signal (Bug#24618), so that might be a third reason why ERT didn't
go this route originally.
next prev parent reply other threads:[~2018-08-15 1:10 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-11 3:37 bug#11218: with-demoted-errors use of condition-case-unless-debug; ert Glenn Morris
2012-04-11 12:03 ` Lars Magne Ingebrigtsen
2012-04-11 16:16 ` Glenn Morris
2012-04-11 16:28 ` Glenn Morris
2012-04-11 17:57 ` Stefan Monnier
2012-04-11 13:02 ` Stefan Monnier
2012-04-13 0:15 ` Glenn Morris
2012-04-13 13:44 ` Stefan Monnier
2012-04-17 21:30 ` Christian Ohler
2012-04-19 7:46 ` Stefan Monnier
2012-04-20 3:09 ` Christian Ohler
2012-04-20 12:13 ` Stefan Monnier
2012-04-20 21:02 ` Christian Ohler
2012-04-21 2:34 ` Stefan Monnier
2012-04-23 13:26 ` Lennart Borgman
2012-04-24 2:04 ` Stefan Monnier
2012-05-06 18:45 ` Christian Ohler
2012-05-07 1:12 ` Stefan Monnier
2012-05-21 3:03 ` Christian Ohler
2018-08-15 1:10 ` Noam Postavsky [this message]
2020-11-24 17:34 ` Philipp Stephani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87in4cxwnk.fsf@gmail.com \
--to=npostavs@gmail.com \
--cc=11218@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=ohler@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).