From: Christian Ohler <ohler@gnu.org>
To: Stefan Monnier <monnier@IRO.UMontreal.CA>
Cc: 11218@debbugs.gnu.org
Subject: bug#11218: with-demoted-errors use of condition-case-unless-debug; ert
Date: Fri, 20 Apr 2012 14:02:39 -0700 [thread overview]
Message-ID: <4F91CEEF.20305@gnu.org> (raw)
In-Reply-To: <jwvzka61udx.fsf-monnier+emacs@gnu.org>
On 4/20/12 5:13 AM, Stefan Monnier wrote:
>>> So the next question is: why does ERT record a backtrace and that extra
>>> information provided by ert-info?
>> To be able to show them to the user, together with the test failure. If you
>> have one or more failing tests, it's much more useful to see the error
>> messages and backtraces rather than just the error messages.
>
> I don't see the point of showing that info when running the tests.
> If the user wants that info, he should be able to easily say "run this
> test with debug-on-error" so he doesn't only get a backtrace but also
> gets put in the debugger where he can inspect the state.
ERT's keyboard shortcut for that is "d". But it's not a good solution if:
* the test is nondeterministic (maybe due to subprocess interaction),
* the test takes a long time to run,
* you have multiple failing tests and want to quickly compare if they
are crashing in the same place,
* ERT is running in batch mode (e.g. make check).
It's better to collect as much data as reasonably possible when the
error first occurs.
>> (ert-deftest foo ()
>> (with-demoted-errors (error "a"))
>> (error "b"))
>
>> would normally fail with "b", but if we enable debugging to track down why,
>> it will fail with "a" instead (with no way to continue execution to get to
>> the error we are interested in).
>
> No: you'll be put in the debugger for the error "a" but if you hit `c'
> it will continue and re-enter the debugger for error "b".
My Emacs is a few months old, but that doesn't work for me. Has it
changed recently?
I'm using
(defun foo ()
(with-demoted-errors (error "a"))
(error "b"))
and typing
C-u <escape> C-x <escape> : ( f o o ) <return> c c
and all I find in *Messages* is
error: "a"
Continue...
edebug-signal: a
No mention of "b".
If `debug-on-error' is t, `with-demoted-errors' becomes essentially
equivalent to `progn', and (error "b") can ever be reached in
(defun foo ()
(progn (error "a"))
(error "b"))
since `error' never returns (and I think that's an important guarantee
that the debugger shouldn't violate, at least not without confirmation).
Christian.
next prev parent reply other threads:[~2012-04-20 21:02 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-11 3:37 bug#11218: with-demoted-errors use of condition-case-unless-debug; ert Glenn Morris
2012-04-11 12:03 ` Lars Magne Ingebrigtsen
2012-04-11 16:16 ` Glenn Morris
2012-04-11 16:28 ` Glenn Morris
2012-04-11 17:57 ` Stefan Monnier
2012-04-11 13:02 ` Stefan Monnier
2012-04-13 0:15 ` Glenn Morris
2012-04-13 13:44 ` Stefan Monnier
2012-04-17 21:30 ` Christian Ohler
2012-04-19 7:46 ` Stefan Monnier
2012-04-20 3:09 ` Christian Ohler
2012-04-20 12:13 ` Stefan Monnier
2012-04-20 21:02 ` Christian Ohler [this message]
2012-04-21 2:34 ` Stefan Monnier
2012-04-23 13:26 ` Lennart Borgman
2012-04-24 2:04 ` Stefan Monnier
2012-05-06 18:45 ` Christian Ohler
2012-05-07 1:12 ` Stefan Monnier
2012-05-21 3:03 ` Christian Ohler
2018-08-15 1:10 ` Noam Postavsky
2020-11-24 17:34 ` Philipp Stephani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F91CEEF.20305@gnu.org \
--to=ohler@gnu.org \
--cc=11218@debbugs.gnu.org \
--cc=monnier@IRO.UMontreal.CA \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).