From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#11218: with-demoted-errors use of condition-case-unless-debug; ert Date: Tue, 14 Aug 2018 21:10:07 -0400 Message-ID: <87in4cxwnk.fsf@gmail.com> References: <4F8DE112.5010106@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1534295350 2048 195.159.176.226 (15 Aug 2018 01:09:10 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 15 Aug 2018 01:09:10 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) Cc: 11218@debbugs.gnu.org, Stefan Monnier To: Christian Ohler Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Aug 15 03:09:05 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fpkJ7-0000Qv-Hv for geb-bug-gnu-emacs@m.gmane.org; Wed, 15 Aug 2018 03:09:05 +0200 Original-Received: from localhost ([::1]:46802 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fpkLD-0000wq-RM for geb-bug-gnu-emacs@m.gmane.org; Tue, 14 Aug 2018 21:11:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44590) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fpkL4-0000wU-C5 for bug-gnu-emacs@gnu.org; Tue, 14 Aug 2018 21:11:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fpkL0-0000HW-5Q for bug-gnu-emacs@gnu.org; Tue, 14 Aug 2018 21:11:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:46198) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fpkKz-0000HR-UK for bug-gnu-emacs@gnu.org; Tue, 14 Aug 2018 21:11:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fpkKz-0003Jv-OY for bug-gnu-emacs@gnu.org; Tue, 14 Aug 2018 21:11:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 15 Aug 2018 01:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11218 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 11218-submit@debbugs.gnu.org id=B11218.153429541612707 (code B ref 11218); Wed, 15 Aug 2018 01:11:01 +0000 Original-Received: (at 11218) by debbugs.gnu.org; 15 Aug 2018 01:10:16 +0000 Original-Received: from localhost ([127.0.0.1]:51216 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fpkKG-0003Is-It for submit@debbugs.gnu.org; Tue, 14 Aug 2018 21:10:16 -0400 Original-Received: from mail-it0-f48.google.com ([209.85.214.48]:51139) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fpkKE-0003Id-Eg for 11218@debbugs.gnu.org; Tue, 14 Aug 2018 21:10:14 -0400 Original-Received: by mail-it0-f48.google.com with SMTP id j81-v6so21287107ite.0 for <11218@debbugs.gnu.org>; Tue, 14 Aug 2018 18:10:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=U2QbNCs8EFtI/5AoSCcA6Lnatmu2g5w+LPCMgj6p6kU=; b=k3SyfN+DCAeuKVEUbEiBpmfW/hM7o4obD7NevMDMPcAU6RRrcVZmhC4+j+HKcy47gf Gar9swF4mYZJ3QH0mpHwj38kyvi8KyvBYh+uROyVFdH5WkZr3CdEIdY59FNbmqFrd3+z IDGn1kiltbT8u8m2jEF3e07f/0D47MaX31PHy6vWjMqESLIlbDMDP17i32YnwrD1jduC OO1Mmz6dXEOFSJ04doX2pXLrN8FeX2VbduYtqEm4HQD9WRw9ZVfcCFHgAMM8G+KAuH9T +wkzn0UDsxfa+TlVXO1I359EXbHPzirR3RLuz4F+C0dV4G7GeEkEwCWle8uIiptPmIj2 rJsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=U2QbNCs8EFtI/5AoSCcA6Lnatmu2g5w+LPCMgj6p6kU=; b=LLoAc5bM0/QWPHuDenAYe5gqgE9+LikHEB3f6gi92hKqHsl1mPe7hElf03/CFeQUzt jPnDYI+tLvYFER2IRxCOD1aTzW+LlCO5zxdIOS6gpS+5R71gNEpEjqoTD7cn6lTIxBNC LQ/bqf6uaCuguoj3OXaRMCPitxhNUc5VJbq75xmLcv0cCksGtATZrNHSqKp6SWRFimN/ onr/KDVc85xGQ5jbLhW+yxx8bgTgyZksO5wAikYEy6Ezj17FYcNGVwhcQY5IGNagvFUh NP5tWvBDIFJ3yUiffFpWuqGepZoq2RkY3zC2tstqjz8yJuvPd/2h3iAuRSW+/PZPRaKZ K5Gw== X-Gm-Message-State: AOUpUlFZM+I8ESB2rdz5wRx3dSoOcVp6IaEsGmUglkVVF02CQz0XNjpw lxCDGnvkCCkbzmLozpw2tf0= X-Google-Smtp-Source: AA+uWPz1my5f5q2HergMitfA/9/fI4Jl+crKxd8z2QBnlPM63wizW6LtJYQZUGjctykbwF0XehVHGQ== X-Received: by 2002:a02:5cd3:: with SMTP id w80-v6mr21386098jad.85.1534295408837; Tue, 14 Aug 2018 18:10:08 -0700 (PDT) Original-Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id z195-v6sm19319646ioe.38.2018.08.14.18.10.08 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 14 Aug 2018 18:10:08 -0700 (PDT) In-Reply-To: <4F8DE112.5010106@gnu.org> (Christian Ohler's message of "Tue, 17 Apr 2012 14:30:58 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:149506 Archived-At: Christian Ohler writes: > On 4/13/12 6:44 AM, Stefan Monnier wrote: >>>>> If you replace with-demoted-errors with ignore-errors, the test passes. >>>> Looks like a bug in ERT. >>> I don't know if it's a "bug" per se... >>> ert--run-test-internal binds debug-on-error to t, and redefines the >>> debugger to ert--run-test-debugger. As the doc of that function says: >> >> I wonder why ERT doesn't just use condition-case to catch and record >> the errors. > > Two reasons that I remember off the top of my head: Recording > backtraces, and recording additional information provided with > `ert-info'. Using condition-case would let ERT regain control only > after the stack is unwound, at which point that information is gone. I just posted a patch which changes ERT to use `signal-hook-function' to record backtraces instead. It fixes the case in the OP. https://debbugs.gnu.org/cgi/bugreport.cgi?bug=30745#20 Note that condition-case also needs an enhancement to be able to catch any signal (Bug#24618), so that might be a third reason why ERT didn't go this route originally.