From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#43702: Emacs master: Incorrect highlighting in regexp isearch. Date: Wed, 07 Oct 2020 11:09:09 +0300 Organization: LINKOV.NET Message-ID: <87imbmqvki.fsf@mail.linkov.net> References: <20200929121317.GA27007@ACM> <83wo0ck5ig.fsf@gnu.org> <20200929153355.GB27007@ACM> <87y2ks819k.fsf@gnus.org> <87y2krdqsk.fsf@mail.linkov.net> <87y2kp93dn.fsf@mail.linkov.net> <87mu0z3zxf.fsf@mail.linkov.net> <83ft6qa4ky.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30481"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: acm@muc.de, larsi@gnus.org, 43702@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Oct 07 10:49:30 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kQ58b-0007py-Oh for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 07 Oct 2020 10:49:29 +0200 Original-Received: from localhost ([::1]:51418 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kQ58a-0004ar-Q7 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 07 Oct 2020 04:49:28 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50688) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kQ53L-0008Si-Au for bug-gnu-emacs@gnu.org; Wed, 07 Oct 2020 04:44:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43653) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kQ53L-0002dy-1U for bug-gnu-emacs@gnu.org; Wed, 07 Oct 2020 04:44:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kQ53L-0000Bc-0C for bug-gnu-emacs@gnu.org; Wed, 07 Oct 2020 04:44:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 07 Oct 2020 08:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43702 X-GNU-PR-Package: emacs Original-Received: via spool by 43702-submit@debbugs.gnu.org id=B43702.1602060214665 (code B ref 43702); Wed, 07 Oct 2020 08:44:02 +0000 Original-Received: (at 43702) by debbugs.gnu.org; 7 Oct 2020 08:43:34 +0000 Original-Received: from localhost ([127.0.0.1]:55198 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kQ52s-0000Af-9q for submit@debbugs.gnu.org; Wed, 07 Oct 2020 04:43:34 -0400 Original-Received: from relay3-d.mail.gandi.net ([217.70.183.195]:56289) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kQ52q-0000A9-M0 for 43702@debbugs.gnu.org; Wed, 07 Oct 2020 04:43:33 -0400 X-Originating-IP: 91.129.102.160 Original-Received: from mail.gandi.net (m91-129-102-160.cust.tele2.ee [91.129.102.160]) (Authenticated sender: juri@linkov.net) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 2BCB060013; Wed, 7 Oct 2020 08:43:23 +0000 (UTC) In-Reply-To: <83ft6qa4ky.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 07 Oct 2020 10:16:29 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:190004 Archived-At: >> > As I mentioned, it's simple to just repeat the use >> > of the same 8 faces, for 9-16, 17-24, etc. >> >> This is a very good idea. Now this is implemented in isearch. > > I don't think I understand the change, and the documentation doesn't > seem to help. It seems like now there are just two faces that are > used alternately, i.e. one face for odd-numbered groups, the other for > even-numbered groups? If this is the case, why doesn't the > documentation say so explicitly? And if this is not the case, what > did I miss? Yes, by default isearch-group-1 is used for odd-numbered groups, and isearch-group-2 for even-numbered groups. But when a user or a theme author will define a new face isearch-group-3, then isearch-group-3 will be used to highlight groups 3, 6, 9, 12, ..., the isearch-group-2 face to highlight groups 2, 5, 8, 11, ..., the isearch-group-1 face to highlight groups 1, 4, 7, 10, ... A user or a theme author can define more faces, e.g. isearch-group-4, isearch-group-5, isearch-group-6, and these faces will be recycled: submatches: 1 2 3 4 5 6 7 8 9 10 11 12 group faces: 1 2 3 4 5 6 1 2 3 4 5 6 >> I suppose you agree that the previous color palette in isearch >> with a color gradient is not suitable for highlighting of group matches >> because while looking at highlighted matches it's quite impossible to >> say which color corresponds to which group number. > > And with the current implementation on master it is possible? If so, > how? With only 2 default group faces it's possible to see that one of them isearch-group-1 is brighter than the default isearch face, and another isearch-group-2 is darker than the default isearch face.