From: Lars Ingebrigtsen <larsi@gnus.org>
To: Gabriel <gabriel376@hotmail.com>
Cc: 47286@debbugs.gnu.org
Subject: bug#47286: 28.0.50; [PATCH] Replace "(default %s)" with 'format-prompt'
Date: Wed, 24 Mar 2021 10:32:31 +0100 [thread overview]
Message-ID: <87im5gew28.fsf@gnus.org> (raw)
In-Reply-To: <CH2PR01MB5879DC6E68AC91AE809450B48B649@CH2PR01MB5879.prod.exchangelabs.com> (Gabriel's message of "Tue, 23 Mar 2021 00:47:55 -0300")
Gabriel <gabriel376@hotmail.com> writes:
> Thanks so much for your review. Here is an updated patch that removes
> the mentioned files (project.el, cc-styles.el and verilog-mode.el) and
> updates the 'format-prompt' function with the suggestion from Dmitry
> Gutov to consider an empty DEFAULT as nil. Let me know if something
> could be improved.
Looks good to me (although that latter change could probably have been a
separate patch for clarity). Pushed now to Emacs 28.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
prev parent reply other threads:[~2021-03-24 9:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-20 22:22 bug#47286: 28.0.50; [PATCH] Replace "(default %s)" with 'format-prompt' Gabriel
2021-03-21 6:07 ` Eli Zaretskii
2021-03-21 18:22 ` Gabriel
2021-03-21 15:53 ` Kévin Le Gouguec
2021-03-21 18:31 ` Gabriel
2021-03-21 18:57 ` Dmitry Gutov
2021-03-22 0:03 ` Gabriel
2021-03-22 0:48 ` Dmitry Gutov
2021-03-22 19:06 ` Lars Ingebrigtsen
2021-03-23 3:47 ` Gabriel
2021-03-24 9:32 ` Lars Ingebrigtsen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87im5gew28.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=47286@debbugs.gnu.org \
--cc=gabriel376@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).