From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#47286: 28.0.50; [PATCH] Replace "(default %s)" with 'format-prompt' Date: Wed, 24 Mar 2021 10:32:31 +0100 Message-ID: <87im5gew28.fsf@gnus.org> References: <87o8fc1p1q.fsf@gmail.com> <8735wnhute.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32639"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 47286@debbugs.gnu.org To: Gabriel Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Mar 24 10:33:27 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lOztF-0008Jn-9Q for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 24 Mar 2021 10:33:25 +0100 Original-Received: from localhost ([::1]:41570 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lOztE-0000wA-C8 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 24 Mar 2021 05:33:24 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51424) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lOzsr-0000vv-Vq for bug-gnu-emacs@gnu.org; Wed, 24 Mar 2021 05:33:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50668) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lOzsr-0000h9-O4 for bug-gnu-emacs@gnu.org; Wed, 24 Mar 2021 05:33:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lOzsr-0001bL-LD for bug-gnu-emacs@gnu.org; Wed, 24 Mar 2021 05:33:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 24 Mar 2021 09:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47286 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 47286-submit@debbugs.gnu.org id=B47286.16165783656121 (code B ref 47286); Wed, 24 Mar 2021 09:33:01 +0000 Original-Received: (at 47286) by debbugs.gnu.org; 24 Mar 2021 09:32:45 +0000 Original-Received: from localhost ([127.0.0.1]:33978 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lOzsb-0001af-Es for submit@debbugs.gnu.org; Wed, 24 Mar 2021 05:32:45 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:36954) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lOzsZ-0001W8-G9 for 47286@debbugs.gnu.org; Wed, 24 Mar 2021 05:32:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ewpIeOPfv88KliBUdPUbrilKpzt3uvIgBZj93JpWbFQ=; b=qVGGkkBW8Il0ngYBeGTIeSktvW QIaUPPOOhpTioEVOA+bliuoV7Yf9+Q2f1GMYu5QdBi12n6magwycHIEfIXw1ZiIwz/r2UjugSlOuF dt6jCOjABu2LdAgUdAsO6cvimBlqGca2GHznoYrdEcnl1gufZB7YlmoAn37SaJEMlA1M=; Original-Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lOzsQ-0007lQ-Pa; Wed, 24 Mar 2021 10:32:37 +0100 X-Now-Playing: In The Nursery's _Twins_: "The Outsider" In-Reply-To: (Gabriel's message of "Tue, 23 Mar 2021 00:47:55 -0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:202937 Archived-At: Gabriel writes: > Thanks so much for your review. Here is an updated patch that removes > the mentioned files (project.el, cc-styles.el and verilog-mode.el) and > updates the 'format-prompt' function with the suggestion from Dmitry > Gutov to consider an empty DEFAULT as nil. Let me know if something > could be improved. Looks good to me (although that latter change could probably have been a separate patch for clarity). Pushed now to Emacs 28. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no