From: Dmitry Gutov <dgutov@yandex.ru>
To: Gabriel <gabriel376@hotmail.com>, 47286@debbugs.gnu.org
Subject: bug#47286: 28.0.50; [PATCH] Replace "(default %s)" with 'format-prompt'
Date: Sun, 21 Mar 2021 20:57:04 +0200 [thread overview]
Message-ID: <2454249f-5987-8f04-a58e-0596f572bb0e@yandex.ru> (raw)
In-Reply-To: <CH2PR01MB5879D355D1B5910CD5C808808B669@CH2PR01MB5879.prod.exchangelabs.com>
On 21.03.2021 20:31, Gabriel wrote:
> Thanks for pointing it out. I just searched for the current source tree
> of master branch for ocurrences of "(default %s)", so I am not sure if I
> changed some package that shouldn't be update. If so, I will promptly
> update the patch.
>
> Perhaps project.el could use a similar fallback that exists on
> cperl-mode.el (commit 3a95f4fc12df0a570ad413e099a22bf901b7346d):
>
> ;; Available in Emacs 28: format-prompt
> (defalias 'cperl--format-prompt
> (if (fboundp 'format-prompt) 'format-prompt
> (lambda (msg default)
> (if default (format "%s (default %s): " msg default)
> (concat msg ": ")))))
Sounds reasonable to me.
Also note that project--completing-read-strict includes as (string-equal
default "") check added in 2be537e64.
Perhaps format-prompt could use it as well.
next prev parent reply other threads:[~2021-03-21 18:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-20 22:22 bug#47286: 28.0.50; [PATCH] Replace "(default %s)" with 'format-prompt' Gabriel
2021-03-21 6:07 ` Eli Zaretskii
2021-03-21 18:22 ` Gabriel
2021-03-21 15:53 ` Kévin Le Gouguec
2021-03-21 18:31 ` Gabriel
2021-03-21 18:57 ` Dmitry Gutov [this message]
2021-03-22 0:03 ` Gabriel
2021-03-22 0:48 ` Dmitry Gutov
2021-03-22 19:06 ` Lars Ingebrigtsen
2021-03-23 3:47 ` Gabriel
2021-03-24 9:32 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2454249f-5987-8f04-a58e-0596f572bb0e@yandex.ru \
--to=dgutov@yandex.ru \
--cc=47286@debbugs.gnu.org \
--cc=gabriel376@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).