From: Eli Zaretskii <eliz@gnu.org>
To: Gabriel <gabriel376@hotmail.com>
Cc: 47286@debbugs.gnu.org
Subject: bug#47286: 28.0.50; [PATCH] Replace "(default %s)" with 'format-prompt'
Date: Sun, 21 Mar 2021 08:07:44 +0200 [thread overview]
Message-ID: <83y2ehavkf.fsf@gnu.org> (raw)
In-Reply-To: <MN2PR01MB5886E726C377FFA7D48D74148B679@MN2PR01MB5886.prod.exchangelabs.com> (message from Gabriel on Sat, 20 Mar 2021 19:22:52 -0300)
> From: Gabriel <gabriel376@hotmail.com>
> Date: Sat, 20 Mar 2021 19:22:52 -0300
>
> This patches replaces several occurences of the hardcoded minibuffer
> default prompt "(default %s)" with a call to 'format-prompt'. It also
> removes the suffix ": ", when applicable, that is automatically handled
> by 'format-prompt'.
Thanks. A minor nit about formatting the commit log messages in such
cases, where the same change is made in many places.
> * lisp/cmuscheme.el (scheme-load-file, scheme-compile-file): Remove
> prompt suffix ": ".
>
> * lisp/comint.el (comint-get-source): Use 'format-prompt'.
>
> * lisp/emulation/viper-cmd.el (viper-quote-region, viper-kill-buffer)
> (viper-query-replace): Remove prompt suffix ": ".
> (viper-read-string-with-history): Use 'format-prompt'.
>
> * lisp/eshell/esh-mode.el (eshell-find-tag): Remove prompt suffix ": ".
>
> * lisp/gnus/gnus-sum.el (gnus-articles-to-read)
> (gnus-summary-search-article-forward)
> (gnus-summary-search-article-backward): Use 'format-prompt'.
Instead of having a long series of basically identical text, it is
better to format this as follows:
* lisp/cmuscheme.el (scheme-load-file, scheme-compile-file):
* lisp/comint.el (comint-get-source):
* lisp/emulation/viper-cmd.el (viper-quote-region, viper-kill-buffer)
(viper-query-replace, viper-read-string-with-history):
* lisp/eshell/esh-mode.el (eshell-find-tag):
* lisp/gnus/gnus-sum.el (gnus-articles-to-read)
(gnus-summary-search-article-forward)
(gnus-summary-search-article-backward):
* lisp/international/mule-cmds.el (set-input-method, toggle-input-method)
(describe-input-method, set-language-environment)
(describe-language-environment):
* lisp/mh-e/mh-gnus.el (mh-mml-minibuffer-read-disposition)
(mh-insert-letter)
* lisp/mh-e/mh-mime.el (mh-display-with-external-viewer)
(mh-mime-save-parts, mh-mh-forward-message)
(mh-mml-query-cryptographic-method): Remove prompt suffix and
use 'format-prompt'.
That is, have the list of files and functions, and put the description
of the change only in the last one. IME, this makes the long list
easier to read and understand.
next prev parent reply other threads:[~2021-03-21 6:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-20 22:22 bug#47286: 28.0.50; [PATCH] Replace "(default %s)" with 'format-prompt' Gabriel
2021-03-21 6:07 ` Eli Zaretskii [this message]
2021-03-21 18:22 ` Gabriel
2021-03-21 15:53 ` Kévin Le Gouguec
2021-03-21 18:31 ` Gabriel
2021-03-21 18:57 ` Dmitry Gutov
2021-03-22 0:03 ` Gabriel
2021-03-22 0:48 ` Dmitry Gutov
2021-03-22 19:06 ` Lars Ingebrigtsen
2021-03-23 3:47 ` Gabriel
2021-03-24 9:32 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83y2ehavkf.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=47286@debbugs.gnu.org \
--cc=gabriel376@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).