From: Lars Ingebrigtsen <larsi@gnus.org>
To: Jim Porter <jporterbugs@gmail.com>
Cc: 50179@debbugs.gnu.org
Subject: bug#50179: [WIP PATCH v3] Add support for "bright" ANSI colors to ansi-color and term-mode
Date: Wed, 22 Sep 2021 21:49:23 +0200 [thread overview]
Message-ID: <87ilysv1a4.fsf@gnus.org> (raw)
In-Reply-To: <0e61dc90-c315-f3cd-df83-22b9ecb029c1@gmail.com> (Jim Porter's message of "Wed, 22 Sep 2021 12:39:55 -0700")
Jim Porter <jporterbugs@gmail.com> writes:
> I don't quite know what to do about man.el though. It has overrides
> for a few of the faces used by ansi-color. I could maintain that
> behavior fairly easily, but maybe it makes sense to have it use the
> defaults from ansi-color.
Hm... I wonder why man.el is overriding the colours?
Skimming the patch, it looks good to me, but some trivial comments:
> -(defcustom ansi-color-faces-vector
> - [default bold default italic underline success warning error]
Instead of removing the variable, mark it as obsolete instead. (Users
may have code that references it in their .emacs files, and that
shouldn't bug out.)
> +(defconst ansi-color-basic-faces-vector
> + [nil
[...]
> - :type '(vector face face face face face face face face)
> - :set 'ansi-color-map-update
> - :initialize 'custom-initialize-default
> - :group 'ansi-colors)
Needs a :version.
> -(defcustom ansi-color-names-vector
> - ["black" "red3" "green3" "yellow3" "blue2" "magenta3" "cyan3" "gray90"]
Same thing with obsoletion here.
> -(defvar Man-ansi-color-map (let ((ansi-color-faces-vector
> - [ default Man-overstrike default Man-underline
> - Man-underline default default Man-reverse ]))
> - (ansi-color-make-color-map))
> - "The value used here for `ansi-color-map'.")
And same obsoletion thing here.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2021-09-22 19:49 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-24 4:02 bug#50179: [PATCH] Add support for "bright" ANSI colors to ansi-color and term-mode Jim Porter
2021-08-24 12:07 ` Eli Zaretskii
2021-08-24 17:38 ` Jim Porter
2021-08-24 17:59 ` Eli Zaretskii
2021-08-24 18:59 ` Jim Porter
2021-08-24 22:53 ` Jim Porter
2021-08-25 12:04 ` Lars Ingebrigtsen
2021-08-25 16:41 ` Jim Porter
2021-08-25 16:46 ` Lars Ingebrigtsen
2021-08-25 16:54 ` Eli Zaretskii
2021-08-26 13:23 ` Lars Ingebrigtsen
2021-09-18 18:58 ` bug#50179: [UPDATED PATCH] " Jim Porter
2021-09-19 14:45 ` Lars Ingebrigtsen
2021-09-22 19:39 ` bug#50179: [WIP PATCH v3] " Jim Porter
2021-09-22 19:49 ` Lars Ingebrigtsen [this message]
2021-09-23 1:47 ` bug#50179: [PATCH v4] " Jim Porter
2021-09-23 20:58 ` Lars Ingebrigtsen
2021-09-23 21:21 ` Jim Porter
2021-08-25 7:06 ` bug#50179: [PATCH] " Kévin Le Gouguec
2021-08-25 11:57 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ilysv1a4.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=50179@debbugs.gnu.org \
--cc=jporterbugs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).