From: Eli Zaretskii <eliz@gnu.org>
To: "Kévin Le Gouguec" <kevin.legouguec@gmail.com>
Cc: jporterbugs@gmail.com, 50179@debbugs.gnu.org
Subject: bug#50179: [PATCH] Add support for "bright" ANSI colors to ansi-color and term-mode
Date: Wed, 25 Aug 2021 14:57:30 +0300 [thread overview]
Message-ID: <83lf4pvis5.fsf@gnu.org> (raw)
In-Reply-To: <87r1eic8as.fsf@gmail.com> (message from Kévin Le Gouguec on Wed, 25 Aug 2021 09:06:35 +0200)
> From: Kévin Le Gouguec <kevin.legouguec@gmail.com>
> Cc: Jim Porter <jporterbugs@gmail.com>, 50179@debbugs.gnu.org
> Date: Wed, 25 Aug 2021 09:06:35 +0200
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> >> I made this a defcustom because `ansi-color-faces-vector' and
> >> `ansi-color-names-vector' are defcustoms too. More practically
> >> speaking, I'd want to customize this new variable to make these colors
> >> match the Emacs theme I use. I chose colors in this patch to
> >> complement `ansi-color-names-vector', but they'd clash with my theme.
> >
> > How can named colors change with the theme? Faces can, but colors are
> > absolute. Bright-yellow is the same color whatever the theme. At
> > least IMO. I wonder if others think otherwise.
>
> FWIW, a couple of Emacs's built-in themes set these ansi-color options.
> See e.g. the Modus themes, which are designed to meet WCAG's highest
> standards for colour contrast.
It's OK to set a variable. I was asking why would we want to offer
users the opportunity to customize these translations.
> Maybe there's an analogy to make with terminal emulators? Most of those
> (e.g. Konsole, Terminator, Xfce's) allow the user to customize the
> 16-color palette.
Once again, if someone _really_ wants that, they can set a variable
allright. I'm asking why would _we_ want that.
> Digging into the history of this 4-bit palette[1], it almost seems like
> no two consoles ever used the exact same colors, so these color names
> might not be as absolute as say, HTML color names[2].
I don't see how this justifies a desfcustom, sorry. If there's no
110% consensus, we can choose whatever similar color we want.
prev parent reply other threads:[~2021-08-25 11:57 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-24 4:02 bug#50179: [PATCH] Add support for "bright" ANSI colors to ansi-color and term-mode Jim Porter
2021-08-24 12:07 ` Eli Zaretskii
2021-08-24 17:38 ` Jim Porter
2021-08-24 17:59 ` Eli Zaretskii
2021-08-24 18:59 ` Jim Porter
2021-08-24 22:53 ` Jim Porter
2021-08-25 12:04 ` Lars Ingebrigtsen
2021-08-25 16:41 ` Jim Porter
2021-08-25 16:46 ` Lars Ingebrigtsen
2021-08-25 16:54 ` Eli Zaretskii
2021-08-26 13:23 ` Lars Ingebrigtsen
2021-09-18 18:58 ` bug#50179: [UPDATED PATCH] " Jim Porter
2021-09-19 14:45 ` Lars Ingebrigtsen
2021-09-22 19:39 ` bug#50179: [WIP PATCH v3] " Jim Porter
2021-09-22 19:49 ` Lars Ingebrigtsen
2021-09-23 1:47 ` bug#50179: [PATCH v4] " Jim Porter
2021-09-23 20:58 ` Lars Ingebrigtsen
2021-09-23 21:21 ` Jim Porter
2021-08-25 7:06 ` bug#50179: [PATCH] " Kévin Le Gouguec
2021-08-25 11:57 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83lf4pvis5.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=50179@debbugs.gnu.org \
--cc=jporterbugs@gmail.com \
--cc=kevin.legouguec@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).