From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#50179: [WIP PATCH v3] Add support for "bright" ANSI colors to ansi-color and term-mode Date: Wed, 22 Sep 2021 21:49:23 +0200 Message-ID: <87ilysv1a4.fsf@gnus.org> References: <838s0rvyfu.fsf@gnu.org> <83zgt6vi43.fsf@gnu.org> <87a6l5k9xr.fsf@gnus.org> <87lf4p3210.fsf@gnus.org> <831r6hv51r.fsf@gnu.org> <87h7fc2vd4.fsf@gnus.org> <871r5kpqsj.fsf@gnus.org> <0e61dc90-c315-f3cd-df83-22b9ecb029c1@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32733"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 50179@debbugs.gnu.org To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Sep 22 21:50:28 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mT8GC-0008IB-B0 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 22 Sep 2021 21:50:28 +0200 Original-Received: from localhost ([::1]:49744 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mT8GB-0001t9-0H for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 22 Sep 2021 15:50:27 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37300) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mT8Fm-0001st-Lj for bug-gnu-emacs@gnu.org; Wed, 22 Sep 2021 15:50:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40206) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mT8Fm-000775-CX for bug-gnu-emacs@gnu.org; Wed, 22 Sep 2021 15:50:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mT8Fm-0005nj-8N for bug-gnu-emacs@gnu.org; Wed, 22 Sep 2021 15:50:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 22 Sep 2021 19:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50179 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 50179-submit@debbugs.gnu.org id=B50179.163234017922262 (code B ref 50179); Wed, 22 Sep 2021 19:50:02 +0000 Original-Received: (at 50179) by debbugs.gnu.org; 22 Sep 2021 19:49:39 +0000 Original-Received: from localhost ([127.0.0.1]:51752 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mT8FO-0005mz-UG for submit@debbugs.gnu.org; Wed, 22 Sep 2021 15:49:39 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:33340) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mT8FM-0005mi-Ag for 50179@debbugs.gnu.org; Wed, 22 Sep 2021 15:49:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=+BlxIDeelZ9DcA/TTsVbfh1/overt+zvRivn7XTFyWE=; b=bQSpU4hCo7UFt5Oqy7FAeW+CXO bucxltcjiL6hWTW1iBk20yrPoNQw8skKcKERsJhi6dA/8+fHG7w7FzikpG96dPqNopEw3CAoYggGY 3ly8nVZydOnk83imgS06cCg7jT5S4hnQhRRkHSGotheMIbyl98rxNUUucZwkMVO71s38=; Original-Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mT8FA-0006gR-Ja; Wed, 22 Sep 2021 21:49:28 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAD1BMVEXYyLjFtaWTfm5W PzH////FdCktAAAAAWJLR0QEj2jZUQAAAAd0SU1FB+UJFhMoAl8MmAwAAAGtSURBVDjLZZPrlcQg CIXBbQBIAxEbmIH+e1tATdyzzh9PvuHyuAiAw/cxzjPMVBUQtb75WEB0aALAuIyRQBeIIwFIxCYw owQp1ANA0w3cgFnnKXCkJx4HUH8JvhF4Aj+kQMYBPgdomffRagdQH/+0CvgJ7hMsJUv+na0XsCzL RFmeJJwAo2/veeG/AIZGywVyxBBafYJrTAB8RUg0FqKwyrLSrFZzFjwjcIMaZ5dQmhEwCqBalaUv kLSixcDZ0fUA0cq4G8cGOHnXdHgB8U6IQmg9pPoDWlqHlQb/gExegLXN5Pz2UXce1wliJA4sd5o5 sqotdcUQiZCqiOsALf3hAChGbQGaI3HrBT4RXmTPKrxmitxQlh9VucfoQHpsjL8gXfBvtkfprr3l zrVF6YB9HBEFmFDjTYQlJgtUbgMVane8kHhIJ8idu7GMJ1kNtr229yz+8WODGZBLsqTSaNdMX3NI pyeoNiAeMyCtmLlwtbnsn9jE5fQ0pyXozQmZNqi/1BPsP4bMCE/IeptGI8EjBRg7oDGFL/mXY1Hw AGHM8M4BTq0AaUDmZsjfA34BSGFuZ4hpGIkAAAAldEVYdGRhdGU6Y3JlYXRlADIwMjEtMDktMjJU MTk6NDA6MDIrMDA6MDCrt6N+AAAAJXRFWHRkYXRlOm1vZGlmeQAyMDIxLTA5LTIyVDE5OjQwOjAy KzAwOjAw2uobwgAAAABJRU5ErkJggg== X-Now-Playing: Davitt Sigerson's _Davitt Sigerson_: "I Never Fall In Love" In-Reply-To: <0e61dc90-c315-f3cd-df83-22b9ecb029c1@gmail.com> (Jim Porter's message of "Wed, 22 Sep 2021 12:39:55 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:215121 Archived-At: Jim Porter writes: > I don't quite know what to do about man.el though. It has overrides > for a few of the faces used by ansi-color. I could maintain that > behavior fairly easily, but maybe it makes sense to have it use the > defaults from ansi-color. Hm... I wonder why man.el is overriding the colours? Skimming the patch, it looks good to me, but some trivial comments: > -(defcustom ansi-color-faces-vector > - [default bold default italic underline success warning error] Instead of removing the variable, mark it as obsolete instead. (Users may have code that references it in their .emacs files, and that shouldn't bug out.) > +(defconst ansi-color-basic-faces-vector > + [nil [...] > - :type '(vector face face face face face face face face) > - :set 'ansi-color-map-update > - :initialize 'custom-initialize-default > - :group 'ansi-colors) Needs a :version. > -(defcustom ansi-color-names-vector > - ["black" "red3" "green3" "yellow3" "blue2" "magenta3" "cyan3" "gray90"] Same thing with obsoletion here. > -(defvar Man-ansi-color-map (let ((ansi-color-faces-vector > - [ default Man-overstrike default Man-underline > - Man-underline default default Man-reverse ])) > - (ansi-color-make-color-map)) > - "The value used here for `ansi-color-map'.") And same obsoletion thing here. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no