From: Eli Zaretskii <eliz@gnu.org>
To: Jim Porter <jporterbugs@gmail.com>
Cc: 50179@debbugs.gnu.org
Subject: bug#50179: [PATCH] Add support for "bright" ANSI colors to ansi-color and term-mode
Date: Tue, 24 Aug 2021 20:59:40 +0300 [thread overview]
Message-ID: <83zgt6vi43.fsf@gnu.org> (raw)
In-Reply-To: <CANh=_JEJx-3S7S95OBKoeRff2kaaVJKBJNGy+vaBNcDb47Q0NA@mail.gmail.com> (message from Jim Porter on Tue, 24 Aug 2021 10:38:06 -0700)
> From: Jim Porter <jporterbugs@gmail.com>
> Date: Tue, 24 Aug 2021 10:38:06 -0700
> Cc: 50179@debbugs.gnu.org
>
> > I wouldn't offer a customizable list for this: users have no
> > particular reason to redefine standard colors.
>
> I made this a defcustom because `ansi-color-faces-vector' and
> `ansi-color-names-vector' are defcustoms too. More practically
> speaking, I'd want to customize this new variable to make these colors
> match the Emacs theme I use. I chose colors in this patch to
> complement `ansi-color-names-vector', but they'd clash with my theme.
How can named colors change with the theme? Faces can, but colors are
absolute. Bright-yellow is the same color whatever the theme. At
least IMO. I wonder if others think otherwise.
> > > +(defcustom term-color-bold-is-bright nil
> > > + "If set to non-nil, combining ANSI bold and a color produces the bright
> > > +version of that color."
> > > + :group 'term
> > > + :type 'boolean
> > > + :version "28.1")
> >
> > Do we really need 2 separate knobs for these two features? How
> > probable is it that the same user will want to have bright colors in
> > one package, but not in the other?
>
> I doubt anyone would want to control these independently. It'd be nice
> to have a single defcustom for this, but I wasn't sure where it should
> go in that case.
If we agree to have a single defcustom, then where to put it is
secondary.
> Would it be ok to use `ansi-color-bold-is-bright'
> (from patch 1 in `ansi-color.el') in `term.el'?
Yes, why not?
Thanks.
next prev parent reply other threads:[~2021-08-24 17:59 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-24 4:02 bug#50179: [PATCH] Add support for "bright" ANSI colors to ansi-color and term-mode Jim Porter
2021-08-24 12:07 ` Eli Zaretskii
2021-08-24 17:38 ` Jim Porter
2021-08-24 17:59 ` Eli Zaretskii [this message]
2021-08-24 18:59 ` Jim Porter
2021-08-24 22:53 ` Jim Porter
2021-08-25 12:04 ` Lars Ingebrigtsen
2021-08-25 16:41 ` Jim Porter
2021-08-25 16:46 ` Lars Ingebrigtsen
2021-08-25 16:54 ` Eli Zaretskii
2021-08-26 13:23 ` Lars Ingebrigtsen
2021-09-18 18:58 ` bug#50179: [UPDATED PATCH] " Jim Porter
2021-09-19 14:45 ` Lars Ingebrigtsen
2021-09-22 19:39 ` bug#50179: [WIP PATCH v3] " Jim Porter
2021-09-22 19:49 ` Lars Ingebrigtsen
2021-09-23 1:47 ` bug#50179: [PATCH v4] " Jim Porter
2021-09-23 20:58 ` Lars Ingebrigtsen
2021-09-23 21:21 ` Jim Porter
2021-08-25 7:06 ` bug#50179: [PATCH] " Kévin Le Gouguec
2021-08-25 11:57 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83zgt6vi43.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=50179@debbugs.gnu.org \
--cc=jporterbugs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).