bug#66470: 29.1; Provide Urdu input method

[Rahguzar via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>]

Hi Eli,

Eli Zaretskii <eliz@gnu.org> writes:

> These should be brought together, and the description should start
> with a capitalized letter and end with a period.  Like this:
>
>  * lisp/leim/quail/pakistan.el ("urdu-keyboard")
>  ("urdu-phonetic-keyboard", "urdu-custom", "sindhi-keyboard")
>  ("pashto-keyboard"): New input methods

I will fix this and the other entries of the changelog in the next
version of the patch.

>> ; (pakistan--define-quail-rules): helper function
>> ; (pakistan--make-setter): helper function
>> ; (pakistan--regenerate-translations): helper function
>> ; (pakistan--set-prefixes): helper function
>> ; (pakistan--set-numeral-translations):
>
> Why are there semi-colons here?
>

I thought these internal helper functions should be omitted from the
generated changelog. If not I will correct this too.

> While compiling this, I get byte-compiler warnings:
>
>   In pakistan--define-quail-rules:
>   leim/quail/pakistan.el:199:41: Warning: reference to free variable `pakistan-urdu-prefixes'
>
>   In pakistan--regenerate-translations:
>   leim/quail/pakistan.el:215:33: Warning: reference to free variable `pakistan-urdu-translations'
>   leim/quail/pakistan.el:217:4: Warning: reference to free variable `pakistan-urdu-diacritics-and-other-symbols'
>   leim/quail/pakistan.el:218:33: Warning: reference to free variable `pakistan-urdu-poetic-symbols'
>   leim/quail/pakistan.el:219:33: Warning: reference to free variable `pakistan-urdu-religious-symbols'
>   leim/quail/pakistan.el:220:33: Warning: reference to free variable `pakistan-extra-balochi-translations'
>   leim/quail/pakistan.el:221:33: Warning: reference to free variable `pakistan-extra-pashto-translations'
>   leim/quail/pakistan.el:222:33: Warning: reference to free variable `pakistan-extra-saraiki-translations'
>   leim/quail/pakistan.el:223:33: Warning: reference to free variable `pakistan-extra-sindhi-translations'

The byte compiler warnings are harmless in that the code referencing
those variables is run only after the variable is defined. The
`urdu-custom` input method is generated based on these customs
variables. However what the setter of one custom variable should do
depends on the value of the others which makes initializing them a
little complicated.

The only way I see of silencing the warnings is to use `defvar` to
define the variables, then define the setters which references these
variables. Is this preferable to the current state?

Thanks,
Rahguzar