From: Eli Zaretskii <eliz@gnu.org>
To: Rahguzar <rahguzar@zohomail.eu>
Cc: 66470@debbugs.gnu.org
Subject: bug#66470: 29.1; Provide Urdu input method
Date: Sat, 04 Nov 2023 10:39:05 +0200 [thread overview]
Message-ID: <83bkc96hg6.fsf@gnu.org> (raw)
In-Reply-To: <87v8apqtff.fsf@zohomail.eu> (message from Rahguzar on Sun, 29 Oct 2023 17:27:38 +0100)
> From: Rahguzar <rahguzar@zohomail.eu>
> Cc: 66470@debbugs.gnu.org
> Date: Sun, 29 Oct 2023 17:27:38 +0100
>
> Thanks for the review. I have made the changes you asked for, please
> let me know of other changes need.
Below.
> Subject: [PATCH] Input methods for Urdu, Pashto and Sindhi
>
> * lisp/leim/quail/pakistan.el (quail):
> ("urdu-keyboard"): new input method
> ("urdu-phonetic-keyboard"): new input method
> ("urdu-custom"): new input method
> ("sindhi-keyboard"): new input method
> ("pashto-keyboard"): new input method
These should be brought together, and the description should start
with a capitalized letter and end with a period. Like this:
* lisp/leim/quail/pakistan.el ("urdu-keyboard")
("urdu-phonetic-keyboard", "urdu-custom", "sindhi-keyboard")
("pashto-keyboard"): New input methods
> ; (pakistan--define-quail-rules): helper function
> ; (pakistan--make-setter): helper function
> ; (pakistan--regenerate-translations): helper function
> ; (pakistan--set-prefixes): helper function
> ; (pakistan--set-numeral-translations):
Why are there semi-colons here?
> (pakistan-urdu-input): new customization group
> (pakistan-urdu-prefixes): new custom variable
> (pakistan-urdu-translations): new custom variable
> (pakistan-urdu-diacritics-and-other-symbols): new custom var
> (pakistan-urdu-poetic-symbols): new custom var
> (pakistan-urdu-religious-symbols): new custom var
> (pakistan-extra-balochi-brahui-translations): new custom var
> (pakistan-extra-pashto-translations): new custom var
> (pakistan-extra-sindhi-translations): new custom var
> (pakistan-extra-saraiki-hindko-translations): new custom var
> (pakistan-urdu-use-roman-digits): new custom var
> (pakistan): new package
This should again be a single entry about multiple variables, since
they all share the same description: "New custom variable".
While compiling this, I get byte-compiler warnings:
In pakistan--define-quail-rules:
leim/quail/pakistan.el:199:41: Warning: reference to free variable `pakistan-urdu-prefixes'
In pakistan--regenerate-translations:
leim/quail/pakistan.el:215:33: Warning: reference to free variable `pakistan-urdu-translations'
leim/quail/pakistan.el:217:4: Warning: reference to free variable `pakistan-urdu-diacritics-and-other-symbols'
leim/quail/pakistan.el:218:33: Warning: reference to free variable `pakistan-urdu-poetic-symbols'
leim/quail/pakistan.el:219:33: Warning: reference to free variable `pakistan-urdu-religious-symbols'
leim/quail/pakistan.el:220:33: Warning: reference to free variable `pakistan-extra-balochi-translations'
leim/quail/pakistan.el:221:33: Warning: reference to free variable `pakistan-extra-pashto-translations'
leim/quail/pakistan.el:222:33: Warning: reference to free variable `pakistan-extra-saraiki-translations'
leim/quail/pakistan.el:223:33: Warning: reference to free variable `pakistan-extra-sindhi-translations'
next prev parent reply other threads:[~2023-11-04 8:39 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-11 18:36 bug#66470: 29.1; Provide Urdu input method Rahguzar via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-11 18:50 ` Rahguzar via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-14 8:53 ` Eli Zaretskii
2023-10-14 9:50 ` Rahguzar via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-14 10:53 ` Eli Zaretskii
2023-10-14 11:10 ` Rahguzar via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-14 12:36 ` Eli Zaretskii
2023-10-21 18:59 ` Rahguzar via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-22 4:53 ` Eli Zaretskii
2023-10-29 11:51 ` Eli Zaretskii
2023-10-29 16:27 ` Rahguzar via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-04 8:39 ` Eli Zaretskii [this message]
2023-11-04 8:50 ` Rahguzar via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-04 9:27 ` Eli Zaretskii
2023-11-04 10:56 ` Rahguzar via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-04 11:15 ` Eli Zaretskii
2023-11-04 14:23 ` Rahguzar via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-11 10:21 ` Eli Zaretskii
2023-11-11 11:54 ` Rahguzar via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-18 9:36 ` Eli Zaretskii
2023-11-18 11:12 ` Rahguzar via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83bkc96hg6.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=66470@debbugs.gnu.org \
--cc=rahguzar@zohomail.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).