From: Rahguzar via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 66470@debbugs.gnu.org
Subject: bug#66470: 29.1; Provide Urdu input method
Date: Sat, 04 Nov 2023 15:23:10 +0100 [thread overview]
Message-ID: <874ji1io0t.fsf@zohomail.eu> (raw)
In-Reply-To: <83v8ah4vmp.fsf@gnu.org>
Hi Eli,
Eli Zaretskii <eliz@gnu.org> writes:
> Thanks. This still has a few issues, though.
>
> First, when I try to activate the pashto-keyboard input method in
> "emacs -Q", Emacs signals en error:
>
> Symbol’s value as variable is void: pakistan-urdu-use-roman-digits
>
> I wonder how this worked for you.
I am sorry, I didn't test in a new fresh session and just evaluated the
changed code in the session I was running. I have fixed this and a more
serious issue which I didn't find for the same reason: as a result of
defvars custom initialized those values to nil instead of their standard
value. Now they are declared with a void value so that both byte
compiler and custom are happy.
>> +(defcustom pakistan-urdu-prefixes
>> + '((diacritics "o")
>> + (poetic "G")
>> + (religious "M")
>> + (balochi-brahui "B")
>> + (pashto "P")
>> + (sindhi "C")
>> + (saraiki-hindko "X"))
>> + "Prefixes for `urdu-custom' input method."
>> + :set #'pakistan--set-prefixes
>> + :type '(repeat (list symbol string))
>> + :group 'pakistan-urdu-input)
>
> Each defcustom should have a :version tag stating the first version in
> which it will appear.
Thanks, I have added the version now and removed the group, since I
remembered from another thread that there preference is not to declare
the group explicitly.
P.S. While testing this I also fixed another issue where
`pakistan--regenerate-translations` will work the first time but not
subsequent ones. The fix was to replace
(quail-install-map `(nil))
(quail-install-map (list nil))
and I don't understand why that makes a difference. But while trying to
debug this I noticed that `quail-install-map` ignores the optional NAME
argument and always installs the map in the current quail package. Is
this the intended behavior? I have now added a
(quail-select-package "urdu-custom")
before the call to `quail-install-map` to make sure regenerating the
input method in custom doesn't trample some other input method.
Sorry again for the sloppiness,
Rahguzar
next prev parent reply other threads:[~2023-11-04 14:23 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-11 18:36 bug#66470: 29.1; Provide Urdu input method Rahguzar via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-11 18:50 ` Rahguzar via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-14 8:53 ` Eli Zaretskii
2023-10-14 9:50 ` Rahguzar via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-14 10:53 ` Eli Zaretskii
2023-10-14 11:10 ` Rahguzar via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-14 12:36 ` Eli Zaretskii
2023-10-21 18:59 ` Rahguzar via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-22 4:53 ` Eli Zaretskii
2023-10-29 11:51 ` Eli Zaretskii
2023-10-29 16:27 ` Rahguzar via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-04 8:39 ` Eli Zaretskii
2023-11-04 8:50 ` Rahguzar via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-04 9:27 ` Eli Zaretskii
2023-11-04 10:56 ` Rahguzar via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-04 11:15 ` Eli Zaretskii
2023-11-04 14:23 ` Rahguzar via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2023-11-11 10:21 ` Eli Zaretskii
2023-11-11 11:54 ` Rahguzar via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-18 9:36 ` Eli Zaretskii
2023-11-18 11:12 ` Rahguzar via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874ji1io0t.fsf@zohomail.eu \
--to=bug-gnu-emacs@gnu.org \
--cc=66470@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=rahguzar@zohomail.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).