From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Rahguzar via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#66470: 29.1; Provide Urdu input method Date: Sat, 04 Nov 2023 09:50:04 +0100 Message-ID: <87h6m1j3ad.fsf@zohomail.eu> References: <87pm1lm23l.fsf@zohomail.eu> <87lec9m12g.fsf@zohomail.eu> <837cnpshz2.fsf@gnu.org> <877cnp1ojf.fsf@zohomail.eu> <83zg0lqxtq.fsf@gnu.org> <8734yd1mfm.fsf@zohomail.eu> <83sf6dqt33.fsf@gnu.org> <87zg0bye19.fsf@zohomail.eu> <83leblbq9e.fsf@gnu.org> <87v8apqtff.fsf@zohomail.eu> <83bkc96hg6.fsf@gnu.org> Reply-To: Rahguzar Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7802"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.10.7; emacs 29.1 Cc: 66470@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Nov 04 10:08:04 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qzCdP-0001lq-PN for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 04 Nov 2023 10:08:03 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qzCcp-000484-EV; Sat, 04 Nov 2023 05:07:27 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qzCco-00047b-G2 for bug-gnu-emacs@gnu.org; Sat, 04 Nov 2023 05:07:26 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qzCco-0004oy-6y for bug-gnu-emacs@gnu.org; Sat, 04 Nov 2023 05:07:26 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qzCdN-0000Mn-WA for bug-gnu-emacs@gnu.org; Sat, 04 Nov 2023 05:08:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Rahguzar Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 04 Nov 2023 09:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66470 X-GNU-PR-Package: emacs Original-Received: via spool by 66470-submit@debbugs.gnu.org id=B66470.16990888461362 (code B ref 66470); Sat, 04 Nov 2023 09:08:01 +0000 Original-Received: (at 66470) by debbugs.gnu.org; 4 Nov 2023 09:07:26 +0000 Original-Received: from localhost ([127.0.0.1]:60816 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qzCcn-0000Lt-Nx for submit@debbugs.gnu.org; Sat, 04 Nov 2023 05:07:26 -0400 Original-Received: from sender11-pp-o91.zoho.eu ([31.186.226.249]:25182) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qzCcl-0000Lh-DU for 66470@debbugs.gnu.org; Sat, 04 Nov 2023 05:07:23 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1699088798; cv=none; d=zohomail.eu; s=zohoarc; b=bx7yW3TP4w7dmmsOqfqOwdy4nTX1KtV+aEblPmXYt4of2fOS8K+AnXPLRinS839r0m8UyEz0NX0hJhTKOxwhh2rxlR061p7P+o8oEK8fySi6u1BxZuv5b/dlj28DaUJlLQoF4N3J/W/D8b2udNIxmFenBLLbEFqkAAmsm8ERSVo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.eu; s=zohoarc; t=1699088798; h=Content-Type:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=NFyYHmX38gzR801ENteA7fYcNixtElvGsF449g9FYM0=; b=D1yHeJGEAlTtrM6aHfUD/5TnomuZ7PvrEcWm6UcXwNBBBlAMr6cTF0bNpfo8S971hqonJ0Cz7pPxg9V1iVHGMvFcb8UKKrj3lFOXEG3mgQgRowSNuYaX3YTu6RDMWF+mnTaxrEvOSUROkyTv07Y2ZWUsJgBNOmYm/BVuIiTxPkM= ARC-Authentication-Results: i=1; mx.zohomail.eu; dkim=pass header.i=zohomail.eu; spf=pass smtp.mailfrom=rahguzar@zohomail.eu; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1699088798; s=zoho; d=zohomail.eu; i=rahguzar@zohomail.eu; h=References:From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:In-reply-to:Message-ID:MIME-Version:Content-Type:Message-Id:Reply-To; bh=NFyYHmX38gzR801ENteA7fYcNixtElvGsF449g9FYM0=; b=bdwZ31G1sM8m18J5WnJmdOKljreltFNFuBcRujpUqSA5TKqwWQV7PX6QCLtN2yp8 scACQlrOxMoXIy6oJadg4lQhlCzJnu3GqWXo0WqrPJrMzfjjqnlI1q+984xtjn6xKuN qlio06Ca+rNRi7lJw4t3p6CSgaQ0q7/39Mla+p3A= Original-Received: from localhost (78-73-246-128-no600.tbcn.telia.com [78.73.246.128]) by mx.zoho.eu with SMTPS id 1699088795385695.2259856688457; Sat, 4 Nov 2023 10:06:35 +0100 (CET) In-reply-to: <83bkc96hg6.fsf@gnu.org> X-ZohoMailClient: External X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:273760 Archived-At: Hi Eli, Eli Zaretskii writes: > These should be brought together, and the description should start > with a capitalized letter and end with a period. Like this: > > * lisp/leim/quail/pakistan.el ("urdu-keyboard") > ("urdu-phonetic-keyboard", "urdu-custom", "sindhi-keyboard") > ("pashto-keyboard"): New input methods I will fix this and the other entries of the changelog in the next version of the patch. >> ; (pakistan--define-quail-rules): helper function >> ; (pakistan--make-setter): helper function >> ; (pakistan--regenerate-translations): helper function >> ; (pakistan--set-prefixes): helper function >> ; (pakistan--set-numeral-translations): > > Why are there semi-colons here? > I thought these internal helper functions should be omitted from the generated changelog. If not I will correct this too. > While compiling this, I get byte-compiler warnings: > > In pakistan--define-quail-rules: > leim/quail/pakistan.el:199:41: Warning: reference to free variable `pakistan-urdu-prefixes' > > In pakistan--regenerate-translations: > leim/quail/pakistan.el:215:33: Warning: reference to free variable `pakistan-urdu-translations' > leim/quail/pakistan.el:217:4: Warning: reference to free variable `pakistan-urdu-diacritics-and-other-symbols' > leim/quail/pakistan.el:218:33: Warning: reference to free variable `pakistan-urdu-poetic-symbols' > leim/quail/pakistan.el:219:33: Warning: reference to free variable `pakistan-urdu-religious-symbols' > leim/quail/pakistan.el:220:33: Warning: reference to free variable `pakistan-extra-balochi-translations' > leim/quail/pakistan.el:221:33: Warning: reference to free variable `pakistan-extra-pashto-translations' > leim/quail/pakistan.el:222:33: Warning: reference to free variable `pakistan-extra-saraiki-translations' > leim/quail/pakistan.el:223:33: Warning: reference to free variable `pakistan-extra-sindhi-translations' The byte compiler warnings are harmless in that the code referencing those variables is run only after the variable is defined. The `urdu-custom` input method is generated based on these customs variables. However what the setter of one custom variable should do depends on the value of the others which makes initializing them a little complicated. The only way I see of silencing the warnings is to use `defvar` to define the variables, then define the setters which references these variables. Is this preferable to the current state? Thanks, Rahguzar