From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Michael Heerdegen Newsgroups: gmane.emacs.bugs Subject: bug#38195: 27.0.50; `edebug-remove-instrumentation' doesn't work for adviced functions Date: Fri, 15 Nov 2019 14:54:04 +0100 Message-ID: <87eey9z1mr.fsf@web.de> References: <87mucz98y9.fsf@web.de> <87r22brq3b.fsf@gnus.org> <87eeya9z3z.fsf@web.de> <87imnm4315.fsf@web.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="230948"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Lars Ingebrigtsen , 38195@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Nov 15 14:55:33 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iVc4S-000xuq-WC for geb-bug-gnu-emacs@m.gmane.org; Fri, 15 Nov 2019 14:55:33 +0100 Original-Received: from localhost ([::1]:39406 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iVc4R-0006fZ-1t for geb-bug-gnu-emacs@m.gmane.org; Fri, 15 Nov 2019 08:55:31 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56101) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iVc45-0006fP-1z for bug-gnu-emacs@gnu.org; Fri, 15 Nov 2019 08:55:09 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iVc44-000228-3x for bug-gnu-emacs@gnu.org; Fri, 15 Nov 2019 08:55:08 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55269) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iVc43-000220-R7 for bug-gnu-emacs@gnu.org; Fri, 15 Nov 2019 08:55:08 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iVc43-0005Uc-8L for bug-gnu-emacs@gnu.org; Fri, 15 Nov 2019 08:55:07 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Michael Heerdegen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 15 Nov 2019 13:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38195 X-GNU-PR-Package: emacs Original-Received: via spool by 38195-submit@debbugs.gnu.org id=B38195.157382605121040 (code B ref 38195); Fri, 15 Nov 2019 13:55:01 +0000 Original-Received: (at 38195) by debbugs.gnu.org; 15 Nov 2019 13:54:11 +0000 Original-Received: from localhost ([127.0.0.1]:35857 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iVc39-0005TH-2B for submit@debbugs.gnu.org; Fri, 15 Nov 2019 08:54:11 -0500 Original-Received: from mout.web.de ([212.227.17.11]:49979) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iVc37-0005T4-Dd for 38195@debbugs.gnu.org; Fri, 15 Nov 2019 08:54:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1573826034; bh=L1hnSFCUZx+CroeoA0IUm+lpNF7cbUcizxMrmD1uq00=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=kzV5pGHPtHTXziJa998gF2MeDtFsJSDw8kHUj8Tb2XpapsDaAH6v7bM/fQSfkRdRT yf7qDYiujjR3l95uw2N8hcWD4qmfV/YNilgNuP/l0EcDHtuH7T4GyDkSp2T3CngbUD xHljsZ5H52m1Eadke2A8AK+zZW4+Xd8cMUb4Lqls= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Original-Received: from drachen.dragon ([94.218.222.9]) by smtp.web.de (mrweb103 [213.165.67.124]) with ESMTPSA (Nemesis) id 0M4qWn-1hg7mp24r7-00yvcZ; Fri, 15 Nov 2019 14:53:54 +0100 In-Reply-To: <87imnm4315.fsf@web.de> (Michael Heerdegen's message of "Thu, 14 Nov 2019 21:27:18 +0100") X-Provags-ID: V03:K1:d8NgfQWqckf7DT/Hrz6Tb4f9b5CxYiqcrADf/BXxsSJJr8bEkOM 1/BP4vM7R4UPEEUPEzGB5azPlsWnITp7teS0A/UDwm/lo6zhLuJ6DbGB0F2oC8V1kWRSDNO G7kMph5nA09CrCCf3M75rJSKwuSGj1PnEgYqyqWJVEcxfJS0GUIfe63noXVHlmnr5P0BKpp djMNn1+/bmO9ua09weOUA== X-UI-Out-Filterresults: notjunk:1;V03:K0:HgYA/yX72Hw=:2yAbPmJ+NOja8YSiuL2UHr xJ7d3m2Xfv7ShW8ELrYczad4OQNKdEHeWX+dv6HkmtAyDSRsKJMcIIH/EFTqI7xtsEZS2et6k dvV4tz/G6ZeVpo1fS7YjDCQaI1PA9fBx6Z1IReXCM1nTKTXDmHH+Smg6pOpK/H78/u7TMBpgP EsfAdBcTJi4ex1IvnEoiwxx/5H8mWjZPWGj8cHEhkux3hlrOkv+kp+cz+hZkQGI+WeQIaTGEn tjl5CiP82uAy0M+wdov8F1ETLoxhbBtkPdUCbGJXy9OeVzXI27mdA9WJmtkHK0UxTTJP9RN8b rU0PUMtfoJSzxYoiKa0RHby5bBvqoeGSyhBCdRgsUlAy+ruxDlnepA4+J2k81gJRdeVbVpPJf FtcBfJp/OWbHjlhOuErLf1MqgwPPQJ5FkxBqYYgp4K2KZWR8idYsg77+kRsXISAVWdmLgtI+x ZwrIzxpgCFT2W+sfDk/8Y63f/rTbjRaWfli5+THqtSYLGdRS7Ims2K4o5BqJeMPiYeokydMY8 bsaT5Iw1Xa4dpMcRXSiXkLnyCF0pwZkWJhyboYh0jJkcjQMD1ZCbs1hFnnrepYLE+FWZ4ghjh 11Rxznxb8zey5nTi537p8HagNGh5ZvjoCygPVpag0RCgBDwdAVwvdnYZdMCJBmqqlBUn+Pgsq HbQ3Kc+0/Sy7LoZ7VEPgLSinVIT98FplYBaKrL03guqR0Mpp5h586T/n0G7IbeppNW71WU/U2 2RNEP28ZZC1olgcieC0PbM+cBLABdrqZeYRoH2iJGXJFWPRvLkBPnVGzyw3Thle9I4RHiVMN X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:171670 Archived-At: Hello again, I'm preparing a new patch with less quirks. I have a question about advising macros now. We don't say much about that, only this paragraph in (info "(elisp) Advising Named Functions"): Special forms (*note Special Forms::) cannot be advised, however macros can be advised, in much the same way as functions. Of course, this will not affect code that has already been macro-expanded, so you need to make sure the advice is installed before the macro is expanded. All good - but it seems that when you advice a macro, you actually operate on the expander _function_. Maybe we should speak that out more clearly? Because that implies that everything you deal with is a function - e.g. in an :override advice you must specify a function - if you specify a macro the thing breaks. Michael.