From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Tino Calancha Newsgroups: gmane.emacs.bugs Subject: bug#38796: 26.3; `view-lossage': Use a variable for the lossage limit Date: Thu, 27 Aug 2020 23:28:03 +0200 Message-ID: <87d03beq3g.fsf@gmail.com> References: <43aac56d-ecf1-44ed-9be1-ffb8e5f8a7ce@default> <83zhfbm448.fsf@gnu.org> <87zh8pij6e.fsf@calancha-pc.dy.bbexcite.jp> <83v9jc3o3q.fsf@gnu.org> <87wo3qj1s6.fsf@calancha-pc.dy.bbexcite.jp> <87eenygyrx.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6279"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: uyennhi.qm@gmail.com, stefankangas@gmail.com, 38796@debbugs.gnu.org, Stefan Monnier To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Aug 27 23:29:10 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kBPSI-0001Wr-0t for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 27 Aug 2020 23:29:10 +0200 Original-Received: from localhost ([::1]:41000 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kBPSG-0008SS-S3 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 27 Aug 2020 17:29:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33052) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kBPSA-0008SI-EN for bug-gnu-emacs@gnu.org; Thu, 27 Aug 2020 17:29:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:32783) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kBPSA-00083H-4r for bug-gnu-emacs@gnu.org; Thu, 27 Aug 2020 17:29:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kBPS9-0002jS-VF for bug-gnu-emacs@gnu.org; Thu, 27 Aug 2020 17:29:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Tino Calancha Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 27 Aug 2020 21:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38796 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 38796-submit@debbugs.gnu.org id=B38796.159856369410448 (code B ref 38796); Thu, 27 Aug 2020 21:29:01 +0000 Original-Received: (at 38796) by debbugs.gnu.org; 27 Aug 2020 21:28:14 +0000 Original-Received: from localhost ([127.0.0.1]:44329 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kBPRO-0002iS-2F for submit@debbugs.gnu.org; Thu, 27 Aug 2020 17:28:14 -0400 Original-Received: from mail-wm1-f45.google.com ([209.85.128.45]:52552) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kBPRL-0002iD-CJ for 38796@debbugs.gnu.org; Thu, 27 Aug 2020 17:28:12 -0400 Original-Received: by mail-wm1-f45.google.com with SMTP id q9so4285925wmj.2 for <38796@debbugs.gnu.org>; Thu, 27 Aug 2020 14:28:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=YW/2ut4wTEL0trkClAWJIGaBzxN+D2oMxOMS1ZRisiE=; b=n38GtVrl41WlGgHFaMmR6fJhWoZ/STv2Y0ugDGNjcW5IyAs9d37tCt/M3OfG5NDXnl DHjYYSWJUcs4BiBoeImmbcphE1Qf1iRFwIKk4JeRL0p+7q7vsq63RHqJ3j6G/Hmccl7u me4QSC0QMDuOTXxJ6rCLDGDzOWQ0tcqqHQxPjo9iQzGcfXB4VWFBFBT8V7Fl8pcElpzD cnjpE8QJUkkYmx6fZNNYeuwupd4/RcGYbXmvpXUzLdIWY8dChOVE5ud9nrYJ7qyE/jwg MkBtcwQozvW+Za8n7uidZOWVl1SPgfvuIGpwclL9ng0kmQbtbjC5+gI63O0G/gqkmtHZ KFfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=YW/2ut4wTEL0trkClAWJIGaBzxN+D2oMxOMS1ZRisiE=; b=Jd6WIygpu5Wm1qtQL+c4bQrjKgOTrHUgP43hRAbZbZFSABwwgid9Qo7Nt5zbK4EQEr Yfjx57OG9bmSMD2oy5YToNRm/8y6uosM4fcoVzFMkZPJDuMYUGg5jh0rA5GuPUfcfCoY WYZwD1AqZ0s8QhzsDvg4Q7S2KBzpdH2Zqh7hwFIbDY1VQSq0JJVGXJd8e3LffUoqRRTm gNC1iePAsLvNSvUW2ddwxre2j3oif//F10ePGdKoj0pIj4rAOSp4RA5kkvbAJLxjRpFj C4yh2aHEt8dRRtMS86FjkPBMsEHVjXc1wNz4sfKvZMTXN0NaAV4TTmgD1FCbvkAePZep JdHQ== X-Gm-Message-State: AOAM530QHXCsyNMZZKuIIc+TD8YSVvP7WryDtmVaacWAK63hcK7Iz4KF 7vDXpIPgjLfUTfy1JSf25HA= X-Google-Smtp-Source: ABdhPJyo8wNhoe6ahuiW4kjghmYyBC+5scoEYofS2HuoEzQG79VmAKJRcLk5ra6TkRWNVLcqT4+SUQ== X-Received: by 2002:a1c:cc0c:: with SMTP id h12mr696761wmb.57.1598563685460; Thu, 27 Aug 2020 14:28:05 -0700 (PDT) Original-Received: from localhost.example.com (64.red-83-58-61.dynamicip.rima-tde.net. [83.58.61.64]) by smtp.gmail.com with ESMTPSA id g16sm8615183wrs.88.2020.08.27.14.28.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Aug 2020 14:28:04 -0700 (PDT) In-Reply-To: <87eenygyrx.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sat, 22 Aug 2020 23:24:02 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:186572 Archived-At: Lars Ingebrigtsen writes: > Tino Calancha writes: > >>> I agree that disabling should not necessarily be implemented by >>> "abusing" the max-lossage setting. >> Yeah, it was appealing to me at first look: the code was offering >> another feature for free! >> After your comments I rethink about it and become less excited: it >> always posible that we might be hit back in other parts of the code >> if they assume a 'sensible large enough' value. > > I thought it sounded quite natural to use the same mechanism to switch > lossage logging off. `(update-lossage-size 0)' seems like a natural > thing to do to have no lossage. > Anyway, it doesn't look like you've merged the branch? I think > everybody was in favour of adding this feature. People agree with that. The friction arises because I kept the current implementation, which can be seen as abusing on it, and/or risky. [ I have neither plan nor time to redo the current implementation. ] >> Users can still safely modify the lossage limit with the >> command `update-lossage-size'. For convenience, add >> a function `lossage-size' to return the current limit. > > Hm... other functions use the convention of having a zero-parameter > function return the data, and having a parameter to set it. So > (lossage-size 500) could set it and (lossage-size) could return the > current size? I have amended the patch to do this. Thank you. FWIW I have been running Emacs almost 3 months using this branch with no issues. If Eli is OK with it, I can merge it to master next week.