unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Tony Zorman via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: John Wiegley <johnw@gnu.org>, Eli Zaretskii <eliz@gnu.org>
Cc: philipk@posteo.net, 66567@debbugs.gnu.org
Subject: bug#66567: [PATCH] use-package: Add ignored-files support to :vc keyword
Date: Tue, 14 May 2024 18:08:38 +0200	[thread overview]
Message-ID: <87cypogyux.fsf@hyperspace> (raw)
In-Reply-To: <m2msp6f6f1.fsf@newartisans.com>

Hi,

On Fri, May 03 2024 23:16, John Wiegley wrote:
>>>>>> Eli Zaretskii <eliz@gnu.org> writes:
>
>>> I'd really like to see this merged; if it helps move things along a
>>> bit quicker, I can also make the necessary changes to package-vc.el.
>
>> John, could you please review the patches and comment?
>
> Hi Eli, I’ve read through the proposed patches. What’s being proposed looks
> good to me, except that I find it odd that it mentions two new keywords in the
> ChangeLog that have nothing to do with the :vc keyword. Why conflate that into
> this changeset? I don’t see those keywords mentioned anywhere else but the
> valid keywords list, so is this for economy rather than creating two patches?

I did attach two patches to the original message, separating these out.
Though you are right that perhaps I should have also created two
separate bugs for this. It's just something I noticed along the way and
figured I'd forget again if I didn't fix it immediately.

These keywords (I hope I haven't misunderstood you and you are referring
to :make and :shell-command) do, however, have something to do with :vc
in the sense that they are sub-keywords of it, much like :ignored-files
is.

  Tony

-- 
Tony Zorman | https://tony-zorman.com/





  reply	other threads:[~2024-05-14 16:08 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-15 16:42 bug#66567: [PATCH] use-package: Add ignored-files support to :vc keyword Tony Zorman via Bug reports for GNU Emacs, the Swiss army knife of text editors
     [not found] ` <handler.66567.B.169739278328671.ack@debbugs.gnu.org>
2023-11-01  7:43   ` Tony Zorman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-01  9:09 ` Philip Kaludercic
2023-11-01 10:13   ` Tony Zorman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-01 12:48     ` Philip Kaludercic
2023-11-01 14:36       ` Tony Zorman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-01 16:38         ` Philip Kaludercic
2023-11-07 19:39           ` Tony Zorman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-07 21:24             ` Philip Kaludercic
2023-11-10 12:00               ` Tony Zorman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-16  7:32                 ` Philip Kaludercic
2024-05-02 18:57                   ` Tony Zorman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-03  6:35                     ` Eli Zaretskii
2024-05-04  6:16                       ` John Wiegley
2024-05-14 16:08                         ` Tony Zorman via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2024-05-15  1:19                           ` John Wiegley
2024-05-18 10:32                             ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87cypogyux.fsf@hyperspace \
    --to=bug-gnu-emacs@gnu.org \
    --cc=66567@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=johnw@gnu.org \
    --cc=philipk@posteo.net \
    --cc=tonyzorman@mailbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).