From: John Wiegley <johnw@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Tony Zorman <tonyzorman@mailbox.org>,
philipk@posteo.net, 66567@debbugs.gnu.org
Subject: bug#66567: [PATCH] use-package: Add ignored-files support to :vc keyword
Date: Fri, 03 May 2024 23:16:34 -0700 [thread overview]
Message-ID: <m2msp6f6f1.fsf@newartisans.com> (raw)
In-Reply-To: <868r0rjtco.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 03 May 2024 09:35:19 +0300")
>>>>> Eli Zaretskii <eliz@gnu.org> writes:
>> I'd really like to see this merged; if it helps move things along a
>> bit quicker, I can also make the necessary changes to package-vc.el.
> John, could you please review the patches and comment?
Hi Eli, I’ve read through the proposed patches. What’s being proposed looks
good to me, except that I find it odd that it mentions two new keywords in the
ChangeLog that have nothing to do with the :vc keyword. Why conflate that into
this changeset? I don’t see those keywords mentioned anywhere else but the
valid keywords list, so is this for economy rather than creating two patches?
--
John Wiegley GPG fingerprint = 4710 CF98 AF9B 327B B80F
http://newartisans.com 60E1 46C4 BD1A 7AC1 4BA2
next prev parent reply other threads:[~2024-05-04 6:16 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-15 16:42 bug#66567: [PATCH] use-package: Add ignored-files support to :vc keyword Tony Zorman via Bug reports for GNU Emacs, the Swiss army knife of text editors
[not found] ` <handler.66567.B.169739278328671.ack@debbugs.gnu.org>
2023-11-01 7:43 ` Tony Zorman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-01 9:09 ` Philip Kaludercic
2023-11-01 10:13 ` Tony Zorman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-01 12:48 ` Philip Kaludercic
2023-11-01 14:36 ` Tony Zorman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-01 16:38 ` Philip Kaludercic
2023-11-07 19:39 ` Tony Zorman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-07 21:24 ` Philip Kaludercic
2023-11-10 12:00 ` Tony Zorman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-16 7:32 ` Philip Kaludercic
2024-05-02 18:57 ` Tony Zorman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-03 6:35 ` Eli Zaretskii
2024-05-04 6:16 ` John Wiegley [this message]
2024-05-14 16:08 ` Tony Zorman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-15 1:19 ` John Wiegley
2024-05-18 10:32 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2msp6f6f1.fsf@newartisans.com \
--to=johnw@gnu.org \
--cc=66567@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=philipk@posteo.net \
--cc=tonyzorman@mailbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).