From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Tony Zorman via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#66567: [PATCH] use-package: Add ignored-files support to :vc keyword Date: Tue, 14 May 2024 18:08:38 +0200 Message-ID: <87cypogyux.fsf@hyperspace> References: <877cnn4z2v.fsf@hyperspace> <87ttq5u9fj.fsf@posteo.net> <87ttq5bx2y.fsf@hyperspace> <87r0l91vww.fsf@posteo.net> <87r0l9fsl1.fsf@hyperspace> <871qd91l9e.fsf@posteo.net> <87bkc59wv8.fsf@hyperspace> <87wmutfe8l.fsf@posteo.net> <87pm0hvmwj.fsf@hyperspace> <87msve9mri.fsf@posteo.net> <874jbg11p6.fsf@hyperspace> <868r0rjtco.fsf@gnu.org> Reply-To: Tony Zorman Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7170"; mail-complaints-to="usenet@ciao.gmane.io" Cc: philipk@posteo.net, 66567@debbugs.gnu.org To: John Wiegley , Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue May 14 18:10:32 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s6ujX-0001er-Sp for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 14 May 2024 18:10:31 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s6ujI-0001Fm-Cf; Tue, 14 May 2024 12:10:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s6uj4-0001Co-7g for bug-gnu-emacs@gnu.org; Tue, 14 May 2024 12:10:04 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s6uj3-0000Hh-Tl for bug-gnu-emacs@gnu.org; Tue, 14 May 2024 12:10:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s6uj3-00077B-NQ for bug-gnu-emacs@gnu.org; Tue, 14 May 2024 12:10:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Tony Zorman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 14 May 2024 16:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66567 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 66567-submit@debbugs.gnu.org id=B66567.171570296527334 (code B ref 66567); Tue, 14 May 2024 16:10:01 +0000 Original-Received: (at 66567) by debbugs.gnu.org; 14 May 2024 16:09:25 +0000 Original-Received: from localhost ([127.0.0.1]:40147 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s6uiT-00076o-6O for submit@debbugs.gnu.org; Tue, 14 May 2024 12:09:25 -0400 Original-Received: from mout-p-101.mailbox.org ([80.241.56.151]:36374) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s6uiN-00076g-BT for 66567@debbugs.gnu.org; Tue, 14 May 2024 12:09:23 -0400 Original-Received: from smtp102.mailbox.org (smtp102.mailbox.org [IPv6:2001:67c:2050:b231:465::102]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-101.mailbox.org (Postfix) with ESMTPS id 4Vf1Vv5ZCtz9sFk; Tue, 14 May 2024 18:08:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org; s=mail20150812; t=1715702919; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LEqvQFw+y5E864/t7F3qdX1Vn0j0XCqupz9EsigtUiA=; b=nA75h92KPLqGkUkm515Ce6ycUwVhgcCZZ4AR9klao48fHXQEka8xdHSgxBGx/Ji3Zm6cuc 05ZYsgJSEYW0GV/j49El7PLQa+6kTYe/+stsc5g9Z/ZAgrpaTWrslxL2d7Vj4SFtng3Nrd MzBqXalv2ktIdkuH6q643noOPOLrryj7pEIgkPVtCtu7cRXpRq+410WdvpO/B+c1rJuY3/ sV6BPzurwh8dWZ1Od2Yyth3noOMICJrc5v44AKksouQ+d1eDp0nPFCD0PJWYK8auew6ksK 6Zide+q3o5Vn19flhhWPj2yo+bIWvk7UceaIPlkiOwf4/YjKmhP/o8fiuxDmLg== In-Reply-To: X-MBO-RS-META: itriksagxig7gzqsmboiznbw8g48prbh X-MBO-RS-ID: 38adfa2dc950df93945 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:285029 Archived-At: Hi, On Fri, May 03 2024 23:16, John Wiegley wrote: >>>>>> Eli Zaretskii writes: > >>> I'd really like to see this merged; if it helps move things along a >>> bit quicker, I can also make the necessary changes to package-vc.el. > >> John, could you please review the patches and comment? > > Hi Eli, I=E2=80=99ve read through the proposed patches. What=E2=80=99s be= ing proposed looks > good to me, except that I find it odd that it mentions two new keywords i= n the > ChangeLog that have nothing to do with the :vc keyword. Why conflate that= into > this changeset? I don=E2=80=99t see those keywords mentioned anywhere els= e but the > valid keywords list, so is this for economy rather than creating two patc= hes? I did attach two patches to the original message, separating these out. Though you are right that perhaps I should have also created two separate bugs for this. It's just something I noticed along the way and figured I'd forget again if I didn't fix it immediately. These keywords (I hope I haven't misunderstood you and you are referring to :make and :shell-command) do, however, have something to do with :vc in the sense that they are sub-keywords of it, much like :ignored-files is. Tony --=20 Tony Zorman | https://tony-zorman.com/