unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Tony Zorman <tonyzorman@mailbox.org>, John Wiegley <johnw@gnu.org>
Cc: philipk@posteo.net, 66567@debbugs.gnu.org
Subject: bug#66567: [PATCH] use-package: Add ignored-files support to :vc keyword
Date: Fri, 03 May 2024 09:35:19 +0300	[thread overview]
Message-ID: <868r0rjtco.fsf@gnu.org> (raw)
In-Reply-To: <874jbg11p6.fsf@hyperspace> (bug-gnu-emacs@gnu.org)

> Cc: 66567@debbugs.gnu.org
> Date: Thu, 02 May 2024 20:57:41 +0200
> From:  Tony Zorman via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
> 
> On Thu, Nov 16 2023 07:32, Philip Kaludercic wrote:
> > Tony Zorman <tonyzorman@mailbox.org> writes:
> >
> >> On Tue, Nov 07 2023 21:24, Philip Kaludercic wrote:
> >>> Tony Zorman <tonyzorman@mailbox.org> writes:
> >>>> Now I'm a bit confused: where exactly? Inside of use-package or
> >>>> package-vc? Either way, I think raising an error when the user inputs
> >>>> nonsense is totally justified—I'd just like that error to be
> >>>> understandable as quickly as possible.
> >>>
> >>> I was thinking that package-vc should emit an error, but that
> >>> use-package could emit a warning, in case a new keyword is added to
> >>> package-vc specifications but hasn't yet been added to the use-package
> >>> layer -- mainly because I don't use the latter and am not that familiar
> >>> with the code.
> >>
> >> On first thought this sounds good, but I think one would end up having
> >> to sync the actual state of things in two places. What if package-vc.el
> >> had a place where it stored all available commands? Then the use-package
> >> integration could just use that. I think it would also be easier to have
> >> this codified somewhere, rather than having to check the manual every
> >> time.
> >
> > This sounds like a better solution, I can add a constant with all the
> > symbols that you can then use.  I am still a bit busy, so I cannot
> > promise when I'll manage to do so, but I'll ping you when the changes
> > have been pushed.
> 
> Can I perhaps bump this myself instead? :)
> 
> I'd really like to see this merged; if it helps move things along a
> bit quicker, I can also make the necessary changes to package-vc.el.

John, could you please review the patches and comment?





  reply	other threads:[~2024-05-03  6:35 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-15 16:42 bug#66567: [PATCH] use-package: Add ignored-files support to :vc keyword Tony Zorman via Bug reports for GNU Emacs, the Swiss army knife of text editors
     [not found] ` <handler.66567.B.169739278328671.ack@debbugs.gnu.org>
2023-11-01  7:43   ` Tony Zorman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-01  9:09 ` Philip Kaludercic
2023-11-01 10:13   ` Tony Zorman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-01 12:48     ` Philip Kaludercic
2023-11-01 14:36       ` Tony Zorman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-01 16:38         ` Philip Kaludercic
2023-11-07 19:39           ` Tony Zorman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-07 21:24             ` Philip Kaludercic
2023-11-10 12:00               ` Tony Zorman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-16  7:32                 ` Philip Kaludercic
2024-05-02 18:57                   ` Tony Zorman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-03  6:35                     ` Eli Zaretskii [this message]
2024-05-04  6:16                       ` John Wiegley
2024-05-14 16:08                         ` Tony Zorman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-15  1:19                           ` John Wiegley
2024-05-18 10:32                             ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=868r0rjtco.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=66567@debbugs.gnu.org \
    --cc=johnw@gnu.org \
    --cc=philipk@posteo.net \
    --cc=tonyzorman@mailbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).