From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#43961: read carefully: dired-file-name-at-point vs dired-filename-at-point Date: Wed, 14 Oct 2020 05:45:51 +0200 Message-ID: <87blh531xs.fsf@gnus.org> References: <20201012142522.m24zmrzzuiiao4ck@E15-2016.optimum.net> <20201013040807.xk2q54jnquthda7y@E15-2016.optimum.net> <87blh667zs.fsf@gnus.org> <20201013102511.5nuu3p3dcyr6poft@E15-2016.optimum.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2133"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 43961@debbugs.gnu.org, Richard Stallman To: Boruch Baum Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Oct 14 05:47:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kSXkr-0000Qp-TY for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 14 Oct 2020 05:47:09 +0200 Original-Received: from localhost ([::1]:52268 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kSXkq-0004Cw-Fy for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 13 Oct 2020 23:47:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40762) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kSXkk-0004Ck-03 for bug-gnu-emacs@gnu.org; Tue, 13 Oct 2020 23:47:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38023) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kSXkj-0002qb-Mv for bug-gnu-emacs@gnu.org; Tue, 13 Oct 2020 23:47:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kSXkj-0004kd-Ko for bug-gnu-emacs@gnu.org; Tue, 13 Oct 2020 23:47:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 14 Oct 2020 03:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43961 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 43961-submit@debbugs.gnu.org id=B43961.160264716318183 (code B ref 43961); Wed, 14 Oct 2020 03:47:01 +0000 Original-Received: (at 43961) by debbugs.gnu.org; 14 Oct 2020 03:46:03 +0000 Original-Received: from localhost ([127.0.0.1]:49569 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kSXjn-0004j7-0o for submit@debbugs.gnu.org; Tue, 13 Oct 2020 23:46:03 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:53756) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kSXjm-0004ib-1A for 43961@debbugs.gnu.org; Tue, 13 Oct 2020 23:46:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=SbTrkgp5j6/DxvQJHwjBxyymYIbURuU4t6qnNS5kQFE=; b=u0QJoe9hwH2W9YFCK3xH6Ew9sR Tm/VnDfXoh2NfHjHKdyX/sDuBMtRE5OlKGFYahaQKU9YvlXtFNu+rV4B4bZNdcnAXgRUHVvbwxLf7 sZbfQyi7BijRhObm75HHYr3RMnSb4tVHinCa6sA5pfPPefX76xN+PeKu4E9mxI0Hbrns=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kSXjd-0004Lr-2N; Wed, 14 Oct 2020 05:45:55 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAKlBMVEX4mS/9qC/cZTXE OjnNjDGaajBCMTHJjTJrTDH8ukb7zmv8xFb23Y3///8dEh2UAAAAAWJLR0QN9rRh9QAAAAd0SU1F B+QKDgMqCmaWB8kAAAFJSURBVDjLvZM/T4QwGIdbjIlj30vJiS7YjyBfQAYS3e4SazpqornVG/wz OmhkZXDQmxwvTDdSvoHxQ0lBaAslRgffjT78nr59KQhVBWYRpAt6NQo6hseItod44oWM4Qa0AcLY Yci2WNQC0sY9FHoeQt4RVwAPdtjmlzUw+1cPd8m9M7HzLFJRgy5zzB8JTW4fUk5NVeXw51wIcROT uAKmSPhXqbiGhM9Vgmiw2H3ygfLT5uR6nZ5PZ9X6SV6ArZpewJJwXAayUEATsnhZ+jOQq/LdVsEZ hyCXZb6X9bqiMWRyvd7kYKtUZSCL/Q3YB/wuGdQADz9spiKDGb4Wb8Wqd8BG9PlR1ioYKecNAZfq 58R/7PFbFakS5nUwgLrU2Kly/1F/BM6OEbE3p3qICKx227cQiXqmFnhR6Fgegs6LJtGBe4hj33B0 7F+qim5HHhx/gQAAACV0RVh0ZGF0ZTpjcmVhdGUAMjAyMC0xMC0xNFQwMzo0MjoxMCswMDowMP8g FZ8AAAAldEVYdGRhdGU6bW9kaWZ5ADIwMjAtMTAtMTRUMDM6NDI6MTArMDA6MDCOfa0jAAAAAElF TkSuQmCC X-Now-Playing: B. Fleischmann's _Welcome Tourist (1)_: "Guided by Beats" In-Reply-To: <20201013102511.5nuu3p3dcyr6poft@E15-2016.optimum.net> (Boruch Baum's message of "Tue, 13 Oct 2020 06:25:12 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:190460 Archived-At: Boruch Baum writes: >> Why not just have one call the other, and wrap the results in >> abbreviate-file-name? > > You could, but you wouldn't be saving anything since the inner function > would still need to perform the expansion, so for the abbreviated > function you end up in effect with an inefficient (abbrev (expand file)) > instead of a choice between (abbrev file) or (expand file). It's not about code efficiency -- whether this function is efficient or not doesn't make any difference, since we'd deprecate it, and change the callers. > Also, much of the change ends up being defaliases, docstrings and > deprecation notices, so its more clearly presented without nesting > functions. Sorry, I don't think this is a good change. Renaming these functions just because we have two almost identical ones (when we should just remove one of them) doesn't make much sense. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no