* bug#54706: 28.0.92; eldoc-print-after-edit broken
@ 2022-04-04 11:13 Leo Liu
2022-04-04 11:30 ` Eli Zaretskii
0 siblings, 1 reply; 5+ messages in thread
From: Leo Liu @ 2022-04-04 11:13 UTC (permalink / raw)
To: 54706
I just noticed that eldoc not shown in 28.0.92 after messaging commands.
I have eldoc-print-after-edit set to t a long while ago and
`recenter-top-bottom' added to eldoc-message-commands. After some
digging it seems if doc is obtained async `C-l' can trigger eldoc no
more.
I have also noted that eldoc--request-state tries to capture the buffer
editing state using (buffer-modified-tick). Note this is not backward
compatible. Previously eldoc-message-commands can be any command.
Note also eldoc-print-after-edit is a misnomer. It should probably be
renamed to eldoc-print-after-command.
I can get back the old and tested behaviour by adding these 2 lines to
eldoc-print-current-symbol-info:
@@ -880,6 +884,8 @@
(let (token)
(cond (interactive
(eldoc--invoke-strategy t))
+ ((eldoc--message-command-p last-command)
+ (eldoc--invoke-strategy nil))
((not (equal (setq token (eldoc--request-state))
eldoc--last-request-state))
(let ((non-essential t))
Diff finished. Mon Apr 4 18:58:29 2022
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#54706: 28.0.92; eldoc-print-after-edit broken
2022-04-04 11:13 bug#54706: 28.0.92; eldoc-print-after-edit broken Leo Liu
@ 2022-04-04 11:30 ` Eli Zaretskii
2022-05-05 11:18 ` Lars Ingebrigtsen
0 siblings, 1 reply; 5+ messages in thread
From: Eli Zaretskii @ 2022-04-04 11:30 UTC (permalink / raw)
To: Leo Liu; +Cc: 54706
> From: Leo Liu <sdl.web@gmail.com>
> Date: Mon, 04 Apr 2022 19:13:50 +0800
>
>
> I just noticed that eldoc not shown in 28.0.92 after messaging commands.
> I have eldoc-print-after-edit set to t a long while ago and
> `recenter-top-bottom' added to eldoc-message-commands. After some
> digging it seems if doc is obtained async `C-l' can trigger eldoc no
> more.
>
> I have also noted that eldoc--request-state tries to capture the buffer
> editing state using (buffer-modified-tick). Note this is not backward
> compatible. Previously eldoc-message-commands can be any command.
Can you please provide a simple test case for each of these issues? I
don't think I understand clearly what you are saying (I'm only a
casual user of eldoc.)
Thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#54706: 28.0.92; eldoc-print-after-edit broken
2022-04-04 11:30 ` Eli Zaretskii
@ 2022-05-05 11:18 ` Lars Ingebrigtsen
2022-05-06 4:44 ` Leo Liu
0 siblings, 1 reply; 5+ messages in thread
From: Lars Ingebrigtsen @ 2022-05-05 11:18 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: Leo Liu, 54706
Eli Zaretskii <eliz@gnu.org> writes:
> Can you please provide a simple test case for each of these issues? I
> don't think I understand clearly what you are saying (I'm only a
> casual user of eldoc.)
More information was requested, but no response was given within a
month, so I'm closing this bug report. If the problem still exists,
please respond to this email and we'll reopen the bug report.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#54706: 28.0.92; eldoc-print-after-edit broken
2022-05-05 11:18 ` Lars Ingebrigtsen
@ 2022-05-06 4:44 ` Leo Liu
2022-05-06 5:58 ` Eli Zaretskii
0 siblings, 1 reply; 5+ messages in thread
From: Leo Liu @ 2022-05-06 4:44 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: Eli Zaretskii, 54706
On 2022-05-05 13:18 +0200, Lars Ingebrigtsen wrote:
> More information was requested, but no response was given within a
> month, so I'm closing this bug report. If the problem still exists,
> please respond to this email and we'll reopen the bug report.
I think regression should be able to stay open a while longer ;)
Seriously, I have been trying to come back to this bug and I have it
bookmarked and have a test case in mind. We will fix it for 28.2.
Thanks,
Leo
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#54706: 28.0.92; eldoc-print-after-edit broken
2022-05-06 4:44 ` Leo Liu
@ 2022-05-06 5:58 ` Eli Zaretskii
0 siblings, 0 replies; 5+ messages in thread
From: Eli Zaretskii @ 2022-05-06 5:58 UTC (permalink / raw)
To: Leo Liu; +Cc: larsi, 54706
reopen 54706
thanks
> From: Leo Liu <sdl.web@gmail.com>
> Cc: Eli Zaretskii <eliz@gnu.org>, 54706@debbugs.gnu.org
> Date: Fri, 06 May 2022 12:44:52 +0800
>
> On 2022-05-05 13:18 +0200, Lars Ingebrigtsen wrote:
> > More information was requested, but no response was given within a
> > month, so I'm closing this bug report. If the problem still exists,
> > please respond to this email and we'll reopen the bug report.
>
> I think regression should be able to stay open a while longer ;)
>
> Seriously, I have been trying to come back to this bug and I have it
> bookmarked and have a test case in mind. We will fix it for 28.2.
Thanks, I'm therefore reopening this bug.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-05-06 5:58 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-04 11:13 bug#54706: 28.0.92; eldoc-print-after-edit broken Leo Liu
2022-04-04 11:30 ` Eli Zaretskii
2022-05-05 11:18 ` Lars Ingebrigtsen
2022-05-06 4:44 ` Leo Liu
2022-05-06 5:58 ` Eli Zaretskii
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).