From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Leo Liu Newsgroups: gmane.emacs.bugs Subject: bug#54706: 28.0.92; eldoc-print-after-edit broken Date: Mon, 04 Apr 2022 19:13:50 +0800 Message-ID: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17272"; mail-complaints-to="usenet@ciao.gmane.io" To: 54706@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Apr 04 13:14:40 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nbKfP-0004NC-RA for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 04 Apr 2022 13:14:39 +0200 Original-Received: from localhost ([::1]:59398 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nbKfO-0006se-Hs for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 04 Apr 2022 07:14:38 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:58564) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nbKeo-0006sR-Kz for bug-gnu-emacs@gnu.org; Mon, 04 Apr 2022 07:14:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56733) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nbKeo-0001rj-CX for bug-gnu-emacs@gnu.org; Mon, 04 Apr 2022 07:14:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nbKeo-00053t-7y for bug-gnu-emacs@gnu.org; Mon, 04 Apr 2022 07:14:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Leo Liu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 04 Apr 2022 11:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 54706 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.164907084019441 (code B ref -1); Mon, 04 Apr 2022 11:14:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 4 Apr 2022 11:14:00 +0000 Original-Received: from localhost ([127.0.0.1]:50630 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nbKel-00053U-Ti for submit@debbugs.gnu.org; Mon, 04 Apr 2022 07:14:00 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:46914) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nbKek-00053N-Le for submit@debbugs.gnu.org; Mon, 04 Apr 2022 07:13:58 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:58554) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nbKek-0006rn-Gn for bug-gnu-emacs@gnu.org; Mon, 04 Apr 2022 07:13:58 -0400 Original-Received: from [2607:f8b0:4864:20::52b] (port=47074 helo=mail-pg1-x52b.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nbKei-0001qx-UE for bug-gnu-emacs@gnu.org; Mon, 04 Apr 2022 07:13:58 -0400 Original-Received: by mail-pg1-x52b.google.com with SMTP id b130so8025137pga.13 for ; Mon, 04 Apr 2022 04:13:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:subject:date:message-id:mime-version; bh=UiDvIA+Po0/xoyMfrTjkpGodNGAS0gksU5dod9Bz7Pc=; b=cnyPzYqRGGQDtplc6gSzuL1ng36NYa5zm/pfrbscmlKZzOjRgpXO5uE4wde4zQs2XT veFx/E+lD/Q0SlrC8NWlThHJZzsilFS8H0c5AQRl9a+pkij+dVxSYnR6aABHhLFcrFTL pVOEsixM3rQ9OHG9xv/revr7FMtSNjGz0Wg9QLYWxVpvGyhNDuS/W9uWLPDQvFn8ZgmU UCJh48JzcgYg/kij92Dd5CA6HtVmGQnDBFIsGqkptIwyTIXlmBmPkmLJ3voA7PrnZhO/ miW0lL+rDlsxx40kLAjvreTMkadJlITJjprA/S8aWnL9XRx5lc6AM5Xq/MxtEugTb5Fn Fxeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=UiDvIA+Po0/xoyMfrTjkpGodNGAS0gksU5dod9Bz7Pc=; b=H3nvPZxi1D/Ora6zEJ+IwsB4nNaJrorsDIu6c/7ZtUNm8s67+7czWloa52Ut5oPxUb dwAWgHZ7DlYXwLDNRRaQ6ACrQn5hrN7gQ5GSwhzaHQwNnd5ppI5kQj353QGDQkKOZlxh +iO0priKOjP8W4UggYH5tMxEtXBeATtkfdnQ6g0p2wE36a+u59G7CAZXqHDDFLDBZaLd U1PhPJLKeoo79hVrlwn5Jk9jzI96vMTesEVphCKTNuZ8MS8z5DCWhio0SmbDsdeVc/vd LR1GaTMpMgOodQWqhXtAeHJFGu9Hrz0JNixJ29U2wtl+KvRVgWEnjOtfS4hQ9EIaDmbi ADxg== X-Gm-Message-State: AOAM5304txLTIJYGMmOLubqWOWAr07Pidk9CWiDEmA8jS+yw0SdMQrq+ QsNFRppzCRaNzpKVscNCsmxXIQ0wqx1MIMj9 X-Google-Smtp-Source: ABdhPJzUxlKz0wNBpOge0krHWyLh3a4YhF3Q+B1Xx9HyqB+CBnwZ9a4JhCvQL2NNXu8zt9oOOQm7vg== X-Received: by 2002:a63:3605:0:b0:398:6e02:8578 with SMTP id d5-20020a633605000000b003986e028578mr25476653pga.368.1649070834328; Mon, 04 Apr 2022 04:13:54 -0700 (PDT) Original-Received: from zeuss-MacBook-Air.local ([119.92.1.225]) by smtp.gmail.com with ESMTPSA id i62-20020a638741000000b00398b43168f6sm10418597pge.20.2022.04.04.04.13.52 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Apr 2022 04:13:53 -0700 (PDT) X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::52b (failed) Received-SPF: pass client-ip=2607:f8b0:4864:20::52b; envelope-from=sdl.web@gmail.com; helo=mail-pg1-x52b.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:229399 Archived-At: I just noticed that eldoc not shown in 28.0.92 after messaging commands. I have eldoc-print-after-edit set to t a long while ago and `recenter-top-bottom' added to eldoc-message-commands. After some digging it seems if doc is obtained async `C-l' can trigger eldoc no more. I have also noted that eldoc--request-state tries to capture the buffer editing state using (buffer-modified-tick). Note this is not backward compatible. Previously eldoc-message-commands can be any command. Note also eldoc-print-after-edit is a misnomer. It should probably be renamed to eldoc-print-after-command. I can get back the old and tested behaviour by adding these 2 lines to eldoc-print-current-symbol-info: @@ -880,6 +884,8 @@ (let (token) (cond (interactive (eldoc--invoke-strategy t)) + ((eldoc--message-command-p last-command) + (eldoc--invoke-strategy nil)) ((not (equal (setq token (eldoc--request-state)) eldoc--last-request-state)) (let ((non-essential t)) Diff finished. Mon Apr 4 18:58:29 2022