bug#54706: 28.0.92; eldoc-print-after-edit broken

bug#54706: 28.0.92; eldoc-print-after-edit broken

[Leo Liu]

I just noticed that eldoc not shown in 28.0.92 after messaging commands.
I have eldoc-print-after-edit set to t a long while ago and
`recenter-top-bottom' added to eldoc-message-commands. After some
digging it seems if doc is obtained async `C-l' can trigger eldoc no
more.

I have also noted that eldoc--request-state tries to capture the buffer
editing state using (buffer-modified-tick). Note this is not backward
compatible. Previously eldoc-message-commands can be any command.

Note also eldoc-print-after-edit is a misnomer. It should probably be
renamed to eldoc-print-after-command.

I can get back the old and tested behaviour by adding these 2 lines to
eldoc-print-current-symbol-info:

@@ -880,6 +884,8 @@
   (let (token)
     (cond (interactive
            (eldoc--invoke-strategy t))
+          ((eldoc--message-command-p last-command)
+           (eldoc--invoke-strategy nil))
           ((not (equal (setq token (eldoc--request-state))
                        eldoc--last-request-state))
            (let ((non-essential t))

Diff finished.  Mon Apr  4 18:58:29 2022

bug#54706: 28.0.92; eldoc-print-after-edit broken

[Eli Zaretskii]

> From: Leo Liu <sdl.web@gmail.com>
> Date: Mon, 04 Apr 2022 19:13:50 +0800
> 
> 
> I just noticed that eldoc not shown in 28.0.92 after messaging commands.
> I have eldoc-print-after-edit set to t a long while ago and
> `recenter-top-bottom' added to eldoc-message-commands. After some
> digging it seems if doc is obtained async `C-l' can trigger eldoc no
> more.
> 
> I have also noted that eldoc--request-state tries to capture the buffer
> editing state using (buffer-modified-tick). Note this is not backward
> compatible. Previously eldoc-message-commands can be any command.

Can you please provide a simple test case for each of these issues?  I
don't think I understand clearly what you are saying (I'm only a
casual user of eldoc.)

Thanks.

bug#54706: 28.0.92; eldoc-print-after-edit broken

[Lars Ingebrigtsen]

Eli Zaretskii <eliz@gnu.org> writes:

> Can you please provide a simple test case for each of these issues?  I
> don't think I understand clearly what you are saying (I'm only a
> casual user of eldoc.)

More information was requested, but no response was given within a
month, so I'm closing this bug report.  If the problem still exists,
please respond to this email and we'll reopen the bug report.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#54706: 28.0.92; eldoc-print-after-edit broken

[Leo Liu]

On 2022-05-05 13:18 +0200, Lars Ingebrigtsen wrote:
> More information was requested, but no response was given within a
> month, so I'm closing this bug report.  If the problem still exists,
> please respond to this email and we'll reopen the bug report.

I think regression should be able to stay open a while longer ;)

Seriously, I have been trying to come back to this bug and I have it
bookmarked and have a test case in mind. We will fix it for 28.2.

Thanks,
Leo

bug#54706: 28.0.92; eldoc-print-after-edit broken

[Eli Zaretskii]

reopen 54706
thanks

> From:  Leo Liu <sdl.web@gmail.com>
> Cc: Eli Zaretskii <eliz@gnu.org>,  54706@debbugs.gnu.org
> Date: Fri, 06 May 2022 12:44:52 +0800
> 
> On 2022-05-05 13:18 +0200, Lars Ingebrigtsen wrote:
> > More information was requested, but no response was given within a
> > month, so I'm closing this bug report.  If the problem still exists,
> > please respond to this email and we'll reopen the bug report.
> 
> I think regression should be able to stay open a while longer ;)
> 
> Seriously, I have been trying to come back to this bug and I have it
> bookmarked and have a test case in mind. We will fix it for 28.2.

Thanks, I'm therefore reopening this bug.