From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Protesilaos Stavrou Newsgroups: gmane.emacs.bugs Subject: bug#58092: 29.0.50; [PATCH] Add log-edit-summary-separator face Date: Mon, 26 Sep 2022 15:44:50 +0300 Message-ID: <87bkr2mhj1.fsf@protesilaos.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17032"; mail-complaints-to="usenet@ciao.gmane.io" To: 58092@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 26 14:48:33 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ocnXF-0004CF-2B for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 26 Sep 2022 14:48:33 +0200 Original-Received: from localhost ([::1]:43126 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ocnXD-00020B-Uq for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 26 Sep 2022 08:48:31 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58344) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ocnUq-0000bE-7n for bug-gnu-emacs@gnu.org; Mon, 26 Sep 2022 08:46:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50491) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ocnUo-0006B8-Ez for bug-gnu-emacs@gnu.org; Mon, 26 Sep 2022 08:46:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ocnUn-0002LP-VL for bug-gnu-emacs@gnu.org; Mon, 26 Sep 2022 08:46:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Protesilaos Stavrou Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 26 Sep 2022 12:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 58092 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.16641963078937 (code B ref -1); Mon, 26 Sep 2022 12:46:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 26 Sep 2022 12:45:07 +0000 Original-Received: from localhost ([127.0.0.1]:49569 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ocnTv-0002K5-1Y for submit@debbugs.gnu.org; Mon, 26 Sep 2022 08:45:07 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:46770) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ocnTo-0002JG-79 for submit@debbugs.gnu.org; Mon, 26 Sep 2022 08:45:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37890) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ocnTo-0007qJ-1k for bug-gnu-emacs@gnu.org; Mon, 26 Sep 2022 08:45:00 -0400 Original-Received: from relay11.mail.gandi.net ([2001:4b98:dc4:8::231]:47627) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ocnTm-0005lZ-6b for bug-gnu-emacs@gnu.org; Mon, 26 Sep 2022 08:44:59 -0400 Original-Received: (Authenticated sender: public@protesilaos.com) by mail.gandi.net (Postfix) with ESMTPSA id AEAF1100009 for ; Mon, 26 Sep 2022 12:44:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protesilaos.com; s=gm1; t=1664196292; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=6BOhhlYxHruI43vr6wz1Pqga7EHYjCVm4FRmdeEseJA=; b=ArL4iCTOKqYmwAReuLeFo0tTWK3IA4w6cevZ4iYf7GbTFH3qJT0V5Pt5N42r7mkqPZtpr7 5hY35VfEBVSykpo3WUpYX818BSYUn7Hi5OVrOuq1c7NSUufMY5sL8E1HqA84dgDH0+1Hvp VwuIvLpRhRjqUOHy/jzSqjo5Tf7Vt3k9kIPhrTx+WzfL+g7Yq3lLnT8lSWAAawyhduCOSd 9rnOqf/LuZ+nRWgDg6dUDztMQoSkdHrX5YwqxTqopZ/yGslrTVAwVf1tHE7RoTmOU10tvb 9o/eq2+HU60dT33Yu/KWaxfX5zJ1GiavKMyZXwXMgh9BniaU3TPm8+/oVUf5Hg== Received-SPF: none client-ip=2001:4b98:dc4:8::231; envelope-from=info@protesilaos.com; helo=relay11.mail.gandi.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:243653 Archived-At: --=-=-= Content-Type: text/plain Dear maintainers, The attached patch replaces some hardcoded face properties in log-edit buffers with a named face. The named face allows users/themes to customise how this line is styled. What do you think? All the best, Protesilaos (or simply "Prot") -- Protesilaos Stavrou https://protesilaos.com --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Add-log-edit-summary-separator-face.patch >From ea287b3d918c6a2cf6181c5671187143b3774bd5 Mon Sep 17 00:00:00 2001 Message-Id: From: Protesilaos Stavrou Date: Mon, 26 Sep 2022 15:41:18 +0300 Subject: [PATCH] Add log-edit-summary-separator face * etc/NEWS: Report on it. * lisp/vc/log-edit.el (log-edit-summary-separator): Add new face. (log-edit-font-lock-keywords): Replace hardcoded face attributes with named face. --- etc/NEWS | 5 +++++ lisp/vc/log-edit.el | 6 +++++- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/etc/NEWS b/etc/NEWS index 0a5b7bc29c..ced4ece35d 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -1766,6 +1766,11 @@ Writing shorter summary lines avoids truncation in contexts in which Git commands display summary lines. See the two new user options 'vc-git-log-edit-summary-target-len' and 'vc-git-log-edit-summary-max-len'. +--- +*** New 'log-edit-summary-separator' face +Styles the line that separates the log-edit headers from the log-edit +summary. + ** Message --- diff --git a/lisp/vc/log-edit.el b/lisp/vc/log-edit.el index 5290616302..25b47a75af 100644 --- a/lisp/vc/log-edit.el +++ b/lisp/vc/log-edit.el @@ -325,6 +325,10 @@ ;;; Actual code (defface log-edit-summary '((t :inherit font-lock-function-name-face)) "Face for the summary in `log-edit-mode' buffers.") +(defface log-edit-summary-separator '((t :height 0.1 :inverse-video t :extend t)) + "Face for the summary separator line in `log-edit-mode' buffers." + :version "29.1") + (defface log-edit-header '((t :inherit font-lock-keyword-face)) "Face for the headers in `log-edit-mode' buffers.") @@ -393,7 +397,7 @@ (defvar log-edit-font-lock-keywords nil lax)) ("^\n" (progn (goto-char (match-end 0)) (1+ (match-end 0))) nil - (0 '(face (:height 0.1 :inverse-video t :extend t) + (0 '(face log-edit-summary-separator display-line-numbers-disable t rear-nonsticky t)))) (log-edit--match-first-line (0 'log-edit-summary)))) -- 2.37.3 --=-=-=--