From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Federico Tedin Newsgroups: gmane.emacs.bugs Subject: bug#38317: Buffer-local variables don't work as history for read-from-minibuffer Date: Sat, 23 Nov 2019 21:36:10 +0100 Message-ID: <874kyu72kl.fsf@gmail.com> References: <87eey0lxxm.fsf@gmail.com> <87v9rcqbls.fsf@gnus.org> <5a0c68d0-4d25-bf8d-fbe8-f106b0f92210@gmx.at> <875zjareo1.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="256645"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) Cc: 38317@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Nov 23 21:39:24 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iYcBd-0014cA-6A for geb-bug-gnu-emacs@m.gmane.org; Sat, 23 Nov 2019 21:39:21 +0100 Original-Received: from localhost ([::1]:60886 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iYcBb-0007BM-CV for geb-bug-gnu-emacs@m.gmane.org; Sat, 23 Nov 2019 15:39:19 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52872) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iYcBV-0007BG-ED for bug-gnu-emacs@gnu.org; Sat, 23 Nov 2019 15:39:14 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iYcBU-0002UQ-Ey for bug-gnu-emacs@gnu.org; Sat, 23 Nov 2019 15:39:13 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49066) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iYcBU-0002UL-9a for bug-gnu-emacs@gnu.org; Sat, 23 Nov 2019 15:39:12 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iYcBT-0003gU-Rj for bug-gnu-emacs@gnu.org; Sat, 23 Nov 2019 15:39:12 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Federico Tedin Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 23 Nov 2019 20:39:06 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38317 X-GNU-PR-Package: emacs Original-Received: via spool by 38317-submit@debbugs.gnu.org id=B38317.157454152814121 (code B ref 38317); Sat, 23 Nov 2019 20:39:06 +0000 Original-Received: (at 38317) by debbugs.gnu.org; 23 Nov 2019 20:38:48 +0000 Original-Received: from localhost ([127.0.0.1]:57885 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iYcB1-0003fa-CH for submit@debbugs.gnu.org; Sat, 23 Nov 2019 15:38:45 -0500 Original-Received: from mail-wr1-f52.google.com ([209.85.221.52]:41520) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iYcAn-0003fB-Jc for 38317@debbugs.gnu.org; Sat, 23 Nov 2019 15:38:30 -0500 Original-Received: by mail-wr1-f52.google.com with SMTP id b18so12717320wrj.8 for <38317@debbugs.gnu.org>; Sat, 23 Nov 2019 12:38:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=uPx/15iEYOc25VeTM9yuSxlZA2O//WU/NFf/sHN/Yas=; b=rZPphuBYTLMSE06LDbkjKbs9s1LFMrM8+AaPZ/EHxpmY7kNWZTmfh+AXisEWR4HlLy n/1gUn7QfN2qwq1N9vyr1TR+uNkbtRNkx6FfdZ6MDqPosT/uuvCyAy7Lfcr9CiuvyI4F ARBP00bT4VigzHr8yq614brFXXCxCeg+65FpqpfyilluOfR98BWsTaZ6P6DIeapmpUlT 3IFBB/thq/FN9nsRoMKvcicqL6f5VbvwUNmRJkWliNBIMqENfGfBnU+yGgX8WnUeUhkP FI8RFl//eUIWQsgKO8+X2ak+1f+ByzfvEM38ISUmYBATvYpy60IqJ+tfIgAAx0xsNL3Y AGlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=uPx/15iEYOc25VeTM9yuSxlZA2O//WU/NFf/sHN/Yas=; b=RB4V4GDp1tt400LOStGUMirMaM3LTUh5DRbOPZZLEKiTtRHaTQmTNe0wz3PJWorqSL 02HMd2RMOKU9VA2OgHpoHhYlJQVB3/Vvs5l7rICUV2+5nlvNagLPEd1sS9UZvURollNU eorKg+xX1UAaYiYjIjeNXoGyRaiiR7iW9Y5Hopg19GhZV/J6uIvYT5hQL465lpniRPcL ZYxRF68N1dHnig1YIHaiEIMiYSWOCxO81GhqykxG/uneS7qOrGIzt2CX/H7/smndAvb3 41UiQ82XZyXMIP7LGiYGxiL8mbkY0eiIQBue7G2uBsZvsNLB3tTh6HRJfLMvITJ8+WcA lULw== X-Gm-Message-State: APjAAAW2UK+o1AkJLYs/sM9xib2PYSx2T+GJGL0bzal3Gu3OGL0ITm6z ZrI3UFeZ6/Ae0Y8Y8jMtIIs4czCiVnU= X-Google-Smtp-Source: APXvYqxWInvHOAHKDYamsE3pAZiNKYXDmalyoxX55c3JFzPF0Vuwxde37js6nK2P5Ay24ZRouGjNlQ== X-Received: by 2002:a5d:5050:: with SMTP id h16mr25551756wrt.380.1574541503362; Sat, 23 Nov 2019 12:38:23 -0800 (PST) Original-Received: from lead (ip5f5bd750.dynamic.kabel-deutschland.de. [95.91.215.80]) by smtp.gmail.com with ESMTPSA id 16sm5590614wmf.0.2019.11.23.12.38.21 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 23 Nov 2019 12:38:22 -0800 (PST) In-Reply-To: <875zjareo1.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sat, 23 Nov 2019 12:54:38 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:172346 Archived-At: I've been looking into the problem, what I found so far is: `read-from-minibuffer' works normally if HIST is not buffer-local. If HIST is buffer-local, then the history variable doesn't seem to be updated correctly after returning (so using M-p and M-n doesn't do anything). My test was: (setq test-history nil) (make-variable-buffer-local 'test-history) (read-from-minibuffer "" nil nil nil 'test-history) After running that and inputting "hello", I checked: (buffer-local-value 'test-history (current-buffer)) ;; -> nil (buffer-local-value 'test-history (get-buffer " *Minibuf-0*")) ;; -> nil (buffer-local-value 'test-history (get-buffer " *Minibuf-1*")) ;; -> nil So although `read_minibuf' does call `add-to-history' before returning (and after setting the current buffer to be the minibuffer's), my input wasn't added to any list (that I know of). This is strange, since `add-to-history' seemed to work correctly with buffer-local variables when I tested it separately. I would've expected the new history item to be added to one of the minibuffer's `test-history' local variable. So I think the first step would be to make `read_minibuf' add the new history item into the right place when HIST is buffer-local.