From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Rahguzar via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#66470: 29.1; Provide Urdu input method Date: Sat, 04 Nov 2023 15:23:10 +0100 Message-ID: <874ji1io0t.fsf@zohomail.eu> References: <87pm1lm23l.fsf@zohomail.eu> <87lec9m12g.fsf@zohomail.eu> <837cnpshz2.fsf@gnu.org> <877cnp1ojf.fsf@zohomail.eu> <83zg0lqxtq.fsf@gnu.org> <8734yd1mfm.fsf@zohomail.eu> <83sf6dqt33.fsf@gnu.org> <87zg0bye19.fsf@zohomail.eu> <83leblbq9e.fsf@gnu.org> <87v8apqtff.fsf@zohomail.eu> <83bkc96hg6.fsf@gnu.org> <87h6m1j3ad.fsf@zohomail.eu> <83zfzt50ni.fsf@gnu.org> <878r7diy29.fsf@zohomail.eu> <83v8ah4vmp.fsf@gnu.org> Reply-To: Rahguzar Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32145"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.10.7; emacs 29.1 Cc: 66470@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Nov 04 15:37:43 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qzHmR-0008BQ-I3 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 04 Nov 2023 15:37:43 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qzHmC-0003mK-DA; Sat, 04 Nov 2023 10:37:28 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qzHmA-0003m1-Ki for bug-gnu-emacs@gnu.org; Sat, 04 Nov 2023 10:37:26 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qzHmA-0001iu-Cv for bug-gnu-emacs@gnu.org; Sat, 04 Nov 2023 10:37:26 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qzHmk-0004VH-7M for bug-gnu-emacs@gnu.org; Sat, 04 Nov 2023 10:38:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Rahguzar Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 04 Nov 2023 14:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66470 X-GNU-PR-Package: emacs Original-Received: via spool by 66470-submit@debbugs.gnu.org id=B66470.169910862417231 (code B ref 66470); Sat, 04 Nov 2023 14:38:02 +0000 Original-Received: (at 66470) by debbugs.gnu.org; 4 Nov 2023 14:37:04 +0000 Original-Received: from localhost ([127.0.0.1]:35516 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qzHlo-0004Tq-Dp for submit@debbugs.gnu.org; Sat, 04 Nov 2023 10:37:04 -0400 Original-Received: from sender11-pp-o91.zoho.eu ([31.186.226.249]:25147) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qzHlm-0004Ti-T9 for 66470@debbugs.gnu.org; Sat, 04 Nov 2023 10:37:03 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1699108580; cv=none; d=zohomail.eu; s=zohoarc; b=NZ0fuajPwnXTVFr95Rk6CtnEJU0iCExgNa/FE3hNJdeEvHr1f88/A/iJa5laqghlPFNx8oGZ7PpFbQ43PULTzafrpmSBSjOafH9iMVgnDH9MFOTBUbKBvJcCAWhOjN809uI7URi4UpD8cWtfW0KaZa3evSSO5RHQ2ujH3S+ZBrU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.eu; s=zohoarc; t=1699108580; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=NkytrZdGa8ZhqIH7trK5lcFmPeiRDznpCuDDiKoJ88o=; b=ZYkc2AfDkEASovVHGdGLrrHSeW3y/9jnIZovy2+sD92KPNxwD7hi+HiPNtrWJHqxk91X9GjLAJ7eS3XmKUyK7GpcdmalWwJ63IK7yum8RFz/2fP6iT/rZLtdbIe/xDu3dn0u/cndflz413+RCu+4Y19gqS9450nPRW98cr/y9cw= ARC-Authentication-Results: i=1; mx.zohomail.eu; dkim=pass header.i=zohomail.eu; spf=pass smtp.mailfrom=rahguzar@zohomail.eu; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1699108580; s=zoho; d=zohomail.eu; i=rahguzar@zohomail.eu; h=References:From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:In-reply-to:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=NkytrZdGa8ZhqIH7trK5lcFmPeiRDznpCuDDiKoJ88o=; b=Vd22y7gzoCaG65B24XtxQQzhd3234h2L48X7W7P8XEXRJVn12tvUaubejy4nlbMb +Il5sOnaCdu3l03DNG0ktni7z+RL2+5d7JwgIN4RJf7q5Q8QQ5Xjm5yasCH0LwjI/i7 BrLpG1qidAxti+Sh5UYAo5wbie4Pywd39/clITBY= Original-Received: from localhost (78-73-246-128-no600.tbcn.telia.com [78.73.246.128]) by mx.zoho.eu with SMTPS id 1699108579261477.3888249140607; Sat, 4 Nov 2023 15:36:19 +0100 (CET) In-reply-to: <83v8ah4vmp.fsf@gnu.org> X-ZohoMailClient: External X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:273781 Archived-At: Hi Eli, Eli Zaretskii writes: > Thanks. This still has a few issues, though. > > First, when I try to activate the pashto-keyboard input method in > "emacs -Q", Emacs signals en error: > > Symbol=E2=80=99s value as variable is void: pakistan-urdu-use-roman-dig= its > > I wonder how this worked for you. I am sorry, I didn't test in a new fresh session and just evaluated the changed code in the session I was running. I have fixed this and a more serious issue which I didn't find for the same reason: as a result of defvars custom initialized those values to nil instead of their standard value. Now they are declared with a void value so that both byte compiler and custom are happy. >> +(defcustom pakistan-urdu-prefixes >> + '((diacritics "o") >> + (poetic "G") >> + (religious "M") >> + (balochi-brahui "B") >> + (pashto "P") >> + (sindhi "C") >> + (saraiki-hindko "X")) >> + "Prefixes for `urdu-custom' input method." >> + :set #'pakistan--set-prefixes >> + :type '(repeat (list symbol string)) >> + :group 'pakistan-urdu-input) > > Each defcustom should have a :version tag stating the first version in > which it will appear. Thanks, I have added the version now and removed the group, since I remembered from another thread that there preference is not to declare the group explicitly. P.S. While testing this I also fixed another issue where `pakistan--regenerate-translations` will work the first time but not subsequent ones. The fix was to replace (quail-install-map `(nil)) (quail-install-map (list nil)) and I don't understand why that makes a difference. But while trying to debug this I noticed that `quail-install-map` ignores the optional NAME argument and always installs the map in the current quail package. Is this the intended behavior? I have now added a (quail-select-package "urdu-custom") before the call to `quail-install-map` to make sure regenerating the input method in custom doesn't trample some other input method. Sorry again for the sloppiness, Rahguzar