bug#43268: Update Org for Emacs 27.2

bug#43268: Update Org for Emacs 27.2

[Kévin Le Gouguec]

Emacs 27.1 ships with Org 9.3.  Since 2019-12-03T22:27:04Z!bzg@gnu.org,
Org's maint branch has collected a few bugfixes for the 9.3 release;
would it make sense to update the emacs-27 branch with Org 9.3.8[1], so
that Emacs 27.2 includes these fixes?

As Stefan suggested in bug#42184, if our maintainers agree, I'll mark
this issue as blocking for bug#43018.


[1] Which I assume will be the final 9.3 release, since 9.4 seems just
    round the corner.

bug#43268: Update Org for Emacs 27.2

[Eli Zaretskii]

> From: Kévin Le Gouguec <kevin.legouguec@gmail.com>
> Date: Tue, 08 Sep 2020 07:06:08 +0200
> Cc: bzg@gnu.org
> 
> Emacs 27.1 ships with Org 9.3.  Since 2019-12-03T22:27:04Z!bzg@gnu.org,
> Org's maint branch has collected a few bugfixes for the 9.3 release;
> would it make sense to update the emacs-27 branch with Org 9.3.8[1], so
> that Emacs 27.2 includes these fixes?

If the Org developers think it's a good idea, sure.

> As Stefan suggested in bug#42184, if our maintainers agree, I'll mark
> this issue as blocking for bug#43018.

Will you also volunteer to remove the block when Org 9.3 is installed
in the Emacs repository?

bug#43268: Update Org for Emacs 27.2

[Michael Albinus]

Eli Zaretskii <eliz@gnu.org> writes:

Hi Eli,

>> As Stefan suggested in bug#42184, if our maintainers agree, I'll mark
>> this issue as blocking for bug#43018.
>
> Will you also volunteer to remove the block when Org 9.3 is installed
> in the Emacs repository?

Wouldn't it be sufficient if this (bug#43268) is moved to done?

Best regards, Michael.

bug#43268: Update Org for Emacs 27.2

[Eli Zaretskii]

> From: Michael Albinus <michael.albinus@gmx.de>
> Cc: Kévin Le Gouguec <kevin.legouguec@gmail.com>,
>   bzg@gnu.org,
>   43268@debbugs.gnu.org
> Date: Tue, 08 Sep 2020 16:46:55 +0200
> 
> >> As Stefan suggested in bug#42184, if our maintainers agree, I'll mark
> >> this issue as blocking for bug#43018.
> >
> > Will you also volunteer to remove the block when Org 9.3 is installed
> > in the Emacs repository?
> 
> Wouldn't it be sufficient if this (bug#43268) is moved to done?

It should, but Someone™ should actually do that...

bug#43268: Update Org for Emacs 27.2

[Kévin Le Gouguec]

Michael Albinus <michael.albinus@gmx.de> writes:

> Eli Zaretskii <eliz@gnu.org> writes:
>
>> Will you also volunteer to remove the block when Org 9.3 is installed
>> in the Emacs repository?
>
> Wouldn't it be sufficient if this (bug#43268) is moved to done?

About that…

Closing this bug seems to have removed it from the list shown at the top
of https://debbugs.gnu.org/43018 ("Fixed blocked by"); however, it's
still present on M-x debbugs-gnu-emacs-release-blocking-reports (like
42851).

1. Do we care?
2. If so,
    a. should I tell debbugs to "unblock 43018 by 43268"?
    b. should we teach debbugs.el to ignore closed bugs when listing
       blockers?

bug#43268: Update Org for Emacs 27.2

[Michael Albinus]

Kévin Le Gouguec <kevin.legouguec@gmail.com> writes:

Hi Kévin,

>>> Will you also volunteer to remove the block when Org 9.3 is installed
>>> in the Emacs repository?
>>
>> Wouldn't it be sufficient if this (bug#43268) is moved to done?
>
> About that…
>
> Closing this bug seems to have removed it from the list shown at the top
> of https://debbugs.gnu.org/43018 ("Fixed blocked by"); however, it's
> still present on M-x debbugs-gnu-emacs-release-blocking-reports (like
> 42851).

Yes, but it is marked as done.

> 1. Do we care?
> 2. If so,
>     a. should I tell debbugs to "unblock 43018 by 43268"?
>     b. should we teach debbugs.el to ignore closed bugs when listing
>        blockers?

There are different approaches. I, for example, believe the bug can be
kept in the list. Other people prefer to remove it.

Maybe we could improve debbugs-gnu-emacs-release-blocking-reports to
show only the open bugs.

Eli? Lars?

Best regards, Michael.

bug#43268: Update Org for Emacs 27.2

[Eli Zaretskii]

> From: Michael Albinus <michael.albinus@gmx.de>
> Cc: Eli Zaretskii <eliz@gnu.org>,  43268@debbugs.gnu.org, Lars Ingebrigtsen
>  <larsi@gnus.org>
> Date: Mon, 14 Dec 2020 08:50:43 +0100
> 
> Maybe we could improve debbugs-gnu-emacs-release-blocking-reports to
> show only the open bugs.

It could be useful to have an indication that it's closed, but I
wouldn't remove them nor hide them.

bug#43268: Update Org for Emacs 27.2

[Michael Albinus]

Eli Zaretskii <eliz@gnu.org> writes:

>> Maybe we could improve debbugs-gnu-emacs-release-blocking-reports to
>> show only the open bugs.
>
> It could be useful to have an indication that it's closed, but I
> wouldn't remove them nor hide them.

There is an indication. The list shows the "done" tag, and it has
another face.

Best regards, Michael.

bug#43268: Update Org for Emacs 27.2

[Eli Zaretskii]

> From: Michael Albinus <michael.albinus@gmx.de>
> Cc: kevin.legouguec@gmail.com,  43268@debbugs.gnu.org,  larsi@gnus.org
> Date: Mon, 14 Dec 2020 16:55:36 +0100
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> >> Maybe we could improve debbugs-gnu-emacs-release-blocking-reports to
> >> show only the open bugs.
> >
> > It could be useful to have an indication that it's closed, but I
> > wouldn't remove them nor hide them.
> 
> There is an indication. The list shows the "done" tag, and it has
> another face.

Then I don't think I see a problem, thanks.

bug#43268: Update Org for Emacs 27.2

[Lars Ingebrigtsen]

Michael Albinus <michael.albinus@gmx.de> writes:

> Maybe we could improve debbugs-gnu-emacs-release-blocking-reports to
> show only the open bugs.
>
> Eli? Lars?

I think I vaguely prefer having it list all the (unarchived) blocker
bugs?  Then you can watch the number of closed blocker bugs grow, which
seems satisfying.  :-)

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#43268: Update Org for Emacs 27.2

[Michael Albinus]

Lars Ingebrigtsen <larsi@gnus.org> writes:

>> Maybe we could improve debbugs-gnu-emacs-release-blocking-reports to
>> show only the open bugs.
>>
>> Eli? Lars?
>
> I think I vaguely prefer having it list all the (unarchived) blocker
> bugs?  Then you can watch the number of closed blocker bugs grow, which
> seems satisfying.  :-)

So I'll change nothing. Seeing archived bugs is even more satifying.

Best regards, Michael.

bug#43268: Update Org for Emacs 27.2

[Michael Albinus]

Michael Albinus <michael.albinus@gmx.de> writes:

>> I think I vaguely prefer having it list all the (unarchived) blocker
>> bugs?  Then you can watch the number of closed blocker bugs grow, which
>> seems satisfying.  :-)
>
> So I'll change nothing. Seeing archived bugs is even more satifying.

PS: In the bugs list, one can always hide closed / archived bugs by "M-x
debbugs-gnu-toggle-suppress" (bound to "x"). This gives also the desired
effect, if one wants to hide those bugs.

Best regards, Michael.

bug#43268: Update Org for Emacs 27.2

[Eli Zaretskii]

> From: Kévin Le Gouguec <kevin.legouguec@gmail.com>
> Cc: Eli Zaretskii <eliz@gnu.org>,  43268@debbugs.gnu.org
> Date: Sun, 13 Dec 2020 22:34:15 +0100
> 
> Closing this bug seems to have removed it from the list shown at the top
> of https://debbugs.gnu.org/43018 ("Fixed blocked by"); however, it's
> still present on M-x debbugs-gnu-emacs-release-blocking-reports (like
> 42851).
> 
> 1. Do we care?

Only if you look at the results of that command (I don't).

> 2. If so,
>     a. should I tell debbugs to "unblock 43018 by 43268"?

That'd be incorrect, because the bug could be reopened.

>     b. should we teach debbugs.el to ignore closed bugs when listing
>        blockers?

Why bother?

bug#43268: Update Org for Emacs 27.2

[Kévin Le Gouguec]

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Kévin Le Gouguec <kevin.legouguec@gmail.com>
>> Date: Tue, 08 Sep 2020 07:06:08 +0200
>> Cc: bzg@gnu.org
>> 
>> Emacs 27.1 ships with Org 9.3.  Since 2019-12-03T22:27:04Z!bzg@gnu.org,
>> Org's maint branch has collected a few bugfixes for the 9.3 release;
>> would it make sense to update the emacs-27 branch with Org 9.3.8[1], so
>> that Emacs 27.2 includes these fixes?
>
> If the Org developers think it's a good idea, sure.

Yup, I waited for Bastien's green light before opening this[1].

>> As Stefan suggested in bug#42184, if our maintainers agree, I'll mark
>> this issue as blocking for bug#43018.
>
> Will you also volunteer to remove the block when Org 9.3 is installed
> in the Emacs repository?

I solemnly vow to git fetch emacs.git 𝒮ℴ𝓂ℯ𝓌𝒽𝒶𝓉 ℛℯℊ𝓊𝓁𝒶𝓇𝓁𝓎™ and close this
issue as soon as I see 9.3.8 (or later) landing on emacs-27, in case
no-one beats me to it.

In the unfortunate event that I fail to close this issue in a timely
manner, I fully commit to an off-list message to whoever closed it in my
stead, offering my ℳℴ𝓈𝓉 𝒞ℴ𝓃𝓉𝓇𝒾𝓉ℯ 𝒜𝓅ℴ𝓁ℴℊ𝓎™ for wasting per valuable time.


[1] https://lists.gnu.org/archive/html/emacs-orgmode/2020-09/msg00371.html
    emacs-orgmode <878sdlscpr.fsf@gnu.org>

bug#43268: Update Org for Emacs 27.2

[Stefan Kangas]

Kévin Le Gouguec <kevin.legouguec@gmail.com> writes:

>>> Emacs 27.1 ships with Org 9.3.  Since 2019-12-03T22:27:04Z!bzg@gnu.org,
>>> Org's maint branch has collected a few bugfixes for the 9.3 release;
>>> would it make sense to update the emacs-27 branch with Org 9.3.8[1], so
>>> that Emacs 27.2 includes these fixes?
>>
>> If the Org developers think it's a good idea, sure.
>
> Yup, I waited for Bastien's green light before opening this[1].

What is the status here?

Eli just indicated that we will see a pre-release candidate for version
27.2 very soon.  It would be great to get Org 9.3.8 merged before then.

bug#43268: Update Org for Emacs 27.2

[Eli Zaretskii]

Ping!  Any news?  I'd like to start the pretest of Emacs 27.2 soon.

> From: Stefan Kangas <stefan@marxist.se>
> Date: Mon, 23 Nov 2020 15:09:30 -0500
> Cc: Eli Zaretskii <eliz@gnu.org>, bzg@gnu.org, 43268@debbugs.gnu.org
> 
> Kévin Le Gouguec <kevin.legouguec@gmail.com> writes:
> 
> >>> Emacs 27.1 ships with Org 9.3.  Since 2019-12-03T22:27:04Z!bzg@gnu.org,
> >>> Org's maint branch has collected a few bugfixes for the 9.3 release;
> >>> would it make sense to update the emacs-27 branch with Org 9.3.8[1], so
> >>> that Emacs 27.2 includes these fixes?
> >>
> >> If the Org developers think it's a good idea, sure.
> >
> > Yup, I waited for Bastien's green light before opening this[1].
> 
> What is the status here?
> 
> Eli just indicated that we will see a pre-release candidate for version
> 27.2 very soon.  It would be great to get Org 9.3.8 merged before then.
> 

bug#43268: Update Org for Emacs 27.2

[Bastien]

Eli Zaretskii <eliz@gnu.org> writes:

> Ping!  Any news?  I'd like to start the pretest of Emacs 27.2 soon.

The latest Org stable version is 9.4 and can safely be included in
Emacs pretest release.

I will probably release 9.4.1 over the week-end to include the latest
fixes made in the last two months.

Using 9.4.1 in the Emacs pretest release is safe too.

-- 
 Bastien

bug#43268: Update Org for Emacs 27.2

[Eli Zaretskii]

> From: Bastien <bzg@gnu.org>
> Cc: Stefan Kangas <stefan@marxist.se>,  kevin.legouguec@gmail.com,
>   43268@debbugs.gnu.org
> Date: Thu, 26 Nov 2020 17:48:19 +0100
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > Ping!  Any news?  I'd like to start the pretest of Emacs 27.2 soon.
> 
> The latest Org stable version is 9.4 and can safely be included in
> Emacs pretest release.
> 
> I will probably release 9.4.1 over the week-end to include the latest
> fixes made in the last two months.
> 
> Using 9.4.1 in the Emacs pretest release is safe too.

Thanks.  I would appreciate if someone could update the Org files in
the Emacs Git repository with whatever version you consider the best
for the Emacs 27.2 release, be it 9.4 or 9.4.1.  Would it be possible
to do that this weekend?

bug#43268: Update Org for Emacs 27.2

[Bastien]

Eli Zaretskii <eliz@gnu.org> writes:

> Thanks.  I would appreciate if someone could update the Org files in
> the Emacs Git repository with whatever version you consider the best
> for the Emacs 27.2 release, be it 9.4 or 9.4.1.  Would it be possible
> to do that this weekend?

Yes, I will do this, thanks!

-- 
 Bastien

bug#43268: Update Org for Emacs 27.2

[Eli Zaretskii]

> From: Bastien <bzg@gnu.org>
> Cc: stefan@marxist.se,  kevin.legouguec@gmail.com,  43268@debbugs.gnu.org
> Date: Thu, 26 Nov 2020 23:49:56 +0100
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > Thanks.  I would appreciate if someone could update the Org files in
> > the Emacs Git repository with whatever version you consider the best
> > for the Emacs 27.2 release, be it 9.4 or 9.4.1.  Would it be possible
> > to do that this weekend?
> 
> Yes, I will do this, thanks!

Ping!  Any news with this?

bug#43268: Update Org for Emacs 27.2

[Eli Zaretskii]

Ping! Ping!  Please update Org on the emacs-27 branch soon.  If I see
no progress with this within the next couple of days, I will
reluctantly begin preparing the Emacs 27.2 pretest with the version we
have now.

> Date: Wed, 02 Dec 2020 17:10:14 +0200
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: stefan@marxist.se, 43268@debbugs.gnu.org, kevin.legouguec@gmail.com
> 
> > From: Bastien <bzg@gnu.org>
> > Cc: stefan@marxist.se,  kevin.legouguec@gmail.com,  43268@debbugs.gnu.org
> > Date: Thu, 26 Nov 2020 23:49:56 +0100
> > 
> > Eli Zaretskii <eliz@gnu.org> writes:
> > 
> > > Thanks.  I would appreciate if someone could update the Org files in
> > > the Emacs Git repository with whatever version you consider the best
> > > for the Emacs 27.2 release, be it 9.4 or 9.4.1.  Would it be possible
> > > to do that this weekend?
> > 
> > Yes, I will do this, thanks!
> 
> Ping!  Any news with this?

bug#43268: Update Org for Emacs 27.2

[Bastien]

Hi Eli,

sorry, I was snowed under my job tasks, I will proceed ASAP.

Eli Zaretskii <eliz@gnu.org> writes:

> Ping! Ping!  Please update Org on the emacs-27 branch soon.  If I see
> no progress with this within the next couple of days, I will
> reluctantly begin preparing the Emacs 27.2 pretest with the version we
> have now.

-- 
 Bastien

bug#43268: Update Org for Emacs 27.2

[Eli Zaretskii]

> From: Bastien <bzg@gnu.org>
> Cc: stefan@marxist.se,  43268@debbugs.gnu.org,  kevin.legouguec@gmail.com
> Date: Tue, 08 Dec 2020 16:35:25 +0100
> 
> Hi Eli,
> 
> sorry, I was snowed under my job tasks, I will proceed ASAP.

Thank you.

bug#43268: Update Org for Emacs 27.2

[Kévin Le Gouguec]

With 2020-12-13 "Update to Org 9.4.1" (f22856a5c5), Org has been updated
on the emacs-27 branch.  I'm therefore closing this.

Thank you Bastien! 🙏

bug#43268: Update Org for Emacs 27.2

[Kévin Le Gouguec]

Bastien <bzg@gnu.org> writes:

> I will probably release 9.4.1 over the week-end to include the latest
> fixes made in the last two months.
>
> Using 9.4.1 in the Emacs pretest release is safe too.

Mmm, I can name a few somewhat-disruptive changes in 9.4 that might
throw people off.  For example:

- the new default value for org-startup-folded, as well as some pesky
  side-effects with logbook visibility[1],

- RET and C-j honoring electric-indent-mode (thus bringing Org in line
  with the rest of Emacs), which has caused some uproar on the mailing
  list recently[2].

(And then there's everything under "Incompatible changes" in ORG-NEWS.)

It's not my call of course, but I would argue that if we want 27.2 to be
a no-surprise, bugfix-only release, 9.3.8 would be a safer option.


[1] https://orgmode.org/list/875z83hwuc.fsf@gmail.com/
    tl;dr:

    $ wget https://orgmode.org/list/87eepuz0bj.fsf@gmail.com/2-logbooks.org
    $ emacs -Q 2-logbooks.org
    C-s bug

    - with Org up to 9.3.8, logbooks remain closed;

    - with Org 9.4, logbooks are opened during the search; this adds a
      lot of clutter and robs the user of a lot of context;
      (can reproduce on maint, 2d23d55ac)

    - this can also be reproduced with Org master, 9a154910e, although I
      could have sworn that Ihor (CC'ed) had committed something to
      address this.

[2] https://orgmode.org/list/2020-11-13T18-23-43@devnull.Karl-Voit.at/t/
    tl;dr:
    Lots of Org users were using RET with electric-indent-mode on,
    unaware that their prose was one TAB away from being indented.  9.4
    made RET honor electric-indent-mode and indents, and much grief
    ensued.
    My (maybe biased) takeway is that the default value of
    org-adapt-indentation should be changed, as evidenced by the
    non-indented reference examples shown on orgmode.org, and the
    .dir-locals.el setting at the root of Org's repo.

bug#43268: Update Org for Emacs 27.2

[Bastien]

Hi Kévin,

Kévin Le Gouguec <kevin.legouguec@gmail.com> writes:

> Mmm, I can name a few somewhat-disruptive changes in 9.4 that might
> throw people off.  For example:
>
> - the new default value for org-startup-folded, as well as some pesky
>   side-effects with logbook visibility[1],

this looks like a bug that needs to be fixed, I will have a look this
week-end.

> - RET and C-j honoring electric-indent-mode (thus bringing Org in line
>   with the rest of Emacs), which has caused some uproar on the mailing
>   list recently[2].

If it makes Org more consistent with other Emacs modes, it looks like
a good change, so I would not discard this one.

> (And then there's everything under "Incompatible changes" in
> ORG-NEWS.)

I don't see anything problematic here.

> It's not my call of course, but I would argue that if we want 27.2 to be
> a no-surprise, bugfix-only release, 9.3.8 would be a safer option.

I think merging Org 9.4.x into Emacs 27.2 is a good way to propagate
latest Org changes, I'm not sure they qualify as "surprising" changes,
but I won't argue.

-- 
 Bastien